fixes docker manifest script for hardenend runner - #3784
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe release pipeline hardening updates egress allowlists to permit CloudFront access in both Docker manifest jobs, and refactors both manifest creation scripts with Bash strict mode, jq-based digest parsing, and quoted variable references. ChangesDocker Manifest Release Pipeline Hardening
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
|
Merge activity
|
Confidence Score: 5/5Safe to merge — all changes are additive CI hardening fixes with no impact on application code. The scripts now fail fast on bad digests instead of silently pushing a broken manifest, and the missing CloudFront endpoint unblocks Docker Hub pushes under the hardened runner. Both changes are straightforward and correct. No files require special attention. Important Files Changed
Reviews (1): Last reviewed commit: "fixes docker manifest script for hardene..." | Re-trigger Greptile |

Summary
Fixes intermittent Docker registry connectivity issues in the release pipeline and hardens the Docker manifest shell scripts.
Changes
production.cloudfront.docker.com:443to the allowed egress hosts in the release pipeline workflow, alongside the existingproduction.cloudflare.docker.com:443entry, to ensure Docker registry pulls succeed regardless of which CDN endpoint is used.#!/usr/bin/env bashshebang andset -euo pipefailto bothcreate-docker-manifest.shandcreate-docker-manifest-ubi9.shso the scripts fail fast on errors, unset variables, or pipeline failures.jq -rtojq -erso thatjqexits with a non-zero status if the extracted digest value is null or empty, preventing silent failures when building manifests.create-docker-manifest.sh.Type of change
Affected areas
How to test
Trigger a release pipeline run and verify that Docker manifest creation completes successfully for both standard and UBI9 images across amd64 and arm64 platforms.
Breaking changes
Related issues
Security considerations
No security implications. Changes are limited to CI workflow egress rules and shell script robustness.
Checklist
docs/contributing/README.mdand followed the guidelines