chore: bump Bifrost Helm chart to 2.1.18 with modelParametersUrl support - #3743
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe pull request bumps the Bifrost Helm chart version from 2.1.17 to 2.1.18 across the chart metadata, README changelog, and repository index. The version release introduces the ChangesBifrost Helm Chart 2.1.18 Release
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
BearTS
changed the title
modelParametersUrl support
Merge activity
|
Confidence Score: 3/5The release packaging is fine, but the feature it ships has a logic gap in the template that causes the custom URL to be silently discarded when used alone, and the changelog documents the wrong values path. The Helm template condition in
Important Files Changed
Reviews (1): Last reviewed commit: "chore: bump helm version to 2.1.18" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| ## Changelog | ||
|
|
||
| ### 2.1.18 | ||
| - Added `bifrost.modelCatalog.modelParametersUrl` to `values.yaml`, `values.schema.json`, and `_helpers.tpl`, allowing operators to override the URL Bifrost uses to fetch model parameter definitions. |
There was a problem hiding this comment.
The changelog entry documents bifrost.modelCatalog.modelParametersUrl, but the actual Helm values path is bifrost.framework.pricing.modelParametersUrl (as seen in values.yaml line 260 and _helpers.tpl line 319). An operator following this changelog entry to set the value would be placing the key under the wrong hierarchy and it would have no effect.
| ## Changelog | ||
|
|
||
| ### 2.1.18 | ||
| - Added `bifrost.modelCatalog.modelParametersUrl` to `values.yaml`, `values.schema.json`, and `_helpers.tpl`, allowing operators to override the URL Bifrost uses to fetch model parameter definitions. |
There was a problem hiding this comment.
modelParametersUrl silently dropped when set alone
In templates/_helpers.tpl line 325, the condition that writes the pricing block into the framework config is {{- if or $pricing.pricing_url $pricing.pricing_sync_interval }}. It does not include $pricing.model_parameters_url. If an operator sets only bifrost.framework.pricing.modelParametersUrl (without pricingUrl or pricingSyncInterval), the entire pricing dict — including model_parameters_url — is never added to $framework, and the custom URL is silently discarded. The feature is non-functional in isolation.
2 participants
Summary
Adds support for overriding the URL Bifrost uses to fetch model parameter definitions, giving operators more control over model catalog configuration.
Changes
bifrost.modelCatalog.modelParametersUrltovalues.yaml,values.schema.json, and_helpers.tpl, enabling operators to supply a custom URL for model parameter definitions.2.1.17to2.1.18.helm-charts/index.yamlwith the new chart release entry.Type of change
Affected areas
How to test
Deploy the Helm chart with a custom
modelParametersUrlset and verify Bifrost uses the specified URL to fetch model parameter definitions.helm upgrade --install bifrost ./helm-charts/bifrost \ --set bifrost.modelCatalog.modelParametersUrl="https://your-custom-url/model-params.json"Confirm the rendered config includes the overridden URL and that Bifrost fetches model parameters from the specified endpoint.
Screenshots/Recordings
N/A
Breaking changes
Related issues
N/A
Security considerations
Operators should ensure the URL provided for
modelParametersUrlpoints to a trusted source, as it will be used to load model parameter definitions into the gateway.Checklist
docs/contributing/README.mdand followed the guidelines