Skip to content

feat: preserve time filter params when navigating between sidebar items #3647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akshaydeo merged 1 commit into from
May 21, 2026
Merged

feat: preserve time filter params when navigating between sidebar items #3647

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 26 additions & 21 deletions ui/components/sidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,29 @@ const TimeFilterPages = new Set([
"/workspace/mcp-logs",
]);

const preserveTimeFilters = (
baseHref: string,
subItemUrl: string,
pathname: string,
search: string,
): string => {
if (TimeFilterPages.has(subItemUrl) && TimeFilterPages.has(pathname)) {
const currentParams = new URLSearchParams(search);
const startTime = currentParams.get("start_time");
const endTime = currentParams.get("end_time");
const period = currentParams.get("period");
if ((startTime && endTime) || period) {
const params = new URLSearchParams();
if (startTime) params.set("start_time", startTime);
if (endTime) params.set("end_time", endTime);
if (period) params.set("period", period);
const sep = baseHref.includes("?") ? "&" : "?";
return `${baseHref}${sep}${params.toString()}`;
}
}
return baseHref;
};

const SidebarItemView = ({
item,
isActive,
Expand Down Expand Up @@ -405,7 +428,8 @@ const SidebarItemView = ({
{item.title}
</div>
{item.subItems?.map((subItem) => {
const href = getSidebarItemHref(subItem);
const baseHref = getSidebarItemHref(subItem);
const href = preserveTimeFilters(baseHref, subItem.url, pathname, search);
const isSubItemActive = subItem.queryParam
? pathname === subItem.url
: isRouteMatch(subItem.url);
Expand Down Expand Up @@ -468,26 +492,7 @@ const SidebarItemView = ({
<SidebarMenuSub className="border-sidebar-border mt-1 ml-4 space-y-0.5 border-l pl-2">
{item.subItems?.map((subItem: SidebarItem) => {
const baseHref = getSidebarItemHref(subItem);
const subItemHref = (() => {
if (
TimeFilterPages.has(subItem.url) &&
TimeFilterPages.has(pathname)
) {
const currentParams = new URLSearchParams(search);
const startTime = currentParams.get("start_time");
const endTime = currentParams.get("end_time");
const period = currentParams.get("period");
if ((startTime && endTime) || period) {
const params = new URLSearchParams();
if (startTime) params.set("start_time", startTime);
if (endTime) params.set("end_time", endTime);
if (period) params.set("period", period);
const sep = baseHref.includes("?") ? "&" : "?";
return `${baseHref}${sep}${params.toString()}`;
}
}
return baseHref;
})();
const subItemHref = preserveTimeFilters(baseHref, subItem.url, pathname, search);
// For query param based subitems, check if tab matches
const isSubItemActive = subItem.queryParam
? pathname === subItem.url
Expand Down
Loading