Skip to content

fix: clear governanceRejectedContextKey on decision allow of governance req so that fallbacks account for budgets/rate limits #3645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akshaydeo merged 1 commit into from
May 21, 2026
Merged

fix: clear governanceRejectedContextKey on decision allow of governance req so that fallbacks account for budgets/rate limits #3645

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions plugins/governance/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1313,6 +1313,13 @@ func (p *GovernancePlugin) EvaluateGovernanceRequest(ctx *schemas.BifrostContext
// Handle decision
switch result.Decision {
case DecisionAllow:
// Clear any prior rejection flag (e.g. from a failed primary attempt
// before a fallback retry). Without this, PostLLMHook would see the
// stale flag and skip budget/rate-limit ID collection for the
// successful fallback attempt.
if ctx != nil {
ctx.ClearValue(governanceRejectedContextKey)
}
return result, nil
Comment thread
greptile-apps[bot] marked this conversation as resolved.
Comment thread
danpiths marked this conversation as resolved.

case DecisionVirtualKeyNotFound, DecisionVirtualKeyBlocked, DecisionModelBlocked, DecisionProviderBlocked:
Expand Down
Loading