Skip to content

feat: add limit and query params to filter data endpoints for server-side search and pagination #3567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akshaydeo merged 1 commit into from
May 18, 2026
Merged

feat: add limit and query params to filter data endpoints for server-side search and pagination #3567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 18 additions & 18 deletions framework/logstore/hybrid.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -594,28 +594,28 @@ func (h *HybridLogStore) IsLogEntryPresent(ctx context.Context, id string) (bool
return h.inner.IsLogEntryPresent(ctx, id)
}

func (h *HybridLogStore) GetDistinctAliases(ctx context.Context) ([]string, error) {
return h.inner.GetDistinctAliases(ctx)
func (h *HybridLogStore) GetDistinctAliases(ctx context.Context, limit int, query string) ([]string, error) {
return h.inner.GetDistinctAliases(ctx, limit, query)
}

func (h *HybridLogStore) GetDistinctModels(ctx context.Context) ([]string, error) {
return h.inner.GetDistinctModels(ctx)
func (h *HybridLogStore) GetDistinctModels(ctx context.Context, limit int, query string) ([]string, error) {
return h.inner.GetDistinctModels(ctx, limit, query)
}

func (h *HybridLogStore) GetDistinctKeyPairs(ctx context.Context, idCol, nameCol string) ([]KeyPairResult, error) {
return h.inner.GetDistinctKeyPairs(ctx, idCol, nameCol)
func (h *HybridLogStore) GetDistinctKeyPairs(ctx context.Context, idCol, nameCol string, limit int, query string) ([]KeyPairResult, error) {
return h.inner.GetDistinctKeyPairs(ctx, idCol, nameCol, limit, query)
}

func (h *HybridLogStore) GetDistinctRoutingEngines(ctx context.Context) ([]string, error) {
return h.inner.GetDistinctRoutingEngines(ctx)
func (h *HybridLogStore) GetDistinctRoutingEngines(ctx context.Context, limit int, query string) ([]string, error) {
return h.inner.GetDistinctRoutingEngines(ctx, limit, query)
}

func (h *HybridLogStore) GetDistinctStopReasons(ctx context.Context) ([]string, error) {
return h.inner.GetDistinctStopReasons(ctx)
func (h *HybridLogStore) GetDistinctStopReasons(ctx context.Context, limit int, query string) ([]string, error) {
return h.inner.GetDistinctStopReasons(ctx, limit, query)
}

func (h *HybridLogStore) GetDistinctMetadataKeys(ctx context.Context) (map[string][]string, error) {
return h.inner.GetDistinctMetadataKeys(ctx)
func (h *HybridLogStore) GetDistinctMetadataKeys(ctx context.Context, limit int, query string) (map[string][]string, error) {
return h.inner.GetDistinctMetadataKeys(ctx, limit, query)
}

// MCP Tool Log analytics methods are delegated directly. Detail/write paths
Expand Down Expand Up @@ -1020,16 +1020,16 @@ func (h *HybridLogStore) FlushMCPToolLogs(ctx context.Context, since time.Time)
return h.inner.FlushMCPToolLogs(ctx, since)
}

func (h *HybridLogStore) GetAvailableToolNames(ctx context.Context) ([]string, error) {
return h.inner.GetAvailableToolNames(ctx)
func (h *HybridLogStore) GetAvailableToolNames(ctx context.Context, limit int, query string) ([]string, error) {
return h.inner.GetAvailableToolNames(ctx, limit, query)
}

func (h *HybridLogStore) GetAvailableServerLabels(ctx context.Context) ([]string, error) {
return h.inner.GetAvailableServerLabels(ctx)
func (h *HybridLogStore) GetAvailableServerLabels(ctx context.Context, limit int, query string) ([]string, error) {
return h.inner.GetAvailableServerLabels(ctx, limit, query)
}

func (h *HybridLogStore) GetAvailableMCPVirtualKeys(ctx context.Context) ([]MCPToolLog, error) {
return h.inner.GetAvailableMCPVirtualKeys(ctx)
func (h *HybridLogStore) GetAvailableMCPVirtualKeys(ctx context.Context, limit int, query string) ([]MCPToolLog, error) {
return h.inner.GetAvailableMCPVirtualKeys(ctx, limit, query)
}

// Async Job methods — delegated directly.
Expand Down
59 changes: 38 additions & 21 deletions framework/logstore/matviews.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1623,36 +1623,45 @@ func (s *RDBLogStore) getUserRankingsFromMatView(ctx context.Context, filters Se
// getDistinctModelsFromMatView returns unique model names from mv_filter_models.
// Limit matches the raw-table fallback so callers see the same row cap regardless
// of which path served the request.
func (s *RDBLogStore) getDistinctModelsFromMatView(ctx context.Context) ([]string, error) {
func (s *RDBLogStore) getDistinctModelsFromMatView(ctx context.Context, limit int, query string) ([]string, error) {
var models []string
if err := s.db.WithContext(ctx).Table("mv_filter_models").
q := s.db.WithContext(ctx).Table("mv_filter_models").
Distinct("model").
Where("model != ''").
Pluck("model", &models).Error; err != nil {
Where("model != ''")
if query != "" {
q = q.Where("model ILIKE ?", "%"+query+"%")

@greptile-apps greptile-apps Bot May 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Unescaped LIKE wildcards in matview query paths

The same "%" + query + "%" pattern used throughout the matview methods (getDistinctModelsFromMatView, getDistinctAliasesFromMatView, getDistinctStopReasonsFromMatView, getDistinctKeyPairsFromMatView, getDistinctRoutingEnginesFromMatView) does not escape % or _ in the user-supplied query. A search for gpt_4 produces ILIKE '%gpt_4%' where _ is a single-character wildcard, returning false positives like gpt14. Since these paths are Postgres-only, using ESCAPE '\' with pre-escaped characters (matching the fix suggested for applyLikeFilter) would resolve the issue across all matview methods.

}
if err := q.Order("model ASC").Limit(limit).Pluck("model", &models).Error; err != nil {
return nil, err
}
return models, nil
}

// getDistinctAliasesFromMatView returns unique alias values from mv_filter_aliases.
func (s *RDBLogStore) getDistinctAliasesFromMatView(ctx context.Context) ([]string, error) {
func (s *RDBLogStore) getDistinctAliasesFromMatView(ctx context.Context, limit int, query string) ([]string, error) {
var aliases []string
if err := s.db.WithContext(ctx).Table("mv_filter_aliases").
q := s.db.WithContext(ctx).Table("mv_filter_aliases").
Distinct("alias").
Where("alias != ''").
Pluck("alias", &aliases).Error; err != nil {
Where("alias != ''")
if query != "" {
q = q.Where("alias ILIKE ?", "%"+query+"%")
}
if err := q.Order("alias ASC").Limit(limit).Pluck("alias", &aliases).Error; err != nil {
return nil, err
}
return aliases, nil
}

// getDistinctStopReasonsFromMatView returns unique stop reasons from mv_filter_stop_reasons.
func (s *RDBLogStore) getDistinctStopReasonsFromMatView(ctx context.Context) ([]string, error) {
func (s *RDBLogStore) getDistinctStopReasonsFromMatView(ctx context.Context, limit int, query string) ([]string, error) {
var stopReasons []string
if err := s.db.WithContext(ctx).Table("mv_filter_stop_reasons").
q := s.db.WithContext(ctx).Table("mv_filter_stop_reasons").
Distinct("stop_reason").
Where("stop_reason != ''").
Pluck("stop_reason", &stopReasons).Error; err != nil {
Where("stop_reason != ''")
if query != "" {
q = q.Where("stop_reason ILIKE ?", "%"+query+"%")
}
if err := q.Order("stop_reason ASC").Limit(limit).Pluck("stop_reason", &stopReasons).Error; err != nil {
return nil, err
}
return stopReasons, nil
Expand All @@ -1662,22 +1671,23 @@ func (s *RDBLogStore) getDistinctStopReasonsFromMatView(ctx context.Context) ([]
// (idCol, nameCol) by selecting from the per-dimension matview pre-aggregated
// for that pair. Returns (nil, false) if no matview is registered for the pair —
// callers fall back to the raw-table path.
func (s *RDBLogStore) getDistinctKeyPairsFromMatView(ctx context.Context, idCol, nameCol string) ([]KeyPairResult, bool, error) {
func (s *RDBLogStore) getDistinctKeyPairsFromMatView(ctx context.Context, idCol, nameCol string, limit int, query string) ([]KeyPairResult, bool, error) {
view, ok := filterMatViewKeyPairColumns[[2]string{idCol, nameCol}]
if !ok {
return nil, false, nil
}
var results []KeyPairResult
q := s.db.WithContext(ctx).Table(view).Where("id != ''")
// User matview stores name = id and the view-level WHERE already filters
// empty ids; other matviews include name and we additionally guard against
// stragglers with empty names.
if !(idCol == "user_id" && nameCol == "user_id") {
q = q.Where("name != ''")
}
if query != "" {
q = q.Where("name ILIKE ?", "%"+query+"%")
}
if err := q.
Select("DISTINCT id, name").
Order("name ASC").
Limit(limit).
Find(&results).Error; err != nil {
return nil, true, err
}
Expand All @@ -1687,12 +1697,15 @@ func (s *RDBLogStore) getDistinctKeyPairsFromMatView(ctx context.Context, idCol,
// getDistinctRoutingEnginesFromMatView returns unique routing engine names by
// parsing the comma-separated routing_engines_used values from
// mv_filter_routing_engines.
func (s *RDBLogStore) getDistinctRoutingEnginesFromMatView(ctx context.Context) ([]string, error) {
func (s *RDBLogStore) getDistinctRoutingEnginesFromMatView(ctx context.Context, limit int, query string) ([]string, error) {
var rawValues []string
if err := s.db.WithContext(ctx).Table("mv_filter_routing_engines").
q := s.db.WithContext(ctx).Table("mv_filter_routing_engines").
Distinct("routing_engines_used").
Where("routing_engines_used != ''").
Pluck("routing_engines_used", &rawValues).Error; err != nil {
Where("routing_engines_used != ''")
if query != "" {
q = q.Where("routing_engines_used ILIKE ?", "%"+query+"%")
}
if err := q.Pluck("routing_engines_used", &rawValues).Error; err != nil {
return nil, err
}
seen := make(map[string]struct{})
Expand All @@ -1704,7 +1717,11 @@ func (s *RDBLogStore) getDistinctRoutingEnginesFromMatView(ctx context.Context)
}
}
}
return sortedStringKeys(seen), nil
result := sortedStringKeys(seen)
if len(result) > limit {
result = result[:limit]
}
return result, nil
Comment thread
impoiler marked this conversation as resolved.
}

// ---------------------------------------------------------------------------
Expand Down
Loading
Loading