fixes alias in migration for team calendar aligned fixes - #3535
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis pull request makes two minor maintenance updates: adding E2E test artifact ignore rules to .gitignore for demo server directories, and refactoring database migration SQL to remove table alias usage while preserving the calendar alignment backfill logic for governance teams. ChangesConfiguration and Migration Updates
🎯 1 (Trivial) | ⏱️ ~3 minutes
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.12.2)level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies" Comment |
Merge activity
|
Confidence Score: 5/5Safe to merge — the SQL fix is correct and narrowly scoped to two backfill statements in a single migration. Both changed files are straightforward: the migration fix removes a bare table alias that broke the backfill on SQLite, and the .gitignore addition is harmless. The SQL rewrite is equivalent in semantics and works across all supported databases. No files require special attention. Important Files Changed
Reviews (1): Last reviewed commit: "fixes alias in migration for team calend..." | Re-trigger Greptile |
|
|
||
| # e2e test artifacts | ||
| examples/mcps/auth-demo-server/auth-demo-server | ||
| examples/mcps/oauth-demo-server/oauth-demo-server No newline at end of file |
There was a problem hiding this comment.
## Summary Fixes invalid SQL table alias usage in the `migrationAddTeamCalendarAlignedColumn` migration and adds build artifacts from e2e test demo servers to `.gitignore`. ## Changes - Removed table aliases (`t`) from `UPDATE` statements in the calendar-aligned backfill migration, replacing them with direct table name references. Some databases (e.g., PostgreSQL) do not support aliases in `UPDATE` statements in this form, which would cause the migration to fail. - Added compiled binaries for `auth-demo-server` and `oauth-demo-server` under `examples/mcps/` to `.gitignore` to prevent e2e test build artifacts from being accidentally committed. ## Type of change - [x] Bug fix - [ ] Feature - [ ] Refactor - [ ] Documentation - [ ] Chore/CI ## Affected areas - [x] Core (Go) - [ ] Transports (HTTP) - [ ] Providers/Integrations - [ ] Plugins - [ ] UI (React) - [ ] Docs ## How to test Run the migration against a fresh or existing database and verify it completes without error: ```sh go test ./framework/configstore/... ``` Confirm that building the e2e demo servers does not produce tracked files in git: ```sh cd examples/mcps/auth-demo-server && go build . cd examples/mcps/oauth-demo-server && go build . git status # binaries should not appear as untracked files ``` ## Screenshots/Recordings N/A ## Breaking changes - [ ] Yes - [x] No ## Related issues N/A ## Security considerations No security implications. The SQL fix removes table aliases that could cause migration failures; no auth, secrets, or PII are involved. ## Checklist - [ ] I read `docs/contributing/README.md` and followed the guidelines - [ ] I added/updated tests where appropriate - [ ] I updated documentation where needed - [ ] I verified builds succeed (Go and UI) - [ ] I verified the CI pipeline passes locally if applicable
## Summary Fixes invalid SQL table alias usage in the `migrationAddTeamCalendarAlignedColumn` migration and adds build artifacts from e2e test demo servers to `.gitignore`. ## Changes - Removed table aliases (`t`) from `UPDATE` statements in the calendar-aligned backfill migration, replacing them with direct table name references. Some databases (e.g., PostgreSQL) do not support aliases in `UPDATE` statements in this form, which would cause the migration to fail. - Added compiled binaries for `auth-demo-server` and `oauth-demo-server` under `examples/mcps/` to `.gitignore` to prevent e2e test build artifacts from being accidentally committed. ## Type of change - [x] Bug fix - [ ] Feature - [ ] Refactor - [ ] Documentation - [ ] Chore/CI ## Affected areas - [x] Core (Go) - [ ] Transports (HTTP) - [ ] Providers/Integrations - [ ] Plugins - [ ] UI (React) - [ ] Docs ## How to test Run the migration against a fresh or existing database and verify it completes without error: ```sh go test ./framework/configstore/... ``` Confirm that building the e2e demo servers does not produce tracked files in git: ```sh cd examples/mcps/auth-demo-server && go build . cd examples/mcps/oauth-demo-server && go build . git status # binaries should not appear as untracked files ``` ## Screenshots/Recordings N/A ## Breaking changes - [ ] Yes - [x] No ## Related issues N/A ## Security considerations No security implications. The SQL fix removes table aliases that could cause migration failures; no auth, secrets, or PII are involved. ## Checklist - [ ] I read `docs/contributing/README.md` and followed the guidelines - [ ] I added/updated tests where appropriate - [ ] I updated documentation where needed - [ ] I verified builds succeed (Go and UI) - [ ] I verified the CI pipeline passes locally if applicable

Summary
Fixes invalid SQL table alias usage in the
migrationAddTeamCalendarAlignedColumnmigration and adds build artifacts from e2e test demo servers to.gitignore.Changes
t) fromUPDATEstatements in the calendar-aligned backfill migration, replacing them with direct table name references. Some databases (e.g., PostgreSQL) do not support aliases inUPDATEstatements in this form, which would cause the migration to fail.auth-demo-serverandoauth-demo-serverunderexamples/mcps/to.gitignoreto prevent e2e test build artifacts from being accidentally committed.Type of change
Affected areas
How to test
Run the migration against a fresh or existing database and verify it completes without error:
go test ./framework/configstore/...Confirm that building the e2e demo servers does not produce tracked files in git:
Screenshots/Recordings
N/A
Breaking changes
Related issues
N/A
Security considerations
No security implications. The SQL fix removes table aliases that could cause migration failures; no auth, secrets, or PII are involved.
Checklist
docs/contributing/README.mdand followed the guidelines