Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions core/changelog.md
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
[fix]: openai provider - add usage to completed event in responses to chat completions fallback [@kevinpdev](https://github.com/kevinpdev)
[feat]: use chat completions for openai custom providers that disable responses [@kevinpdev](https://github.com/kevinpdev)
54 changes: 45 additions & 9 deletions core/providers/openai/openai.go
Original file line number Diff line number Diff line change
Expand Up @@ -1119,6 +1119,9 @@ func HandleOpenAIChatCompletionStreaming(
var modelName string
var created int
forwardedTerminalFinishReason := false
// Defer final completed/incomplete event until usage chunk arrives (fallback path only).
var pendingFinalEvent *schemas.BifrostResponsesStreamResponse
usageSeen := false

for {
// If context was cancelled/timed out, let defer handle it
Expand Down Expand Up @@ -1181,6 +1184,32 @@ func HandleOpenAIChatCompletionStreaming(
}

if isResponsesToChatCompletionsFallback {
// Accumulate usage across chunks; attached to final event below.
if response.Usage != nil {
usageSeen = true
if response.Usage.PromptTokens > usage.PromptTokens {
usage.PromptTokens = response.Usage.PromptTokens
}
if response.Usage.CompletionTokens > usage.CompletionTokens {
usage.CompletionTokens = response.Usage.CompletionTokens
}
if response.Usage.TotalTokens > usage.TotalTokens {
usage.TotalTokens = response.Usage.TotalTokens
}
if calculatedTotal := usage.PromptTokens + usage.CompletionTokens; calculatedTotal > usage.TotalTokens {
usage.TotalTokens = calculatedTotal
}
if response.Usage.PromptTokensDetails != nil {
usage.PromptTokensDetails = response.Usage.PromptTokensDetails
}
if response.Usage.CompletionTokensDetails != nil {
usage.CompletionTokensDetails = response.Usage.CompletionTokensDetails
}
if response.Usage.Cost != nil {
usage.Cost = response.Usage.Cost
}
}

spreadResponses := response.ToBifrostResponsesStreamResponse(responsesStreamState)
for _, response := range spreadResponses {
if response.Type == schemas.ResponsesStreamResponseTypeError {
Expand Down Expand Up @@ -1212,14 +1241,9 @@ func HandleOpenAIChatCompletionStreaming(
}

if response.Type == schemas.ResponsesStreamResponseTypeCompleted || response.Type == schemas.ResponsesStreamResponseTypeIncomplete {
// Set raw request if enabled
if sendBackRawRequest {
providerUtils.ParseAndSetRawRequest(&response.ExtraFields, jsonBody)
}
response.ExtraFields.Latency = time.Since(startTime).Milliseconds()
ctx.SetValue(schemas.BifrostContextKeyStreamEndIndicator, true)
providerUtils.ProcessAndSendResponse(ctx, postHookRunner, providerUtils.GetBifrostResponseForStreamResponse(nil, nil, response, nil, nil, nil), responseChan, postHookSpanFinalizer)
return
// Defer sending until stream end so usage can be attached.
pendingFinalEvent = response
continue
}

response.ExtraFields.Latency = time.Since(lastChunkTime).Milliseconds()
Expand Down Expand Up @@ -1321,7 +1345,19 @@ func HandleOpenAIChatCompletionStreaming(
}
}

if !isResponsesToChatCompletionsFallback {
if isResponsesToChatCompletionsFallback {
if pendingFinalEvent != nil {
if usageSeen && pendingFinalEvent.Response != nil {
pendingFinalEvent.Response.Usage = usage.ToResponsesResponseUsage()
}
if sendBackRawRequest {
providerUtils.ParseAndSetRawRequest(&pendingFinalEvent.ExtraFields, jsonBody)
}
pendingFinalEvent.ExtraFields.Latency = time.Since(startTime).Milliseconds()
ctx.SetValue(schemas.BifrostContextKeyStreamEndIndicator, true)
providerUtils.ProcessAndSendResponse(ctx, postHookRunner, providerUtils.GetBifrostResponseForStreamResponse(nil, nil, pendingFinalEvent, nil, nil, nil), responseChan, postHookSpanFinalizer)
}
} else {
finalFinishReason := finishReason
if forwardedTerminalFinishReason {
finalFinishReason = nil
Expand Down