Skip to content

[fix]: add missing padding to provider api structure form - #3513

Merged
akshaydeo merged 1 commit into
maximhq:devfrom
stackblitz:delm/fix/ui/custom-provider-api-structure
May 15, 2026
Merged

[fix]: add missing padding to provider api structure form#3513
akshaydeo merged 1 commit into
maximhq:devfrom
stackblitz:delm/fix/ui/custom-provider-api-structure

Conversation

@d3lm

@d3lm d3lm commented May 14, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes the custom provider API Structure form layout so the form content has the same horizontal and bottom spacing as the surrounding provider configuration UI. This prevents the form controls from sitting flush against the sheet edges.

Also ignores local .tool-versions files so developer runtime metadata does not get committed accidentally.

Changes

  • Restored padding on the provider API Structure form by replacing p-0 with px-6 pb-6.
  • Added .tool-versions to .gitignore to keep local toolchain version files out of the repository.
  • Kept the change scoped to presentation and local development metadata; no API, schema, or data model behavior changed.

Type of change

  • Bug fix
  • Feature
  • Refactor
  • Documentation
  • Chore/CI

Affected areas

  • Core (Go)
  • Transports (HTTP)
  • Providers/Integrations
  • Plugins
  • UI (React)
  • Docs

How to test

Validate manually in the UI:

  1. Open the workspace Providers page.
  2. Open a custom provider configuration.
  3. Navigate to the API Structure configuration form.
  4. Confirm the form content is padded consistently with the sheet and is not flush against the left, right, or bottom edges.

Optional verification:

cd ui
pnpm build || npm run build

Expected outcome: the UI build succeeds and the API Structure form spacing matches the rest of the provider configuration UI.

No new configs or environment variables were added.

Screenshots/Recordings

Before:

image

After:

image

Breaking changes

  • Yes
  • No

Related issues

None linked.

Security considerations

No auth, secrets, PII, or sandboxing behavior is affected. Adding .tool-versions to .gitignore reduces the chance of committing local environment metadata.

Checklist

  • I read docs/contributing/README.md and followed the guidelines
  • I added/updated tests where appropriate
  • I updated documentation where needed
  • I verified builds succeed (Go and UI)
  • I verified the CI pipeline passes locally if applicable

@coderabbitai

coderabbitai Bot commented May 14, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6bfd883f-2a66-47b2-8e5a-790aed8afcd7

📥 Commits

Reviewing files that changed from the base of the PR and between 99a2954 and 04b8174.

📒 Files selected for processing (3)
  • .gitignore
  • transports/changelog.md
  • ui/app/workspace/providers/fragments/apiStructureFormFragment.tsx
✅ Files skipped from review due to trivial changes (3)
  • transports/changelog.md
  • .gitignore
  • ui/app/workspace/providers/fragments/apiStructureFormFragment.tsx

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes

    • Restored missing padding in the provider API structure form for improved visual spacing and layout.
  • Chores

    • Updated project configuration to ignore local tool version files.

Walkthrough

Adds .tool-versions to .gitignore, changes the root <form> in ApiStructureFormFragment from space-y-6 p-0 to space-y-6 px-6 pb-6 (styling only), and adds a [fix] changelog entry documenting the padding fix.

Changes

Configuration and UI styling refinements

Layer / File(s) Summary
Ignore local tool versions
.gitignore
Add .tool-versions to the git ignore list so local tool/version manager files are not committed.
Form padding adjustment
ui/app/workspace/providers/fragments/apiStructureFormFragment.tsx
Change root <form> className from space-y-6 p-0 to space-y-6 px-6 pb-6 — purely a presentational/layout change.
Changelog entry
transports/changelog.md
Add a [fix] entry noting the provider API structure form padding fix and crediting @delm.

🎯 1 (Trivial) | ⏱️ ~2 minutes

I nibble lines with careful paws,
I hide the versions from the clause,
I pad the form so fields can rest,
A tiny hop to make it best,
This rabbit leaves a tidy, gentle patch. 🐇

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: fixing missing padding in the provider API structure form, which is the primary focus of the changeset.
Description check ✅ Passed The description covers all key template sections including summary, changes, type of change, affected areas, testing instructions, screenshots, breaking changes, and security considerations.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@greptile-apps

greptile-apps Bot commented May 14, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 5/5

Safe to merge — the change touches only a Tailwind class on a single form element and a gitignore entry, with no logic or data-model impact.

The form class swap from p-0 to px-6 pb-6 is a pure presentational fix with no state, API, or behavioral side effects. The .gitignore addition is additive and safe.

No files require special attention.

Important Files Changed

Filename Overview
ui/app/workspace/providers/fragments/apiStructureFormFragment.tsx Replaces p-0 with px-6 pb-6 on the form element to restore horizontal and bottom padding matching surrounding UI; no logic changes.
.gitignore Adds .tool-versions to prevent local toolchain version files from being accidentally committed.
transports/changelog.md Adds a changelog entry for this padding fix; no functional changes.

Reviews (5): Last reviewed commit: "[fix]: add missing padding to provider a..." | Re-trigger Greptile

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@ui/app/workspace/providers/fragments/apiStructureFormFragment.tsx`:
- Line 99: The build is failing due to missing dev dependencies referenced by
the Vite config (packages: `@tailwindcss/vite`, `@tanstack/router-plugin/vite`,
`@vitejs/plugin-react`, vite, vite-plugin-checker); add these to the ui
package.json devDependencies (or run npm install --save-dev for each) so imports
in vite.config.mts resolve, run npm install in the ui directory to fetch them,
and verify the build completes with cd ui && npm run build (also confirm the
vite.config.mts imports match the installed package names).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 240aca95-73a5-441f-86de-212299b5cef1

📥 Commits

Reviewing files that changed from the base of the PR and between 4ab50b2 and 85c5c26.

📒 Files selected for processing (2)
  • .gitignore
  • ui/app/workspace/providers/fragments/apiStructureFormFragment.tsx

Comment thread ui/app/workspace/providers/fragments/apiStructureFormFragment.tsx
@d3lm d3lm changed the title fix: add adding to provider api structure form fix: add padding to provider api structure form May 14, 2026
@d3lm d3lm changed the title fix: add padding to provider api structure form fix: add missing padding to provider api structure form May 14, 2026
@d3lm
d3lm force-pushed the delm/fix/ui/custom-provider-api-structure branch from 85c5c26 to e83fae5 Compare May 14, 2026 20:24
coderabbitai[bot]
coderabbitai Bot previously approved these changes May 14, 2026
@akshaydeo
akshaydeo dismissed coderabbitai[bot]’s stale review May 15, 2026 05:59

The merge-base changed after approval.

@akshaydeo
akshaydeo requested a review from a team as a code owner May 15, 2026 05:59
@d3lm
d3lm force-pushed the delm/fix/ui/custom-provider-api-structure branch from e83fae5 to 624583e Compare May 15, 2026 06:59
coderabbitai[bot]
coderabbitai Bot previously approved these changes May 15, 2026
@d3lm d3lm changed the title fix: add missing padding to provider api structure form [fix]: add missing padding to provider api structure form May 15, 2026
@d3lm
d3lm force-pushed the delm/fix/ui/custom-provider-api-structure branch from 624583e to 99a2954 Compare May 15, 2026 07:25
@d3lm

d3lm commented May 15, 2026

Copy link
Copy Markdown
Contributor Author

@akshaydeo Any chance someone could review this PR?

@d3lm
d3lm force-pushed the delm/fix/ui/custom-provider-api-structure branch from 99a2954 to 04b8174 Compare May 15, 2026 17:23
@akshaydeo
akshaydeo merged commit 4f33dd8 into maximhq:dev May 15, 2026
4 checks passed
@d3lm
d3lm deleted the delm/fix/ui/custom-provider-api-structure branch May 15, 2026 17:31
@d3lm

d3lm commented May 15, 2026

Copy link
Copy Markdown
Contributor Author

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants