Skip to content

fix: constrain provider keys table column widths and truncate long key names - #3482

Merged
akshaydeo merged 3 commits into
devfrom
05-14-fix_workspace_providers_table_layout_shift
May 14, 2026
Merged

akshaydeo merged 3 commits into
devfrom
05-14-fix_workspace_providers_table_layout_shift

Conversation

@impoiler

@impoiler impoiler commented May 14, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes layout issues in the model provider keys table where long key/model/server names would overflow their cells and cause the table to render incorrectly.

Changes

  • Applied table-fixed layout to the keys table and defined explicit column widths via <colgroup> (64% for the name column, 12% each for the remaining three columns) to enforce stable column sizing regardless of content length
  • Added overflow-hidden to the name cell and min-w-0 + truncate to the name text span so long strings are clipped with an ellipsis instead of breaking the layout
  • Added a trailing newline at end of file

Type of change

  • Bug fix
  • Feature
  • Refactor
  • Documentation
  • Chore/CI

Affected areas

  • Core (Go)
  • Transports (HTTP)
  • Providers/Integrations
  • Plugins
  • UI (React)
  • Docs

How to test

  1. Navigate to the Workspace → Providers page and open a provider that has keys with long names (e.g. a vLLM model name or a long API key label).
  2. Verify that the name column truncates with an ellipsis rather than overflowing into adjacent columns.
  3. Verify that the three action columns (weight, status, actions) maintain consistent widths.
cd ui
pnpm i || npm i
pnpm test || npm test
pnpm build || npm run build

Screenshots/Recordings

Add before/after screenshots showing the table with a long key name to confirm truncation behavior.

Breaking changes

  • Yes
  • No

Related issues

Security considerations

None.

Checklist

  • I read docs/contributing/README.md and followed the guidelines
  • I added/updated tests where appropriate
  • I updated documentation where needed
  • I verified builds succeed (Go and UI)
  • I verified the CI pipeline passes locally if applicable

@coderabbitai

coderabbitai Bot commented May 14, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: bbbe7a7e-a3b3-4ddc-9b4d-3d85bf1e58f9

📥 Commits

Reviewing files that changed from the base of the PR and between ebd2d9f and 8ef4b61.

📒 Files selected for processing (1)
  • ui/app/workspace/providers/views/modelProviderKeysTableView.tsx

📝 Walkthrough

Summary by CodeRabbit

  • Style
    • Improved provider keys table layout with enhanced column width management and text truncation for better key name display.

Walkthrough

ModelProviderKeysTableView shifts the table to a fixed layout mode with explicit column widths defined via <colgroup>, applies overflow clipping and flex constraints to the key-name cell, and adds text truncation styling to ensure long key names display cleanly within the table bounds.

Changes

Table Layout and Truncation

Layer / File(s) Summary
Table layout, overflow handling, and text truncation
ui/app/workspace/providers/views/modelProviderKeysTableView.tsx
Table is changed to fixed layout with explicit colgroup column widths, the first data cell applies overflow-hidden and min-w-0 for proper truncation support, the key name span text is truncated with the truncate class, and end-of-file formatting is adjusted.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A table needs space, so we carved it with care,
Fixed widths, truncations, no overflow there!
Long names now bow with a graceful ellipse,
The view stays pristine, no text goes adrift.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: constraining table column widths and truncating long key names in the provider keys table.
Description check ✅ Passed The description includes all required sections: summary, changes, type of change, affected areas, how to test, breaking changes, and security considerations. The description is comprehensive and directly addresses the pull request objectives.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 05-14-fix_workspace_providers_table_layout_shift

Comment @coderabbitai help to get the list of available commands and usage tips.

@greptile-apps

greptile-apps Bot commented May 14, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 5/5

Purely a CSS/layout fix scoped to a single UI component; no logic, data, or API changes.

The change is minimal and correct: table-fixed + colgroup widths that sum to 100%, min-w-0 on the flex container to allow shrinking, and truncate on the text span — all standard practice for this pattern. No logic paths are affected.

No files require special attention.

Important Files Changed

Filename Overview
ui/app/workspace/providers/views/modelProviderKeysTableView.tsx Adds table-fixed layout with colgroup widths and truncation classes to prevent long key/model/server names from overflowing the table; also fixes missing trailing newline.

Reviews (2): Last reviewed commit: "fix: workspace/providers table layout sh..." | Re-trigger Greptile

@impoiler
impoiler force-pushed the 05-14-fix_workspace_model-catalog_table_layout_shifts branch from 2902baa to ebd2d9f Compare May 14, 2026 10:12
@impoiler
impoiler force-pushed the 05-14-fix_workspace_providers_table_layout_shift branch from 9b9032e to 8ef4b61 Compare May 14, 2026 10:12
coderabbitai[bot]
coderabbitai Bot previously approved these changes May 14, 2026
@impoiler impoiler mentioned this pull request May 14, 2026
18 tasks

akshaydeo commented May 14, 2026

Copy link
Copy Markdown
Contributor

Merge activity

  • May 14, 10:19 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • May 14, 10:21 AM UTC: @akshaydeo merged this pull request with Graphite.

@akshaydeo
akshaydeo changed the base branch from 05-14-fix_workspace_model-catalog_table_layout_shifts to graphite-base/3482 May 14, 2026 10:20
@akshaydeo
akshaydeo changed the base branch from graphite-base/3482 to dev May 14, 2026 10:20
@akshaydeo
akshaydeo dismissed coderabbitai[bot]’s stale review May 14, 2026 10:20

The base branch was changed.

@akshaydeo
akshaydeo merged commit b905d28 into dev May 14, 2026
13 checks passed
@akshaydeo
akshaydeo deleted the 05-14-fix_workspace_providers_table_layout_shift branch May 14, 2026 10:21
akshaydeo pushed a commit that referenced this pull request May 14, 2026
…y names (#3482)

## Summary

Fixes layout issues in the model provider keys table where long key/model/server names would overflow their cells and cause the table to render incorrectly.

## Changes

- Applied `table-fixed` layout to the keys table and defined explicit column widths via `<colgroup>` (64% for the name column, 12% each for the remaining three columns) to enforce stable column sizing regardless of content length
- Added `overflow-hidden` to the name cell and `min-w-0` + `truncate` to the name text span so long strings are clipped with an ellipsis instead of breaking the layout
- Added a trailing newline at end of file

## Type of change

- [x] Bug fix
- [ ] Feature
- [ ] Refactor
- [ ] Documentation
- [ ] Chore/CI

## Affected areas

- [ ] Core (Go)
- [ ] Transports (HTTP)
- [ ] Providers/Integrations
- [ ] Plugins
- [x] UI (React)
- [ ] Docs

## How to test

1. Navigate to the Workspace → Providers page and open a provider that has keys with long names (e.g. a vLLM model name or a long API key label).
2. Verify that the name column truncates with an ellipsis rather than overflowing into adjacent columns.
3. Verify that the three action columns (weight, status, actions) maintain consistent widths.

```sh
cd ui
pnpm i || npm i
pnpm test || npm test
pnpm build || npm run build
```

## Screenshots/Recordings

Add before/after screenshots showing the table with a long key name to confirm truncation behavior.

## Breaking changes

- [ ] Yes
- [x] No

## Related issues

## Security considerations

None.

## Checklist

- [ ] I read `docs/contributing/README.md` and followed the guidelines
- [ ] I added/updated tests where appropriate
- [ ] I updated documentation where needed
- [ ] I verified builds succeed (Go and UI)
- [ ] I verified the CI pipeline passes locally if applicable
akshaydeo pushed a commit that referenced this pull request May 15, 2026
…y names (#3482)

## Summary

Fixes layout issues in the model provider keys table where long key/model/server names would overflow their cells and cause the table to render incorrectly.

## Changes

- Applied `table-fixed` layout to the keys table and defined explicit column widths via `<colgroup>` (64% for the name column, 12% each for the remaining three columns) to enforce stable column sizing regardless of content length
- Added `overflow-hidden` to the name cell and `min-w-0` + `truncate` to the name text span so long strings are clipped with an ellipsis instead of breaking the layout
- Added a trailing newline at end of file

## Type of change

- [x] Bug fix
- [ ] Feature
- [ ] Refactor
- [ ] Documentation
- [ ] Chore/CI

## Affected areas

- [ ] Core (Go)
- [ ] Transports (HTTP)
- [ ] Providers/Integrations
- [ ] Plugins
- [x] UI (React)
- [ ] Docs

## How to test

1. Navigate to the Workspace → Providers page and open a provider that has keys with long names (e.g. a vLLM model name or a long API key label).
2. Verify that the name column truncates with an ellipsis rather than overflowing into adjacent columns.
3. Verify that the three action columns (weight, status, actions) maintain consistent widths.

```sh
cd ui
pnpm i || npm i
pnpm test || npm test
pnpm build || npm run build
```

## Screenshots/Recordings

Add before/after screenshots showing the table with a long key name to confirm truncation behavior.

## Breaking changes

- [ ] Yes
- [x] No

## Related issues

## Security considerations

None.

## Checklist

- [ ] I read `docs/contributing/README.md` and followed the guidelines
- [ ] I added/updated tests where appropriate
- [ ] I updated documentation where needed
- [ ] I verified builds succeed (Go and UI)
- [ ] I verified the CI pipeline passes locally if applicable
akshaydeo pushed a commit that referenced this pull request May 15, 2026
…y names (#3482)

## Summary

Fixes layout issues in the model provider keys table where long key/model/server names would overflow their cells and cause the table to render incorrectly.

## Changes

- Applied `table-fixed` layout to the keys table and defined explicit column widths via `<colgroup>` (64% for the name column, 12% each for the remaining three columns) to enforce stable column sizing regardless of content length
- Added `overflow-hidden` to the name cell and `min-w-0` + `truncate` to the name text span so long strings are clipped with an ellipsis instead of breaking the layout
- Added a trailing newline at end of file

## Type of change

- [x] Bug fix
- [ ] Feature
- [ ] Refactor
- [ ] Documentation
- [ ] Chore/CI

## Affected areas

- [ ] Core (Go)
- [ ] Transports (HTTP)
- [ ] Providers/Integrations
- [ ] Plugins
- [x] UI (React)
- [ ] Docs

## How to test

1. Navigate to the Workspace → Providers page and open a provider that has keys with long names (e.g. a vLLM model name or a long API key label).
2. Verify that the name column truncates with an ellipsis rather than overflowing into adjacent columns.
3. Verify that the three action columns (weight, status, actions) maintain consistent widths.

```sh
cd ui
pnpm i || npm i
pnpm test || npm test
pnpm build || npm run build
```

## Screenshots/Recordings

Add before/after screenshots showing the table with a long key name to confirm truncation behavior.

## Breaking changes

- [ ] Yes
- [x] No

## Related issues

## Security considerations

None.

## Checklist

- [ ] I read `docs/contributing/README.md` and followed the guidelines
- [ ] I added/updated tests where appropriate
- [ ] I updated documentation where needed
- [ ] I verified builds succeed (Go and UI)
- [ ] I verified the CI pipeline passes locally if applicable
akshaydeo pushed a commit that referenced this pull request May 20, 2026
…y names (#3482)

## Summary

Fixes layout issues in the model provider keys table where long key/model/server names would overflow their cells and cause the table to render incorrectly.

## Changes

- Applied `table-fixed` layout to the keys table and defined explicit column widths via `<colgroup>` (64% for the name column, 12% each for the remaining three columns) to enforce stable column sizing regardless of content length
- Added `overflow-hidden` to the name cell and `min-w-0` + `truncate` to the name text span so long strings are clipped with an ellipsis instead of breaking the layout
- Added a trailing newline at end of file

## Type of change

- [x] Bug fix
- [ ] Feature
- [ ] Refactor
- [ ] Documentation
- [ ] Chore/CI

## Affected areas

- [ ] Core (Go)
- [ ] Transports (HTTP)
- [ ] Providers/Integrations
- [ ] Plugins
- [x] UI (React)
- [ ] Docs

## How to test

1. Navigate to the Workspace → Providers page and open a provider that has keys with long names (e.g. a vLLM model name or a long API key label).
2. Verify that the name column truncates with an ellipsis rather than overflowing into adjacent columns.
3. Verify that the three action columns (weight, status, actions) maintain consistent widths.

```sh
cd ui
pnpm i || npm i
pnpm test || npm test
pnpm build || npm run build
```

## Screenshots/Recordings

Add before/after screenshots showing the table with a long key name to confirm truncation behavior.

## Breaking changes

- [ ] Yes
- [x] No

## Related issues

## Security considerations

None.

## Checklist

- [ ] I read `docs/contributing/README.md` and followed the guidelines
- [ ] I added/updated tests where appropriate
- [ ] I updated documentation where needed
- [ ] I verified builds succeed (Go and UI)
- [ ] I verified the CI pipeline passes locally if applicable
@akshaydeo akshaydeo mentioned this pull request May 20, 2026
akhsaul pushed a commit to akhsaul/bifrost that referenced this pull request Aug 27, 2026
…y names (maximhq#3482)

## Summary

Fixes layout issues in the model provider keys table where long key/model/server names would overflow their cells and cause the table to render incorrectly.

## Changes

- Applied `table-fixed` layout to the keys table and defined explicit column widths via `<colgroup>` (64% for the name column, 12% each for the remaining three columns) to enforce stable column sizing regardless of content length
- Added `overflow-hidden` to the name cell and `min-w-0` + `truncate` to the name text span so long strings are clipped with an ellipsis instead of breaking the layout
- Added a trailing newline at end of file

## Type of change

- [x] Bug fix
- [ ] Feature
- [ ] Refactor
- [ ] Documentation
- [ ] Chore/CI

## Affected areas

- [ ] Core (Go)
- [ ] Transports (HTTP)
- [ ] Providers/Integrations
- [ ] Plugins
- [x] UI (React)
- [ ] Docs

## How to test

1. Navigate to the Workspace → Providers page and open a provider that has keys with long names (e.g. a vLLM model name or a long API key label).
2. Verify that the name column truncates with an ellipsis rather than overflowing into adjacent columns.
3. Verify that the three action columns (weight, status, actions) maintain consistent widths.

```sh
cd ui
pnpm i || npm i
pnpm test || npm test
pnpm build || npm run build
```

## Screenshots/Recordings

Add before/after screenshots showing the table with a long key name to confirm truncation behavior.

## Breaking changes

- [ ] Yes
- [x] No

## Related issues

## Security considerations

None.

## Checklist

- [ ] I read `docs/contributing/README.md` and followed the guidelines
- [ ] I added/updated tests where appropriate
- [ ] I updated documentation where needed
- [ ] I verified builds succeed (Go and UI)
- [ ] I verified the CI pipeline passes locally if applicable
occcat pushed a commit to occcat/bifrost that referenced this pull request Sep 2, 2026
…y names (maximhq#3482)

## Summary

Fixes layout issues in the model provider keys table where long key/model/server names would overflow their cells and cause the table to render incorrectly.

## Changes

- Applied `table-fixed` layout to the keys table and defined explicit column widths via `<colgroup>` (64% for the name column, 12% each for the remaining three columns) to enforce stable column sizing regardless of content length
- Added `overflow-hidden` to the name cell and `min-w-0` + `truncate` to the name text span so long strings are clipped with an ellipsis instead of breaking the layout
- Added a trailing newline at end of file

## Type of change

- [x] Bug fix
- [ ] Feature
- [ ] Refactor
- [ ] Documentation
- [ ] Chore/CI

## Affected areas

- [ ] Core (Go)
- [ ] Transports (HTTP)
- [ ] Providers/Integrations
- [ ] Plugins
- [x] UI (React)
- [ ] Docs

## How to test

1. Navigate to the Workspace → Providers page and open a provider that has keys with long names (e.g. a vLLM model name or a long API key label).
2. Verify that the name column truncates with an ellipsis rather than overflowing into adjacent columns.
3. Verify that the three action columns (weight, status, actions) maintain consistent widths.

```sh
cd ui
pnpm i || npm i
pnpm test || npm test
pnpm build || npm run build
```

## Screenshots/Recordings

Add before/after screenshots showing the table with a long key name to confirm truncation behavior.

## Breaking changes

- [ ] Yes
- [x] No

## Related issues

## Security considerations

None.

## Checklist

- [ ] I read `docs/contributing/README.md` and followed the guidelines
- [ ] I added/updated tests where appropriate
- [ ] I updated documentation where needed
- [ ] I verified builds succeed (Go and UI)
- [ ] I verified the CI pipeline passes locally if applicable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants