Skip to content

fixes migration-test-script - #3472

Merged
akshaydeo merged 1 commit into
mainfrom
05-13-fixes_migration-test-script
May 13, 2026
Merged

fixes migration-test-script#3472
akshaydeo merged 1 commit into
mainfrom
05-13-fixes_migration-test-script

Conversation

@akshaydeo

@akshaydeo akshaydeo commented May 13, 2026

Copy link
Copy Markdown
Contributor

Summary

The git fetch --tags command in the migration test script was commented out, preventing the script from pulling available tags needed to determine which versions to test. This re-enables the command so migration tests can correctly resolve previous versions.

Changes

  • Re-enabled git fetch --tags in run-migration-tests.sh, which was previously commented out, restoring the ability to fetch remote tags before running migration version comparisons.

Type of change

  • Bug fix
  • Feature
  • Refactor
  • Documentation
  • Chore/CI

Affected areas

  • Core (Go)
  • Transports (HTTP)
  • Providers/Integrations
  • Plugins
  • UI (React)
  • Docs

How to test

Run the migration test script in a repository with remote tags and verify it correctly identifies and tests the expected number of previous versions.

bash .github/workflows/scripts/run-migration-tests.sh

Breaking changes

  • Yes
  • No

Related issues

Security considerations

No security implications. This change only affects CI tag resolution behavior.

Checklist

  • I read docs/contributing/README.md and followed the guidelines
  • I added/updated tests where appropriate
  • I updated documentation where needed
  • I verified builds succeed (Go and UI)
  • I verified the CI pipeline passes locally if applicable

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@akshaydeo
akshaydeo marked this pull request as ready for review May 13, 2026 14:49

akshaydeo commented May 13, 2026

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@akshaydeo
akshaydeo requested a review from a team as a code owner May 13, 2026 14:49

akshaydeo commented May 13, 2026

Copy link
Copy Markdown
Contributor Author

Merge activity

  • May 13, 2:50 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • May 13, 2:50 PM UTC: @akshaydeo merged this pull request with Graphite.

@github-actions

Copy link
Copy Markdown
Contributor

🧪 Test Suite Available

This PR can be tested by a repository admin.

Run tests for PR #3472

@akshaydeo
akshaydeo merged commit bd45be1 into main May 13, 2026
14 of 16 checks passed
@akshaydeo
akshaydeo deleted the 05-13-fixes_migration-test-script branch May 13, 2026 14:50
@greptile-apps

greptile-apps Bot commented May 13, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 5/5

Single-line script fix that re-enables a previously disabled git fetch --tags call; no logic changes, no new dependencies.

The change is a one-character diff (removes the leading #), restoring a git fetch --tags call that is essential for the version-discovery loop to work correctly in CI shallow clones. The fix is correct and low-risk.

No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/scripts/run-migration-tests.sh Uncomments git fetch --tags so the script can resolve previous release tags in CI environments where the checkout is shallow or tags are absent.

Reviews (1): Last reviewed commit: "fixes migration-test-script" | Re-trigger Greptile

@coderabbitai

coderabbitai Bot commented May 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 39ea1003-7faf-4593-a8bf-32ddb99e4904

📥 Commits

Reviewing files that changed from the base of the PR and between bef816a and 3b95672.

📒 Files selected for processing (1)
  • .github/workflows/scripts/run-migration-tests.sh

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Improved migration test execution by ensuring version tags are properly fetched during test runs, enabling more reliable test discovery and execution.

Walkthrough

The migration test script now explicitly fetches remote Git tags on startup by uncommenting git fetch --tags at line 28. This ensures the subsequent version detection logic has access to the complete set of available version tags.

Changes

Enable Tag Fetching

Layer / File(s) Summary
Enable git fetch --tags
.github/workflows/scripts/run-migration-tests.sh
The git fetch --tags command is uncommented to ensure remote version tags are fetched before the script discovers which versions to test.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A tag once hidden, now runs free,
Git fetches versions with a spree,
Migration tests know what to test,
One little line makes the script blessed! 🐰✨

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 05-13-fixes_migration-test-script

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants