Conversation
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
akshaydeo
reviewed
May 12, 2025
akshaydeo
reviewed
May 12, 2025
af97ac5 to
5a8e65f
Compare
5a8e65f to
caccb90
Compare
bd5e3db to
33c657e
Compare
4b796c8 to
37a65dc
Compare
caccb90 to
f94b2ec
Compare
f94b2ec to
c664ced
Compare
c664ced to
c1b4e56
Compare
akshaydeo
added a commit
that referenced
this pull request
Nov 17, 2025
# Add support for Maxim Logger plugin This PR adds support for the Maxim Logger plugin in the Bifrost HTTP transport. The implementation includes: - Added new command line arguments for plugin configuration: - `-plugins`: Comma-separated list of plugins to load - `-maxim-logger-id`: ID for the Maxim logger - Updated the Dockerfile to support these new arguments with environment variables: - `APP_PLUGINS` - `APP_MAXIM_LOGGER_ID` - Implemented plugin loading logic that: - Parses the plugins string into a list - Handles the "maxim" plugin specifically, checking for required configuration - Requires `MAXIM_API_KEY` environment variable for the Maxim plugin - Added the Maxim plugin dependency to go.mod The Prometheus plugin is now included in the loadedPlugins list alongside any other enabled plugins.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Add support for Maxim Logger plugin
This PR adds support for the Maxim Logger plugin in the Bifrost HTTP transport. The implementation includes:
Added new command line arguments for plugin configuration:
-plugins: Comma-separated list of plugins to load-maxim-logger-id: ID for the Maxim loggerUpdated the Dockerfile to support these new arguments with environment variables:
APP_PLUGINSAPP_MAXIM_LOGGER_IDImplemented plugin loading logic that:
MAXIM_API_KEYenvironment variable for the Maxim pluginAdded the Maxim plugin dependency to go.mod
The Prometheus plugin is now included in the loadedPlugins list alongside any other enabled plugins.