Skip to content

feat: add Maxim logger plugin support to HTTP transport#34

Merged
akshaydeo merged 1 commit intomainfrom
05-12-feat_maxim_sdk_plugin_integration_added_to_bifrost_http_transport
May 13, 2025
Merged

feat: add Maxim logger plugin support to HTTP transport#34
akshaydeo merged 1 commit intomainfrom
05-12-feat_maxim_sdk_plugin_integration_added_to_bifrost_http_transport

Conversation

@Pratham-Mishra04
Copy link
Copy Markdown
Collaborator

Add support for Maxim Logger plugin

This PR adds support for the Maxim Logger plugin in the Bifrost HTTP transport. The implementation includes:

  • Added new command line arguments for plugin configuration:

    • -plugins: Comma-separated list of plugins to load
    • -maxim-logger-id: ID for the Maxim logger
  • Updated the Dockerfile to support these new arguments with environment variables:

    • APP_PLUGINS
    • APP_MAXIM_LOGGER_ID
  • Implemented plugin loading logic that:

    • Parses the plugins string into a list
    • Handles the "maxim" plugin specifically, checking for required configuration
    • Requires MAXIM_API_KEY environment variable for the Maxim plugin
  • Added the Maxim plugin dependency to go.mod

The Prometheus plugin is now included in the loadedPlugins list alongside any other enabled plugins.

Copy link
Copy Markdown
Collaborator Author

Pratham-Mishra04 commented May 12, 2025

Comment thread transports/Dockerfile Outdated
Comment thread transports/bifrost-http/main.go Outdated
@Pratham-Mishra04 Pratham-Mishra04 force-pushed the 05-12-feat_maxim_sdk_plugin_integration_added_to_bifrost_http_transport branch from af97ac5 to 5a8e65f Compare May 12, 2025 17:51
@Pratham-Mishra04 Pratham-Mishra04 marked this pull request as ready for review May 12, 2025 17:56
@Pratham-Mishra04 Pratham-Mishra04 force-pushed the 05-12-feat_maxim_sdk_plugin_integration_added_to_bifrost_http_transport branch from 5a8e65f to caccb90 Compare May 13, 2025 12:25
@Pratham-Mishra04 Pratham-Mishra04 force-pushed the 05-12-fix_genai_http_router_integration_fixes branch from bd5e3db to 33c657e Compare May 13, 2025 12:25
@akshaydeo akshaydeo force-pushed the 05-12-fix_genai_http_router_integration_fixes branch 2 times, most recently from 4b796c8 to 37a65dc Compare May 13, 2025 19:41
@akshaydeo akshaydeo force-pushed the 05-12-feat_maxim_sdk_plugin_integration_added_to_bifrost_http_transport branch from caccb90 to f94b2ec Compare May 13, 2025 19:41
@akshaydeo akshaydeo changed the base branch from 05-12-fix_genai_http_router_integration_fixes to graphite-base/34 May 13, 2025 19:45
@akshaydeo akshaydeo force-pushed the 05-12-feat_maxim_sdk_plugin_integration_added_to_bifrost_http_transport branch from f94b2ec to c664ced Compare May 13, 2025 19:45
@graphite-app graphite-app Bot changed the base branch from graphite-base/34 to main May 13, 2025 19:46
@akshaydeo akshaydeo force-pushed the 05-12-feat_maxim_sdk_plugin_integration_added_to_bifrost_http_transport branch from c664ced to c1b4e56 Compare May 13, 2025 19:46
@akshaydeo akshaydeo merged commit a4c5863 into main May 13, 2025
1 check passed
@Pratham-Mishra04 Pratham-Mishra04 deleted the 05-12-feat_maxim_sdk_plugin_integration_added_to_bifrost_http_transport branch May 13, 2025 20:06
akshaydeo added a commit that referenced this pull request Nov 17, 2025
# Add support for Maxim Logger plugin

This PR adds support for the Maxim Logger plugin in the Bifrost HTTP transport. The implementation includes:

- Added new command line arguments for plugin configuration:
  - `-plugins`: Comma-separated list of plugins to load
  - `-maxim-logger-id`: ID for the Maxim logger

- Updated the Dockerfile to support these new arguments with environment variables:
  - `APP_PLUGINS`
  - `APP_MAXIM_LOGGER_ID`

- Implemented plugin loading logic that:
  - Parses the plugins string into a list
  - Handles the "maxim" plugin specifically, checking for required configuration
  - Requires `MAXIM_API_KEY` environment variable for the Maxim plugin

- Added the Maxim plugin dependency to go.mod

The Prometheus plugin is now included in the loadedPlugins list alongside any other enabled plugins.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants