feat: adds support for custom selection of plugins for otel trace span exports

[roroghost17]

Summary

Adds a plugin_span_filter feature to the OTEL plugin that lets operators control which plugin hook spans are exported to the OTEL collector. Without filtering, every plugin generates two spans per request (pre- and post-hook), which can produce 16+ plugin spans per request with the default set of built-in plugins. This change introduces a plugin_span_filter field inside the OTEL plugin config (both config.json and DB) and a UI sheet ("Configure Plugin Tracing") for managing this at runtime.

Changes

• plugins/otel: Added PluginSpanFilter type with include/exclude modes. shouldExportSpan checks each span against the filter; buildReparentMap resolves chains of consecutive filtered spans so their children are re-parented to the nearest exported ancestor, keeping the trace hierarchy intact. Init and ValidateConfig both validate that plugin_span_filter.mode is a recognized value.
• transports/bifrost-http/handlers/plugins.go: updatePlugin now fetches the existing plugin before saving and merges the incoming config over the existing DB config using maps.Copy, so fields like plugin_span_filter that are not sent by the OTEL config form are not silently wiped on save.
• UI: Added PluginTracingSheet — a side sheet accessible via a new "Configure Plugin Tracing" button on the Plugins page (and on the empty state). It renders per-plugin toggles (built-in and custom) with tri-state select-all checkboxes, reads the current filter from the OTEL plugin's DB config, and saves only plugin_span_filter into the OTEL plugin config via updatePlugin. Added PluginSpanFilter and PluginSpanFilterMode types to the UI type definitions.
• Docs: Added a "Filtering Plugin Spans" section to the OTEL observability page and a config.plugin_span_filter row to the plugins config reference.
• Schema: Added plugin_span_filter inside the OTEL plugin config object to config.schema.json.
• Tests: Added converter_test.go (unit tests for shouldExportSpan and buildReparentMap), filter_test.go (JSON round-trip tests for PluginSpanFilter and Config), plugins_test.go in the handlers package (config merge behavior), and passthrough tests in config_test.go.

Type of change

• Bug fix
• Feature
• Refactor
• Documentation
• Chore/CI

Affected areas

• Core (Go)
• Transports (HTTP)
• Providers/Integrations
• Plugins
• UI (React)
• Docs

How to test

# Backend
go test ./plugins/otel/...
go test ./transports/bifrost-http/handlers/...
go test ./transports/bifrost-http/lib/...

# UI
cd ui
pnpm i
pnpm build

config.json (inside the OTEL plugin config):

{
  "plugins": [
    {
      "name": "otel",
      "enabled": true,
      "config": {
        "collector_url": "...",
        "trace_type": "genai_extension",
        "protocol": "http",
        "plugin_span_filter": {
          "mode": "exclude",
          "plugins": ["logging", "compat", "telemetry", "otel"]
        }
      }
    }
  ]
}

Restart Bifrost and verify that traces no longer contain spans for the listed plugins, and that child spans of filtered plugins are re-parented to the nearest exported ancestor.

UI flow: Navigate to Plugins → click "Configure Plugin Tracing" → toggle individual plugins off → Save. Verify the OTEL plugin's DB config contains plugin_span_filter and that subsequent saves of the OTEL config form do not wipe the filter.

Precedence: Set plugin_span_filter in config.json with a higher version value and a different value via the UI. Restart and confirm the config.json value takes effect.

Breaking changes

• No

Security considerations

No new secrets or PII are introduced. The filter configuration contains only plugin names and a mode string.

Checklist

• I added/updated tests where appropriate
• I updated documentation where needed
• I verified builds succeed (Go and UI)

[CLAassistant]

All committers have signed the CLA.

[mintlify]

Preview deployment for your docs. Learn more about Mintlify Previews.

Project	Status	Preview	Updated (UTC)
bifrost	🟢 Ready	View Preview	May 11, 2026, 10:33 AM

💡 Tip: Enable Workflows to automatically generate PRs for you.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6d984a87-75b6-4ea0-a6b8-7c7388113a0e

📥 Commits

Reviewing files that changed from the base of the PR and between 942cba6 and 726f84c.

📒 Files selected for processing (11)

• docs/deployment-guides/config-json/plugins.mdx
• docs/features/observability/otel.mdx
• plugins/otel/converter.go
• plugins/otel/converter_test.go
• plugins/otel/filter_test.go
• plugins/otel/main.go
• transports/bifrost-http/handlers/plugins.go
• transports/bifrost-http/handlers/plugins_test.go
• transports/bifrost-http/lib/config.go
• transports/bifrost-http/lib/config_test.go
• transports/config.schema.json

✅ Files skipped from review due to trivial changes (1)

• docs/features/observability/otel.mdx

🚧 Files skipped from review as they are similar to previous changes (10)

• docs/deployment-guides/config-json/plugins.mdx
• transports/config.schema.json
• transports/bifrost-http/handlers/plugins_test.go
• transports/bifrost-http/handlers/plugins.go
• transports/bifrost-http/lib/config_test.go
• transports/bifrost-http/lib/config.go
• plugins/otel/converter.go
• plugins/otel/main.go
• plugins/otel/filter_test.go
• plugins/otel/converter_test.go

---

📝 Walkthrough

Summary by CodeRabbit

• New Features

  • Plugin span filtering for OpenTelemetry: include/exclude modes, per-plugin toggles, and span reparenting to preserve traces
  • UI: "Configure Plugin Tracing" sheet with per-plugin switches, tri-state “toggle all”, and built-in plugin list endpoint
  • Config: schema and server now accept/preserve plugin_span_filter and merge persisted plugin configs on updates

• Documentation

  • Added “Filtering Plugin Spans” guide and updated OTEL config docs with examples and UI precedence notes

• Tests

  • Added coverage for filter parsing, reparenting, config merge, and related UI flows

Walkthrough

This PR adds configurable filtering of OpenTelemetry plugin hook spans. Users can exclude or include specific plugins via a plugin_span_filter configuration block in config.json or through the React UI. Filtered spans are re-parented to the nearest unfiltered ancestor to keep traces connected. Plugin update handling now merges incoming config over existing stored config to preserve unspecified fields; a builtins API and UI controls are added alongside tests and schema/types.

Changes

OTEL Plugin Span Filtering

Layer / File(s)	Summary
Data Types, Config Structures & Schema plugins/otel/main.go, ui/lib/types/config.ts, transports/config.schema.json, transports/bifrost-http/lib/config.go	Introduces PluginSpanFilterMode and PluginSpanFilter types in Go and TS; adds Config.PluginSpanFilter and OtelPlugin.pluginSpanFilter; centralizes builtin plugin name list with GetBuiltinPluginNames(); updates JSON schema for the otel plugin config.
Config Validation & Wiring plugins/otel/main.go	Validates plugin_span_filter.mode during Init and ValidateConfig; assigns resolved filter into the plugin instance.
Core Span Filtering & Trace Hierarchy Repair plugins/otel/converter.go	Adds shouldExportSpan for per-span decisions, buildReparentMap to compute remaps for filtered spans, and updates convertTraceToResourceSpan to skip filtered spans and rewrite kept spans' ParentSpanId.
Plugin Update Handler with Config Merge & Builtins API transports/bifrost-http/handlers/plugins.go	Registers GET /api/plugins/builtins; updatePlugin fetches existing plugin, merges existing config map with request config (preserving fields like plugin_span_filter), persists the merged config, and reloads enabled plugins using the merged config.
Plugin Update Handler Tests transports/bifrost-http/handlers/plugins_test.go	Adds capturePluginsStore, request helpers, and tests verifying that config merge preserves plugin_span_filter and that new-plugin updates succeed.
Span Conversion & Reparenting Tests plugins/otel/converter_test.go	Adds makeSpan helper and table-driven tests: TestShouldExportSpan (nil/include/exclude, non-plugin spans, name parsing) and TestBuildReparentMap (single/chained/root-level filtered spans).
Filter Config Parsing Tests plugins/otel/filter_test.go	Adds tests for JSON unmarshalling of PluginSpanFilter, presence in Config, and absent-filter behavior.
Configuration Loading Integration Test transports/bifrost-http/lib/config_test.go	Adds TestLoadPlugins_OtelPluginSpanFilterPassthrough to ensure loadPlugins preserves plugin_span_filter from config.json into loaded OTEL plugin config.
UI: Builtins Endpoint & Store Hook ui/lib/store/apis/pluginsApi.ts	Adds getBuiltinPlugins RTK Query endpoint and exports useGetBuiltinPluginsQuery for UI consumption of built-in plugin names.
Plugins Page & Tracing Sheet UI ui/app/workspace/plugins/page.tsx, ui/app/workspace/plugins/sheets/pluginTracingSheet.tsx	Wires PluginTracingSheet into the page (empty and non-empty layouts), adds a "Configure Plugin Tracing" sidebar button, and implements the tracing sheet which derives toggles from persisted plugin_span_filter (all-enabled fallback) and saves an exclude-mode plugin_span_filter or null.
Empty State & Small UI Edits ui/app/workspace/plugins/views/pluginsEmptyState.tsx, ui/components/ui/tristateCheckbox.tsx	PluginsEmptyState gains optional tracing callback and permission props and the Activity icon button; TriStateCheckboxProps gains optional data-testid forwarded to the rendered button for E2E selectors.
Documentation docs/deployment-guides/config-json/plugins.mdx, docs/features/observability/otel.mdx	Adds plugin_span_filter to the deployment guide field table and a detailed "Filtering Plugin Spans" section covering modes, plugin lists, UI workflow, built-in names, reparenting behavior, and config precedence.

Sequence Diagram(s)

sequenceDiagram
  participant Client
  participant PluginsHandler
  participant ConfigStore
  participant PluginLoader

  Client->>PluginsHandler: PUT /api/plugins/{name} (config)
  PluginsHandler->>ConfigStore: GetPlugin(name)
  PluginsHandler->>ConfigStore: UpdatePlugin(mergedConfig)
  PluginsHandler->>PluginLoader: ReloadPlugin(name, mergedConfig)
  PluginsHandler->>Client: 200 OK

Loading

sequenceDiagram
  participant convertTrace as convertTraceToResourceSpan
  participant buildReparent as buildReparentMap
  participant shouldExport as shouldExportSpan
  participant exporter as OTELExporter

  convertTrace->>buildReparent: compute reparent map from trace spans
  loop each span
    convertTrace->>shouldExport: shouldExportSpan(span)
    alt filtered
      convertTrace->>exporter: skip span
    else exported
      convertTrace->>buildReparent: lookup parent remap
      convertTrace->>exporter: emit span (ParentSpanId rewritten if mapped)
    end
  end

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

🐰 I hop through traces, tidy and spry,

I filter plugin spans that flutter by,
Children reparented so the trace stays whole,
A sheet to toggle — every plugin's role,
Save and restart, and the hops comply.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 56.52% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main feature: adding plugin selection for OTEL trace span exports. It is concise, specific, and directly reflects the primary change.
Description check	✅ Passed	The description comprehensively covers the Summary, Changes, Type of change, Affected areas, How to test, Breaking changes, Security considerations, and Checklist sections as required by the template.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch 05-11-feat_adds_support_for_custom_selection_of_plugins_for_otel_trace_span_exports

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies"

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[roroghost17]

• feat: adds support for custom selection of plugins for otel trace span exports #3382 👈 (View in Graphite)
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

🧪 Test Suite Available

This PR can be tested by a repository admin.

Run tests for PR #3382

[greptile-apps]

Confidence Score: 5/5

The core filtering and reparenting logic is correct and well-tested; the config-merge fix prevents fields from being silently wiped on save.

The filtering, reparenting, and config-merge paths are all well-covered by new tests and the logic is sound. The two findings are minor: a stale struct comment and the UI always saving in exclude mode. Neither affects runtime correctness in the common case.

pluginTracingSheet.tsx (mode conversion on save) and main.go (stale comment on PluginSpanFilter field).

Important Files Changed

Filename	Overview
plugins/otel/converter.go	Adds shouldExportSpan and buildReparentMap for plugin span filtering; reparenting logic correctly resolves chains of consecutive filtered spans with a cycle-safe maxHops bound.
plugins/otel/main.go	New PluginSpanFilter type and Config.PluginSpanFilter field; validation added to both Init and ValidateConfig. Struct comment on PluginSpanFilter is stale and describes a removed design.
transports/bifrost-http/handlers/plugins.go	Adds config-merge logic (maps.Copy over existing DB config before update) and a new /api/plugins/builtins endpoint; merge is skipped when no DB record exists for the plugin.
ui/app/workspace/plugins/sheets/pluginTracingSheet.tsx	New side sheet for managing plugin span tracing; buildFilter always generates exclude mode, silently converting include mode filters when saved via UI.
transports/bifrost-http/lib/config.go	Refactors IsBuiltinPlugin to use a canonical builtinPluginNames slice; adds GetBuiltinPluginNames() for the new API endpoint.
plugins/otel/converter_test.go	Comprehensive unit tests for shouldExportSpan and buildReparentMap, covering nil filter, include/exclude modes, empty plugin lists, and chain resolution.
plugins/otel/filter_test.go	JSON round-trip tests for PluginSpanFilter and its embedding in Config; clean and thorough.
transports/bifrost-http/handlers/plugins_test.go	Tests config-merge behaviour in updatePlugin; covers both the existing-plugin merge path and the new-plugin (no DB record) path.
transports/bifrost-http/lib/config_test.go	Adds passthrough test confirming plugin_span_filter inside the OTEL plugin config is preserved unchanged through loadPlugins.
transports/config.schema.json	Adds plugin_span_filter object schema with mode enum and plugins array to the OTEL plugin config; required and additionalProperties: false correctly set.
ui/lib/store/apis/pluginsApi.ts	Adds getBuiltinPlugins RTK Query endpoint; correct tag, transform, and export.
ui/lib/types/config.ts	Adds PluginSpanFilterMode and PluginSpanFilter TypeScript types matching the Go struct definitions.
ui/app/workspace/plugins/page.tsx	Adds 'Configure Plugin Tracing' button and wires PluginTracingSheet on both the populated and empty-state views.
ui/app/workspace/plugins/views/pluginsEmptyState.tsx	Extends PluginsEmptyState with optional 'Configure Plugin Tracing' button props; backward-compatible with existing callsites.
ui/components/ui/tristateCheckbox.tsx	Adds optional data-testid prop to TriStateCheckbox; minimal, non-breaking change.
docs/features/observability/otel.mdx	Adds 'Filtering Plugin Spans' section with config.json example, mode table, and UI flow documentation.
docs/deployment-guides/config-json/plugins.mdx	Adds config.plugin_span_filter row to the OTEL plugin config reference table.

_{Reviews (10): Last reviewed commit: "feat: adds support for custom selection ..." | Re-trigger Greptile}

[coderabbitai]

Actionable comments posted: 2

🧹 Nitpick comments (1)

transports/config.schema.json (1)

1167-1186: ⚡ Quick win

Deduplicate plugin_span_filter schema to prevent drift.

The same shape is defined twice. Consider defining a single $defs entry (e.g., $defs.plugin_span_filter) and referencing it from both top-level otel_plugin_span_filter and plugins[].config.plugin_span_filter.

Also applies to: 1630-1645

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@transports/config.schema.json` around lines 1167 - 1186, The
otel_plugin_span_filter schema is duplicated; extract its object shape into a
single reusable definition (e.g., $defs.plugin_span_filter) preserving "mode",
"plugins", "required", and "additionalProperties": false, then replace the
inline otel_plugin_span_filter and the plugins[].config.plugin_span_filter
entries with $ref references to that $defs entry (use $ref:
"#/$defs/plugin_span_filter") so both locations share the exact same schema and
prevent drift.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@plugins/otel/main.go`:
- Line 132: The Init function currently accepts and stores the resolved
PluginSpanFilter without validating its mode; add validation logic to verify
pluginSpanFilter.mode is a recognized value before assigning it (e.g., check
against allowed modes like "include"/"exclude" or an enum), and return an error
if the mode is invalid so operator mistakes don't silently disable filtering;
update the same validation where PluginSpanFilter is accepted/assigned elsewhere
in the file (the same pattern around the other PluginSpanFilter assignment code)
and reference the PluginSpanFilter type and Init function when implementing the
check.

In `@transports/bifrost-http/handlers/config.go`:
- Around line 194-199: The code currently swallows json.Unmarshal errors for
h.store.OtelPluginSpanFilter and drops the field; update the block so that if
json.Unmarshal returns an error you log a clear diagnostic (include the error
and the raw bytes/string from h.store.OtelPluginSpanFilter using the service's
logger, e.g. h.logger or equivalent) and preserve the raw value in the output
map (e.g. set mapConfig["otel_plugin_span_filter_raw"] =
string(h.store.OtelPluginSpanFilter)) so bad persisted data can be inspected;
only set mapConfig["otel_plugin_span_filter"] when unmarshalling succeeds as it
does now.

---

Nitpick comments:
In `@transports/config.schema.json`:
- Around line 1167-1186: The otel_plugin_span_filter schema is duplicated;
extract its object shape into a single reusable definition (e.g.,
$defs.plugin_span_filter) preserving "mode", "plugins", "required", and
"additionalProperties": false, then replace the inline otel_plugin_span_filter
and the plugins[].config.plugin_span_filter entries with $ref references to that
$defs entry (use $ref: "#/$defs/plugin_span_filter") so both locations share the
exact same schema and prevent drift.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 81113209-eebc-447a-8e17-10386412ee6a

📥 Commits

Reviewing files that changed from the base of the PR and between a88c7e9 and 79e9a71.

📒 Files selected for processing (16)

• docs/deployment-guides/config-json/plugins.mdx
• docs/features/observability/otel.mdx
• plugins/otel/converter.go
• plugins/otel/converter_test.go
• plugins/otel/filter_test.go
• plugins/otel/main.go
• transports/bifrost-http/handlers/config.go
• transports/bifrost-http/handlers/plugins.go
• transports/bifrost-http/handlers/plugins_test.go
• transports/bifrost-http/lib/config.go
• transports/bifrost-http/lib/config_test.go
• transports/bifrost-http/server/plugins.go
• transports/config.schema.json
• ui/app/workspace/plugins/page.tsx
• ui/app/workspace/plugins/sheets/pluginTracingSheet.tsx
• ui/lib/types/config.ts

👮 Files not reviewed due to content moderation or server errors (4)

• plugins/otel/converter_test.go
• transports/bifrost-http/handlers/plugins_test.go
• transports/bifrost-http/lib/config.go
• ui/app/workspace/plugins/sheets/pluginTracingSheet.tsx

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@plugins/otel/main.go`:
- Around line 153-160: ValidateConfig should reject invalid plugin span filter
modes early: add the same validation logic present in Init to ValidateConfig to
check config.PluginSpanFilter != nil and ensure config.PluginSpanFilter.Mode is
either PluginSpanFilterModeInclude or PluginSpanFilterModeExclude; if not,
return a formatted error (matching the Init message) referencing
PluginSpanFilterModeInclude and PluginSpanFilterModeExclude so invalid mode
strings fail config/API validation instead of only during Init.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e1756dfe-d6ec-4c5b-ac4e-d8010cf57bd1

📥 Commits

Reviewing files that changed from the base of the PR and between 79e9a71 and b2159f9.

📒 Files selected for processing (16)

• docs/deployment-guides/config-json/plugins.mdx
• docs/features/observability/otel.mdx
• plugins/otel/converter.go
• plugins/otel/converter_test.go
• plugins/otel/filter_test.go
• plugins/otel/main.go
• transports/bifrost-http/handlers/config.go
• transports/bifrost-http/handlers/plugins.go
• transports/bifrost-http/handlers/plugins_test.go
• transports/bifrost-http/lib/config.go
• transports/bifrost-http/lib/config_test.go
• transports/config.schema.json
• ui/app/workspace/plugins/page.tsx
• ui/app/workspace/plugins/sheets/pluginTracingSheet.tsx
• ui/app/workspace/plugins/views/pluginsEmptyState.tsx
• ui/lib/types/config.ts

✅ Files skipped from review due to trivial changes (5)

• transports/bifrost-http/handlers/config.go
• docs/features/observability/otel.mdx
• plugins/otel/filter_test.go
• docs/deployment-guides/config-json/plugins.mdx
• ui/lib/types/config.ts

🚧 Files skipped from review as they are similar to previous changes (9)

• ui/app/workspace/plugins/page.tsx
• transports/config.schema.json
• transports/bifrost-http/handlers/plugins_test.go
• plugins/otel/converter.go
• transports/bifrost-http/lib/config_test.go
• ui/app/workspace/plugins/sheets/pluginTracingSheet.tsx
• transports/bifrost-http/handlers/plugins.go
• plugins/otel/converter_test.go
• transports/bifrost-http/lib/config.go

[coderabbitai]

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@transports/bifrost-http/lib/config_test.go`:
- Around line 18236-18239: The test only asserts filterMap["mode"] but misses
verifying the passthrough of the plugin list; update the test that builds/reads
raw -> filterMap (variables raw and filterMap) to also assert that
filterMap["plugins"] exists and equals the expected plugin slice (the original
plugin list used for plugin_span_filter) so the plugins list is preserved
through parsing.

In `@ui/app/workspace/plugins/sheets/pluginTracingSheet.tsx`:
- Around line 114-126: Add a data-testid prop to both TriStateCheckbox "select
all" controls in pluginTracingSheet.tsx: for the built-in plugins
TriStateCheckbox (the one using allIds={[...BUILTIN_PLUGIN_NAMES]} and
selectedIds={BUILTIN_PLUGIN_NAMES.filter(...)}) add
data-testid="select-all-builtins" (or similar consistent name), and add a
matching data-testid (e.g., "select-all-plugins") to the other TriStateCheckbox
instance later in the file (the second "select all" control referenced in the
comment). Ensure the prop is passed directly to the TriStateCheckbox components
so E2E tests can target them.
- Around line 65-71: The sheet currently seeds toggle defaults when opened
before the OTEL plugin data arrives, so saved filter state can be overwritten;
update the useEffect to only initialize toggles after otelPlugin (the result of
useGetPluginQuery("otel")) is available and contains config (e.g., check
otelPlugin != null and otelPlugin.config is defined) and only then call
setToggles(resolveToggleState(...)) and set wasOpenRef.current = true after
initialization; reference resolveToggleState, setToggles, wasOpenRef,
otelPlugin, and the useEffect to ensure initialization waits for OTEL data
rather than running on open alone.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 275b6c3e-2de1-4979-a8da-20bdeca83399

📥 Commits

Reviewing files that changed from the base of the PR and between b2159f9 and 256c125.

📒 Files selected for processing (15)

• docs/deployment-guides/config-json/plugins.mdx
• docs/features/observability/otel.mdx
• plugins/otel/converter.go
• plugins/otel/converter_test.go
• plugins/otel/filter_test.go
• plugins/otel/main.go
• transports/bifrost-http/handlers/plugins.go
• transports/bifrost-http/handlers/plugins_test.go
• transports/bifrost-http/lib/config.go
• transports/bifrost-http/lib/config_test.go
• transports/config.schema.json
• ui/app/workspace/plugins/page.tsx
• ui/app/workspace/plugins/sheets/pluginTracingSheet.tsx
• ui/app/workspace/plugins/views/pluginsEmptyState.tsx
• ui/lib/types/config.ts

✅ Files skipped from review due to trivial changes (3)

• transports/bifrost-http/lib/config.go
• docs/features/observability/otel.mdx
• transports/bifrost-http/handlers/plugins_test.go

🚧 Files skipped from review as they are similar to previous changes (6)

• plugins/otel/filter_test.go
• plugins/otel/converter_test.go
• ui/app/workspace/plugins/views/pluginsEmptyState.tsx
• plugins/otel/converter.go
• transports/bifrost-http/handlers/plugins.go
• ui/app/workspace/plugins/page.tsx

[roroghost17]

@coderabbitai full-review

[coderabbitai]

@roroghost17, I'll kick off a full review of this PR right away!

✅ Actions performed

Full review triggered.

[coderabbitai]

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/features/observability/otel.mdx`:
- Around line 910-947: Restructure the OTEL feature section to use Mintlify tabs
titled "Web UI", "API", and "config.json": move the current UI instructions into
the "Web UI" tab, add any HTTP/API guidance into the "API" tab (if none exists,
put a short note or omit), and place the shown JSON example and
config.json-specific notes (including plugin_span_filter, trace_type, protocol,
collector_url and version guidance) into the "config.json" tab; ensure the
config.json example validates against transports/config.schema.json and keep the
note about plugin_span_filter precedence (version) inside the config.json tab.

In `@plugins/otel/main.go`:
- Around line 76-78: Update the field comment for PluginSpanFilter to reflect
the current config flow: state that PluginSpanFilter comes from
Config.plugin_span_filter (the config package's Config struct) and is used
directly at Init time, that Init no longer accepts a separate pluginSpanFilter
argument, and remove any mention of the legacy otel_plugin_span_filter top-level
field or an Init override; keep note if this field is still a DB-stored fallback
if applicable.

In `@transports/bifrost-http/handlers/plugins_test.go`:
- Around line 39-41: The CreatePlugin method on capturePluginsStore is a no-op
so tests that only assert "not 500" can pass for wrong status codes; implement
CreatePlugin to persist the incoming *configstoreTables.TablePlugin into the
store's in-memory slice/map (the capturePluginsStore backing state) and update
the test that exercises the handler to assert a 200 OK success response (instead
of only checking not-500) and that the persisted plugin exists in
capturePluginsStore after the handler runs; refer to CreatePlugin and
capturePluginsStore and the handler test that currently checks response status
around the 154–157 area when making these changes.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ea92cb48-163b-417b-ab6e-02f0239f7897

📥 Commits

Reviewing files that changed from the base of the PR and between a88c7e9 and 320b4c6.

📒 Files selected for processing (16)

• docs/deployment-guides/config-json/plugins.mdx
• docs/features/observability/otel.mdx
• plugins/otel/converter.go
• plugins/otel/converter_test.go
• plugins/otel/filter_test.go
• plugins/otel/main.go
• transports/bifrost-http/handlers/plugins.go
• transports/bifrost-http/handlers/plugins_test.go
• transports/bifrost-http/lib/config.go
• transports/bifrost-http/lib/config_test.go
• transports/config.schema.json
• ui/app/workspace/plugins/page.tsx
• ui/app/workspace/plugins/sheets/pluginTracingSheet.tsx
• ui/app/workspace/plugins/views/pluginsEmptyState.tsx
• ui/components/ui/tristateCheckbox.tsx
• ui/lib/types/config.ts

The base branch was changed.

[akshaydeo]

Merge activity

• May 15, 4:44 AM UTC: A user started a stack merge that includes this pull request via Graphite.
• May 15, 4:44 AM UTC: @akshaydeo merged this pull request with Graphite.