feat: add Google Vertex AI provider support#29
Merged
Conversation
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
akshaydeo
requested changes
May 6, 2025
| @@ -36,7 +36,7 @@ type MetaConfig interface { | |||
| // GetSecretAccessKey returns the secret access key for authentication | |||
| GetSecretAccessKey() *string | |||
Contributor
There was a problem hiding this comment.
do you think now converting API key should be an interface{}/Generic based struct and it returns based on which provider its calling? cc @danpiths
Contributor
There was a problem hiding this comment.
So we don't have to keep on adding new methods to this interface and bloat it
Collaborator
There was a problem hiding this comment.
i'm sorry i didn't get the should be an interface{}/Generic based struct
Contributor
There was a problem hiding this comment.
The problem here is - every extra field we add to the config, we have to add a new method like GetSecretAccessKey, GetServiceAccountAccessKey.
Better we keep overall MetaConfig as map[string]interface{} and parse it to specific type in corresponding providers
Pratham-Mishra04
force-pushed
the
05-06-feat_vertex_ai_provider_added
branch
from
3693c51 to
59cc5d1
Compare
Pratham-Mishra04
force-pushed
the
05-06-feat_vertex_ai_provider_added
branch
from
59cc5d1 to
2dc0a0d
Compare
akshaydeo
approved these changes
May 12, 2025
Contributor
Merge activity
|
akshaydeo
added a commit
that referenced
this pull request
Nov 17, 2025
# Add Google Vertex AI Provider Support This PR adds support for Google Vertex AI as a new provider in Bifrost, allowing users to access Google's AI models like Gemini and third-party models hosted on Vertex AI. Key changes: - Implemented a new `VertexProvider` that supports chat completion with Google's models - Added authentication via Google Cloud credentials - Created region-specific model routing for Vertex AI endpoints - Refactored provider code to extract common request preparation logic - Added support for both OpenAI-style and Anthropic-style models on Vertex - Enhanced error handling and debugging for all providers The implementation uses Google's OAuth2 authentication and doesn't require API keys like other providers, instead using service account credentials. The PR also updates the gitignore to exclude credential files for security.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Google Vertex AI Provider Support
This PR adds support for Google Vertex AI as a new provider in Bifrost, allowing users to access Google's AI models like Gemini and third-party models hosted on Vertex AI.
Key changes:
VertexProviderthat supports chat completion with Google's modelsThe implementation uses Google's OAuth2 authentication and doesn't require API keys like other providers, instead using service account credentials. The PR also updates the gitignore to exclude credential files for security.