Skip to content

backmerge#2821

Merged
akshaydeo merged 1 commit intov1.5.0from
04-18-backmerge
Apr 18, 2026
Merged

backmerge#2821
akshaydeo merged 1 commit intov1.5.0from
04-18-backmerge

Conversation

@akshaydeo
Copy link
Copy Markdown
Contributor

@akshaydeo akshaydeo commented Apr 18, 2026

Summary

Bumps the AWS S3 SDK and related internal packages to their latest versions across all modules in the repository.

Changes

  • github.com/aws/aws-sdk-go-v2/service/s3 upgraded from v1.94.0v1.97.3
  • github.com/aws/aws-sdk-go-v2/internal/v4a upgraded from v1.4.16v1.4.22
  • github.com/aws/aws-sdk-go-v2/service/internal/checksum upgraded from v1.9.7v1.9.13
  • github.com/aws/aws-sdk-go-v2/service/internal/s3shared upgraded from v1.19.16v1.19.21

Type of change

  • Bug fix
  • Feature
  • Refactor
  • Documentation
  • Chore/CI

Affected areas

  • Core (Go)
  • Transports (HTTP)
  • Providers/Integrations
  • Plugins
  • UI (React)
  • Docs

How to test

go test ./...

Breaking changes

  • Yes
  • No

Related issues

Security considerations

Keeping AWS SDK dependencies up to date reduces exposure to any vulnerabilities patched in newer releases.

Checklist

  • I read docs/contributing/README.md and followed the guidelines
  • I added/updated tests where appropriate
  • I updated documentation where needed
  • I verified builds succeed (Go and UI)
  • I verified the CI pipeline passes locally if applicable

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 18, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c6ffd2f8-b05a-480a-8351-4b1574acfdfe

📥 Commits

Reviewing files that changed from the base of the PR and between f6b481c and 8ab639b.

⛔ Files ignored due to path filters (13)
  • core/go.sum is excluded by !**/*.sum
  • framework/go.sum is excluded by !**/*.sum
  • plugins/compat/go.sum is excluded by !**/*.sum
  • plugins/governance/go.sum is excluded by !**/*.sum
  • plugins/jsonparser/go.sum is excluded by !**/*.sum
  • plugins/logging/go.sum is excluded by !**/*.sum
  • plugins/maxim/go.sum is excluded by !**/*.sum
  • plugins/mocker/go.sum is excluded by !**/*.sum
  • plugins/otel/go.sum is excluded by !**/*.sum
  • plugins/prompts/go.sum is excluded by !**/*.sum
  • plugins/semanticcache/go.sum is excluded by !**/*.sum
  • plugins/telemetry/go.sum is excluded by !**/*.sum
  • transports/go.sum is excluded by !**/*.sum
📒 Files selected for processing (13)
  • core/go.mod
  • framework/go.mod
  • plugins/compat/go.mod
  • plugins/governance/go.mod
  • plugins/jsonparser/go.mod
  • plugins/logging/go.mod
  • plugins/maxim/go.mod
  • plugins/mocker/go.mod
  • plugins/otel/go.mod
  • plugins/prompts/go.mod
  • plugins/semanticcache/go.mod
  • plugins/telemetry/go.mod
  • transports/go.mod

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated AWS SDK dependencies to their latest versions across core modules, framework components, and all plugins throughout the codebase.

Walkthrough

AWS SDK for Go v2 dependencies are bumped across 13 module files. The S3 service package updates from v1.94.0 to v1.97.3, with corresponding updates to internal checksum, s3shared, and v4a components. No code logic or public APIs are altered.

Changes

Cohort / File(s) Summary
AWS SDK S3 Dependency Updates
core/go.mod, framework/go.mod, plugins/compat/go.mod, plugins/governance/go.mod, plugins/jsonparser/go.mod, plugins/logging/go.mod, plugins/maxim/go.mod, plugins/mocker/go.mod, plugins/otel/go.mod, plugins/prompts/go.mod, plugins/semanticcache/go.mod, plugins/telemetry/go.mod, transports/go.mod
Uniform version bumps across all modules: github.com/aws/aws-sdk-go-v2/service/s3 (v1.94.0 → v1.97.3), github.com/aws/aws-sdk-go-v2/internal/v4a (v1.4.16 → v1.4.22), github.com/aws/aws-sdk-go-v2/service/internal/checksum (v1.9.7 → v1.9.13), and github.com/aws/aws-sdk-go-v2/service/internal/s3shared (v1.19.16 → v1.19.21).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested reviewers

  • danpiths

Poem

🐰 Dependencies hop to a newer release,
AWS SDK v2 finds its peace,
S3 and friends all updated with care,
Thirteen modules sync without despair!

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 04-18-backmerge

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.11.4)

level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies"


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@akshaydeo akshaydeo marked this pull request as ready for review April 18, 2026 00:14
Copy link
Copy Markdown
Contributor Author

akshaydeo commented Apr 18, 2026

Merge activity

  • Apr 18, 12:14 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Apr 18, 12:15 AM UTC: @akshaydeo merged this pull request with Graphite.

@akshaydeo akshaydeo merged commit 676eb7a into v1.5.0 Apr 18, 2026
9 of 17 checks passed
@akshaydeo akshaydeo deleted the 04-18-backmerge branch April 18, 2026 00:15
@coderabbitai coderabbitai Bot requested a review from danpiths April 18, 2026 00:15
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 18, 2026

Confidence Score: 4/5

Safe to merge after fixing the two go 1.26.2 declarations that regress the v1.5.0 Go version enforcement.

Two P1 findings in transports/go.mod and plugins/prompts/go.mod declare go 1.26.2, directly undoing the go 1.26.1 standardization enforced by the immediately preceding commit (#2820) on the v1.5.0 branch.

transports/go.mod and plugins/prompts/go.mod (go version mismatch)

Important Files Changed

Filename Overview
transports/go.mod Go version bumped to 1.26.2, inconsistent with the rest of the workspace which targets go 1.26.1 (enforced by commit #2820)
plugins/prompts/go.mod Go version is 1.26.2, inconsistent with the go 1.26.1 standard enforced for all other modules in this repo
plugins/semanticcache/go.mod References plugins/mocker v1.5.1 while transports and other modules have moved to v1.5.2; stale dependency pin
core/go.mod Go version correctly set to 1.26.1; dependency versions look consistent
framework/go.mod Go version correctly set to 1.26.1; all dependency versions aligned with the rest of the workspace

Comments Outside Diff (3)

  1. transports/go.mod, line 3 (link)

    P1 Go version inconsistent with workspace standard

    This module declares go 1.26.2, but every other module in this repository (core, framework, and all plugins) uses go 1.26.1. Commit enforce go 1.26.1 #2820 ("enforce go 1.26.1") immediately preceding this backmerge explicitly standardized the entire workspace on 1.26.1. The same divergence exists in plugins/prompts/go.mod. These two modules should be aligned back to 1.26.1.

  2. plugins/prompts/go.mod, line 3 (link)

    P1 Go version inconsistent with workspace standard

    Same issue as transports/go.mod: this module declares go 1.26.2 while the workspace-wide standard enforced by commit enforce go 1.26.1 #2820 is go 1.26.1.

  3. plugins/semanticcache/go.mod, line 10 (link)

    P2 Stale internal dependency version

    plugins/semanticcache pins plugins/mocker at v1.5.1, but transports/go.mod (line 134) already references plugins/mocker v1.5.2. The rest of the internal dependency chain has moved to v1.5.2. When semanticcache is built standalone, it will pull in the older mocker release; aligning it to v1.5.2 keeps the module graph consistent.

Reviews (1): Last reviewed commit: "backmerge" | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants