Skip to content

bumped up hello-world dep #2819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akshaydeo merged 1 commit into from
Apr 17, 2026
Merged

bumped up hello-world dep #2819

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions examples/plugins/hello-world-wasm-go/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,8 @@ module github.com/maximhq/bifrost/examples/plugins/hello-world-wasm

go 1.26.1

require github.com/maximhq/bifrost/core v0.0.0-00010101000000-000000000000
require github.com/maximhq/bifrost/core v1.4.17
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 go.sum not updated for new version

go.mod now requires github.com/maximhq/bifrost/core v1.4.17, but go.sum only contains checksums for v1.3.3. Go's module verification will reject the build because there is no go.sum entry for v1.4.17. Run go mod tidy (or go get github.com/maximhq/bifrost/core@v1.4.17) in this directory and commit the updated go.sum.

The same issue exists in examples/plugins/hello-world/go.sum, which contains checksums for v1.4.19 while go.mod specifies v1.4.17.


replace github.com/maximhq/bifrost/core => ../../../core

require (
github.com/andybalholm/brotli v1.2.0 // indirect
Expand Down
2 changes: 1 addition & 1 deletion examples/plugins/hello-world/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ module github.com/maximhq/bifrost/examples/plugins/hello-world

go 1.26.1

require github.com/maximhq/bifrost/core v1.4.19
require github.com/maximhq/bifrost/core v1.4.17

require (
github.com/andybalholm/brotli v1.2.0 // indirect
Expand Down
Loading