Skip to content

temp hack for tests #2810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akshaydeo merged 1 commit into from
Apr 17, 2026
Merged

temp hack for tests #2810

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/scripts/setup-go-workspace.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ if [ -f "go.work" ]; then
return 0 2>/dev/null || exit 0
fi
go work init
# Bump workspace go directive so GOTOOLCHAIN=auto switches to >= 1.26.2
# (required by published core@v1.4.19 which is referenced from transports/go.mod).
go work edit -go=1.26.2 -toolchain=go1.26.2
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Workspace go version higher than all local modules

All local go.mod files (core, transports, and all plugins) declare go 1.26.1, but this line sets the workspace to go 1.26.2. With GOTOOLCHAIN=auto that will trigger a download of the go1.26.2 toolchain on every fresh CI run where that toolchain isn't cached, even though the local sources only require 1.26.1. If the published core@v1.4.19 genuinely requires 1.26.2 (as the PR description states), the discrepancy between the published module and the local core/go.mod (go 1.26.1) might be worth syncing to avoid confusion.

go work use ./core
go work use ./framework
go work use ./plugins/governance
Expand Down
Loading