Skip to content

feat: add retryable status codes for error handling #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akshaydeo merged 1 commit into from
May 6, 2025
Merged

feat: add retryable status codes for error handling #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions core/bifrost.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,13 +263,19 @@ func (bifrost *Bifrost) SelectKeyFromProviderForModel(providerKey schemas.ModelP
return supportedKeys[0].Value, nil
}

// Define a set of retryable status codes
var retryableStatusCodes = map[int]bool{
500: true, // Internal Server Error
502: true, // Bad Gateway
503: true, // Service Unavailable
504: true, // Gateway Timeout
429: true, // Too Many Requests
}

// calculateBackoff implements exponential backoff with jitter for retry attempts.
func (bifrost *Bifrost) calculateBackoff(attempt int, config *schemas.ProviderConfig) time.Duration {
// Calculate an exponential backoff: initial * 2^attempt
backoff := config.NetworkConfig.RetryBackoffInitial * time.Duration(1<<uint(attempt))
if backoff > config.NetworkConfig.RetryBackoffMax {
backoff = config.NetworkConfig.RetryBackoffMax
}
backoff := min(config.NetworkConfig.RetryBackoffInitial*time.Duration(1<<uint(attempt)), config.NetworkConfig.RetryBackoffMax)

// Add jitter (±20%)
jitter := float64(backoff) * (0.8 + 0.4*rand.Float64())
Expand Down Expand Up @@ -362,8 +368,7 @@ func (bifrost *Bifrost) requestWorker(provider schemas.Provider, queue chan Chan
bifrost.logger.Debug(fmt.Sprintf("Request for provider %s completed", provider.GetProviderKey()))

// Check if successful or if we should retry
//TODO should have a better way to check for only network errors
if bifrostError == nil || bifrostError.IsBifrostError { // Only retry non-bifrost errors
if bifrostError == nil || bifrostError.IsBifrostError || (bifrostError.StatusCode != nil && !retryableStatusCodes[*bifrostError.StatusCode]) {
break
}
}
Expand Down