Skip to content

test fixes --skip-pipeline #2782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akshaydeo merged 1 commit into from
Apr 17, 2026
+10 −14
Merged

test fixes --skip-pipeline #2782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/providers/anthropic/chat_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ func TestToAnthropicChatRequest_CachingDeterminism(t *testing.T) {
Model: "claude-sonnet-4-20250514",
Input: []schemas.ChatMessage{{
Role: schemas.ChatMessageRoleUser,
Content: &schemas.ChatMessageContent{ContentStr: schemas.Ptr("test")},
Content: &schemas.ChatMessageContent{ContentStr: new("test")},
Comment thread
greptile-apps[bot] marked this conversation as resolved.
}},
Params: &schemas.ChatParameters{
Tools: []schemas.ChatTool{{
Expand Down
22 changes: 9 additions & 13 deletions transports/bifrost-http/lib/validator_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -680,25 +680,23 @@ func TestValidateConfigSchema_MCPClientConfig_Valid_Stdio(t *testing.T) {
}
}

func TestValidateConfigSchema_MCPClientConfig_Valid_Websocket(t *testing.T) {
// Valid MCP client config with websocket connection type
func TestValidateConfigSchema_MCPClientConfig_Valid_Sse(t *testing.T) {
// Valid MCP client config with sse connection type
validConfig := `{
"mcp": {
"client_configs": [
{
"name": "my-mcp-client",
"connection_type": "websocket",
"websocket_config": {
"url": "ws://localhost:8080"
}
"connection_type": "sse",
"connection_string": "http://localhost:8080"
}
]
}
}`

err := ValidateConfigSchema([]byte(validConfig), loadLocalSchema(t))
if err != nil {
t.Errorf("expected valid MCP client config (websocket) to pass validation, got error: %v", err)
t.Errorf("expected valid MCP client config (sse) to pass validation, got error: %v", err)
}
}

Expand All @@ -710,9 +708,7 @@ func TestValidateConfigSchema_MCPClientConfig_Valid_Http(t *testing.T) {
{
"name": "my-mcp-client",
"connection_type": "http",
"http_config": {
"url": "http://localhost:8080"
}
"connection_string": "http://localhost:8080"
}
]
}
Expand Down Expand Up @@ -1202,7 +1198,7 @@ func TestValidateConfigSchema_OtelPlugin_Valid(t *testing.T) {
"name": "otel",
"config": {
"collector_url": "http://localhost:4318",
"trace_type": "otel",
"trace_type": "genai_extension",
"protocol": "http"
}
}
Expand All @@ -1223,7 +1219,7 @@ func TestValidateConfigSchema_OtelPlugin_MissingCollectorUrl(t *testing.T) {
"enabled": true,
"name": "otel",
"config": {
"trace_type": "otel",
"trace_type": "genai_extension",
"protocol": "http"
}
}
Expand Down Expand Up @@ -1266,7 +1262,7 @@ func TestValidateConfigSchema_OtelPlugin_MissingProtocol(t *testing.T) {
"name": "otel",
"config": {
"collector_url": "http://localhost:4318",
"trace_type": "otel"
"trace_type": "genai_extension"
}
}
]
Expand Down
Loading