Skip to content

refactor: improve chart card spacing and remove unused routing logic #2751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akshaydeo merged 6 commits into from
Apr 16, 2026
Merged

refactor: improve chart card spacing and remove unused routing logic #2751

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dd37c8b
improvement: logs page filter UI revamp
impoiler Apr 15, 2026
cb5e7a2
improvement: dashboard page filter UI revamp
impoiler Apr 15, 2026
ed795ad
refactor: moved and deleted unused filter components
impoiler Apr 15, 2026
8f1da20
improvement: MCP page filter UI revamp
impoiler Apr 15, 2026
5de4598
refactor: collapsed filter sidebars
impoiler Apr 16, 2026
1811eca
fix: prevent chart layout shifts during loading states
impoiler Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ui/.oxlintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@
"es2024": true
},
"categories": {
"correctness": "error"
"correctness": "warn"
},
"rules": {
"import/no-cycle": ["error", { "maxDepth": 1, "ignoreExternal": true }],
"import/no-cycle": ["warn", { "maxDepth": 1, "ignoreExternal": true }],
"typescript/no-explicit-any": "warn",
"typescript/ban-ts-comment": "off"
},
Expand Down
6 changes: 3 additions & 3 deletions ui/app/workspace/dashboard/components/charts/chartCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,16 @@ interface ChartCardProps {
export function ChartCard({ title, children, headerActions, loading, testId, height = "200px", className }: ChartCardProps) {
if (loading) {
return (
<Card className="min-w-0 rounded-sm p-2 shadow-none" data-testid={testId}>
<div className="mb-3 space-y-2">
<Card className={cn("min-w-0 rounded-sm p-2 shadow-none", className)} data-testid={testId}>
<div className="mb-2 space-y-2">
<span className="text-primary pl-2 text-sm font-medium">{title}</span>
{headerActions && (
<div className="w-full min-w-0" data-testid={testId ? `${testId}-actions` : undefined}>
{headerActions}
</div>
)}
</div>
<div style={{ height, marginBottom: 6 }} data-testid={testId ? `${testId}-chart-skeleton` : undefined}>
<div style={{ height }} data-testid={testId ? `${testId}-chart-skeleton` : undefined}>
<Skeleton className="h-full w-full" />
</div>
</Card>
Expand Down
Loading
Loading