removes prerelease tag from helm chart by akshaydeo · Pull Request #2739 · maximhq/bifrost

akshaydeo · 2026-04-15T16:19:26Z

Summary

Release Bifrost Helm chart version 2.1.1 with improved virtual key configuration flexibility. The value field for virtual keys is now optional, allowing the backend to auto-generate virtual key values when not explicitly provided.

Changes

Made bifrost.governance.virtualKeys[].value field optional in Helm templates
Updated template logic to conditionally include the value field only when present
Removed validation that previously required the value field to be set
Updated documentation and examples to reflect the optional nature of the field
Bumped chart version from 2.1.0-prerelease2 to 2.1.1

Type of change

Affected areas

How to test

Deploy the Helm chart with virtual keys configured both with and without the value field:

# Test with explicit value
helm install bifrost ./helm-charts/bifrost --set bifrost.governance.virtualKeys[0].id=vk-1 --set bifrost.governance.virtualKeys[0].name="Test Key" --set bifrost.governance.virtualKeys[0].value="vk-explicit-123"

# Test with auto-generated value (omit value field)
helm install bifrost ./helm-charts/bifrost --set bifrost.governance.virtualKeys[0].id=vk-2 --set bifrost.governance.virtualKeys[0].name="Auto Key"

# Verify the rendered config.json includes/omits the value field appropriately
helm template bifrost ./helm-charts/bifrost --values test-values.yaml

Screenshots/Recordings

N/A

Breaking changes

Yes
No

This change is backward compatible - existing configurations with explicit value fields will continue to work unchanged.

Related issues

N/A

Security considerations

Auto-generated virtual key values should be cryptographically secure and generated by the backend service. The Helm chart no longer enforces explicit key values, delegating this responsibility to the application.

Checklist

I read docs/contributing/README.md and followed the guidelines
I added/updated tests where appropriate
I updated documentation where needed
I verified builds succeed (Go and UI)
I verified the CI pipeline passes locally if applicable

coderabbitai · 2026-04-15T16:19:35Z

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 23283d2b-5daa-4819-a487-b69ee94f9105

📥 Commits

Reviewing files that changed from the base of the PR and between 12e443b and 1473e1c.

📒 Files selected for processing (5)

helm-charts/bifrost/Chart.yaml
helm-charts/bifrost/README.md
helm-charts/bifrost/templates/_helpers.tpl
helm-charts/bifrost/values.yaml
helm-charts/index.yaml

📝 Walkthrough

Summary by CodeRabbit

New Features
- Virtual key configuration value field is now optional; when omitted, it will be auto-generated in the rendered output.
Documentation
- Updated Helm chart documentation for version 2.1.1.
Chores
- Helm chart version bumped to 2.1.1.

Walkthrough

This PR releases Helm chart version 2.1.1 with a behavioral change to governance virtual keys. The value field is now optional; when omitted, the rendered configuration excludes it entirely. Version metadata and documentation were updated accordingly.

Changes

Cohort / File(s)	Summary
Version and Release Metadata `helm-charts/bifrost/Chart.yaml`, `helm-charts/index.yaml`	Bumped chart version from `2.1.0-prerelease2` to `2.1.1`; added new chart entry to Helm index and updated generated timestamp.
Documentation `helm-charts/bifrost/README.md`	Updated documented version to `2.1.1` and added changelog entry describing governance virtual keys `value` field as optional with auto-omission behavior.
Template Logic `helm-charts/bifrost/templates/_helpers.tpl`	Modified virtual key helper to construct objects with only `id` and `name` by default, conditionally including `value` only when provided. Removed hard validation requirement for `value` field.
Configuration Documentation `helm-charts/bifrost/values.yaml`	Added clarifying comment indicating the `value` field in `bifrost.governance.virtualKeys` is optional and will be auto-generated if omitted.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 A version release takes the stage so bright,
Where governance keys dance free from old might,
Optional values now flow with ease,
No more demands—just gentle pleas,
V2.1.1 hops forth with glee! 🌱

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch 04-15-removes_prerelease_tag_from_helm_chart

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

CLAassistant · 2026-04-15T16:19:39Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

akshaydeo · 2026-04-15T16:19:40Z

removes prerelease tag from helm chart #2739 👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

akshaydeo · 2026-04-15T16:20:02Z

Merge activity

Apr 15, 4:20 PM UTC: A user started a stack merge that includes this pull request via Graphite.
Apr 15, 4:20 PM UTC: @akshaydeo merged this pull request with Graphite.

github-actions · 2026-04-15T16:20:11Z

🧪 Test Suite Available

This PR can be tested by a repository admin.

Run tests for PR #2739

greptile-apps · 2026-04-15T16:22:38Z

Confidence Score: 5/5

Safe to merge — the change is minimal, backward-compatible, and the template logic is correct.

All findings are P2 style suggestions (truthiness vs. existence check for value, pre-existing empty digests in index.yaml). There are no logic bugs, data-loss risks, or security concerns introduced by this PR. The core template change is clean and the validation removal is consistent with the schema, which already only required id and name.

No files require special attention.

Important Files Changed

Filename	Overview
helm-charts/bifrost/templates/_helpers.tpl	Conditionally renders `value` field for virtual keys using `{{- if .value }}` and removes the no-longer-needed validation requiring it; logic is correct for the intended use case.
helm-charts/bifrost/Chart.yaml	Version bumped from `2.1.0-prerelease2` to `2.1.1`; straightforward and consistent with the stable release intent.
helm-charts/bifrost/values.yaml	Comment on `virtualKeys[].value` updated to note it is optional; no functional change.
helm-charts/index.yaml	New `2.1.1` entry added; `digest` is empty (consistent with recent entries), but integrity verification won't work for Helm repo clients that check digests.
helm-charts/bifrost/README.md	Changelog updated with accurate description of the `value` field becoming optional in v2.1.1.

_{Reviews (1): Last reviewed commit: "removes prerelease tag from helm chart" | Re-trigger Greptile}

greptile-apps · 2026-04-15T16:22:42Z

 {{- range .Values.bifrost.governance.virtualKeys }}
-{{- $vk := dict "id" .id "name" .name "value" .value }}
+{{- $vk := dict "id" .id "name" .name }}
+{{- if .value }}{{- $_ := set $vk "value" .value }}{{- end }}


Truthiness vs. existence check for value

{{- if .value }} is falsy for any empty string, so a user who explicitly sets value: "" in their values.yaml will silently have the field omitted rather than passed to the backend. Using hasKey is a more precise guard if the intent is "omit only when the key is absent":

Suggested change

{{- if .value }}{{- $_ := set $vk "value" .value }}{{- end }}

{{- if hasKey . "value" }}{{- $_ := set $vk "value" .value }}{{- end }}

For this specific field an empty string and an absent key have the same practical effect (backend auto-generates), so the current behaviour is acceptable — this is a minor suggestion for semantic clarity.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

greptile-apps · 2026-04-15T16:22:43Z

+    created: "2026-04-15T18:00:00.000000+00:00"
+    description: A Helm chart for deploying Bifrost - AI Gateway with unified interface for multiple providers
+    digest: ""
+    home: https://www.getmaxim.ai/bifrost


Empty digest in index.yaml

The digest field for the new 2.1.1 entry (and several preceding entries) is an empty string. Helm repo clients use this SHA256 hash to verify the downloaded .tgz archive's integrity — leaving it blank disables that check. This is consistent with how the chart has been published since v1.4.1, so it isn't a regression introduced here, but it is worth regenerating index.yaml via helm repo index --merge against the real packaged tarballs so the digest field is populated correctly going forward.

removes prerelease tag from helm chart

1473e1c

akshaydeo marked this pull request as ready for review April 15, 2026 16:19

akshaydeo requested a review from a team as a code owner April 15, 2026 16:19

akshaydeo merged commit e7ef535 into main Apr 15, 2026
12 of 17 checks passed

akshaydeo deleted the 04-15-removes_prerelease_tag_from_helm_chart branch April 15, 2026 16:20

greptile-apps Bot reviewed Apr 15, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

removes prerelease tag from helm chart#2739

removes prerelease tag from helm chart#2739
akshaydeo merged 1 commit intomainfrom
04-15-removes_prerelease_tag_from_helm_chart

akshaydeo commented Apr 15, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Apr 15, 2026 •

edited

Loading

Review failed

Summary by CodeRabbit

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

CLAassistant commented Apr 15, 2026

Uh oh!

akshaydeo commented Apr 15, 2026

Uh oh!

akshaydeo commented Apr 15, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 15, 2026

Uh oh!

Uh oh!

greptile-apps Bot commented Apr 15, 2026

Uh oh!

greptile-apps Bot Apr 15, 2026

Uh oh!

greptile-apps Bot Apr 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	{{- if .value }}{{- $_ := set $vk "value" .value }}{{- end }}
	{{- if hasKey . "value" }}{{- $_ := set $vk "value" .value }}{{- end }}

Conversation

akshaydeo commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Type of change

Affected areas

How to test

Screenshots/Recordings

Breaking changes

Related issues

Security considerations

Checklist

Uh oh!

coderabbitai Bot commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Summary by CodeRabbit

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

CLAassistant commented Apr 15, 2026

Uh oh!

akshaydeo commented Apr 15, 2026

Uh oh!

akshaydeo commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

github-actions Bot commented Apr 15, 2026

🧪 Test Suite Available

Uh oh!

Uh oh!

greptile-apps Bot commented Apr 15, 2026

Confidence Score: 5/5

Important Files Changed

Uh oh!

greptile-apps Bot Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

akshaydeo commented Apr 15, 2026 •

edited

Loading

coderabbitai Bot commented Apr 15, 2026 •

edited

Loading

akshaydeo commented Apr 15, 2026 •

edited

Loading