Skip to content

fixed validation checks#2737

Merged
akshaydeo merged 1 commit intomainfrom
04-15-fixed_validation_checks
Apr 15, 2026
Merged

fixed validation checks#2737
akshaydeo merged 1 commit intomainfrom
04-15-fixed_validation_checks

Conversation

@akshaydeo
Copy link
Copy Markdown
Contributor

@akshaydeo akshaydeo commented Apr 15, 2026

Summary

Updates the OpenTelemetry trace type configuration in Helm template validation tests from otel to genai_extension to align with the new trace type naming convention.

Changes

  • Changed bifrost.plugins.otel.config.trace_type value from otel to genai_extension in two test scenarios
  • Updated both the standalone OTEL test and the combined configuration test to use the new trace type

Type of change

  • Bug fix
  • Feature
  • Refactor
  • Documentation
  • Chore/CI

Affected areas

  • Core (Go)
  • Transports (HTTP)
  • Providers/Integrations
  • Plugins
  • UI (Next.js)
  • Docs

How to test

Run the Helm template validation script to ensure the tests pass with the updated trace type configuration:

./.github/workflows/scripts/validate-helm-templates.sh

Verify that the OTEL plugin configuration accepts the genai_extension trace type and that Helm charts render correctly with this setting.

Screenshots/Recordings

N/A

Breaking changes

  • Yes
  • No

Related issues

N/A

Security considerations

No security implications - this is a configuration value update in test scripts.

Checklist

  • I read docs/contributing/README.md and followed the guidelines
  • I added/updated tests where appropriate
  • I updated documentation where needed
  • I verified builds succeed (Go and UI)
  • I verified the CI pipeline passes locally if applicable

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 15, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ab0a739a-f8be-422d-a083-d7c89375c266

📥 Commits

Reviewing files that changed from the base of the PR and between f2005ef and 95fc263.

📒 Files selected for processing (1)
  • .github/workflows/scripts/validate-helm-templates.sh

📝 Walkthrough

Summary by CodeRabbit

  • Tests
    • Updated Helm template validation test configurations for the OpenTelemetry plugin, adjusting parameters in two test scenarios.

Walkthrough

The Helm template validation script for the OpenTelemetry plugin was updated to change the trace type parameter from otel to genai_extension in two test cases, affecting the test configuration inputs for validation scenarios.

Changes

Cohort / File(s) Summary
Helm Template Validation
.github/workflows/scripts/validate-helm-templates.sh
Updated bifrost.plugins.otel.config.trace_type parameter from otel to genai_extension in two test cases: "otel: headers + tls_ca_cert + insecure (Gap 3)" and "combined: all new Gap 1-8 fields".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A tweak so small, yet oh so neat,
The trace type changed, validation's sweet,
From otel to genai_extension true,
Two test cases polished, spick and span anew!

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 04-15-fixed_validation_checks

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@akshaydeo akshaydeo marked this pull request as ready for review April 15, 2026 14:29
@akshaydeo akshaydeo requested a review from a team as a code owner April 15, 2026 14:29
@akshaydeo akshaydeo merged commit 132b0d4 into main Apr 15, 2026
10 of 14 checks passed
@akshaydeo akshaydeo deleted the 04-15-fixed_validation_checks branch April 15, 2026 14:30
@github-actions
Copy link
Copy Markdown
Contributor

🧪 Test Suite Available

This PR can be tested by a repository admin.

Run tests for PR #2737

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 15, 2026

Confidence Score: 5/5

Safe to merge — corrects an invalid enum value in test configuration with no production code changes.

Change is a one-line correction in two test scenarios, aligning the test value with the schema-enforced enum and Go constants. No logic, security, or behavioral risk.

No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/scripts/validate-helm-templates.sh Updates trace_type from otel to genai_extension in two test scenarios to match the valid enum values defined in values.schema.json and the TraceType constants in plugins/otel/main.go.

Reviews (1): Last reviewed commit: "fixed validation checks" | Re-trigger Greptile

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants