Conversation
|
|
🧪 Test Suite AvailableThis PR can be tested by a repository admin. |
📝 WalkthroughWalkthroughThis pull request upgrades the Bifrost Helm chart from version 2.0.18 to 2.1.0-prerelease2, introducing new configuration options for object storage support, MCP client secret handling via Kubernetes secrets, SCIM identity provider migration, encryption key secrets, and expanded governance pricing overrides. The schema and templates are updated to support these new features. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 3❌ Failed checks (2 warnings, 1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsTimed out fetching pipeline failures after 30000ms Comment |
Confidence Score: 3/5The schema changes are correct but the template rendering was not updated to match, meaning the advertised calendar_aligned feature is broken and stale budget_id may cause startup failures. Two P1 bugs in _helpers.tpl: calendar_aligned silently dropped from rendered virtual key config, and budget_id still emitted despite being removed from the schema. These directly affect the correctness of the generated config.json for users relying on the new feature. helm-charts/bifrost/templates/_helpers.tpl (virtual key rendering loop, lines 354–368) Important Files Changed
|

Summary
Bumps Bifrost Helm chart to version 2.1.0-prerelease2 with schema synchronization and configuration improvements. This release aligns the Helm values schema with the transport config schema, fixing virtual key and budget configuration drift while adding support for new features like object storage and WebSocket tuning.
Changes
values.schema.jsonand transportconfig.schema.jsonrequired: [mcp_client_id]constraint on virtual key MCP configsmcp_client_nameas alternative tomcp_client_idfor config-file formatcalendar_alignedfrom budget level to virtual key levelbudget_idfield from virtual keysenableLitellmFallbackswith structuredcompatconfiguration_helpers.tplwith better property mapping and validationType of change
Affected areas
How to test
Validate the Helm chart upgrade and new configurations:
New configurations added:
storage.logsStore.objectStorage.*- Object storage for log payloadsbifrost.websocket.*- WebSocket gateway tuningbifrost.client.compat.*- Client compatibility settingsbifrost.mcp.clientConfigs[].secretRef- MCP connection string secretsBreaking changes
Impact: The
enableLitellmFallbacksclient configuration has been replaced with a structuredcompatobject. Users with existing configurations need to migrate:Migration:
Related issues
Part of ongoing Helm chart maintenance and schema alignment efforts.
Security considerations
existingSecretreferencesenv.prefixChecklist
docs/contributing/README.mdand followed the guidelines