-
Notifications
You must be signed in to change notification settings - Fork 557
main -> v1.5.0 backmerge #2732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
main -> v1.5.0 backmerge #2732
Changes from all commits
a8cf690
79a1ab4
8f84688
663ded6
588e975
188fc0e
1bda46a
67938e2
b423d7d
5d3b34b
1efbfcd
f2005ef
132b0d4
254e41e
12e443b
e7ef535
15b67f2
56c3cb4
32138be
f76f600
aa360ca
b9efa11
6d6b554
6d0e64f
83599a2
ca5174e
fce84de
896f571
61e8079
594b508
3ed64a6
18427ac
16896bd
8c11869
ce62c64
d1d1004
19a4473
0485a49
a80bb41
9c00d7b
f75d607
72ecaca
c4a191d
c907a4d
304d547
12c68f3
9dc2478
3e0dd03
485810b
0ac9518
bfe8360
f962154
314f13f
dd36ff0
aec4b7e
cbfa4f4
40737ff
adc31bc
67340ad
b31cc3a
67319e5
be3edf3
1e79b19
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,16 +10,26 @@ | |
| workflow_dispatch: | ||
|
|
||
| permissions: | ||
| contents: write | ||
| contents: write | ||
Check failureCode scanning / Scorecard Token-Permissions High
score is 0: topLevel 'contents' permission set to 'write'
Remediation tip: Visit https://app.stepsecurity.io/secureworkflow. Tick the 'Restrict permissions for GITHUB_TOKEN' Untick other options NOTE: If you want to resolve multiple issues at once, you can visit https://app.stepsecurity.io/securerepo instead. Click Remediation section below for further remediation help |
||
|
|
||
| jobs: | ||
| release: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Harden the runner (Audit all outbound calls) | ||
| - name: Harden Runner | ||
| uses: step-security/harden-runner@fa2e9d605c4eeb9fcad4c99c224cee0c6c7f3594 # v2.16.0 | ||
| with: | ||
| egress-policy: audit | ||
| egress-policy: block | ||
| allowed-endpoints: > | ||
| api.github.com:443 | ||
| get.helm.sh:443 | ||
| github.com:443 | ||
| maximhq.github.io:443 | ||
| proxy.golang.org:443 | ||
| release-assets.githubusercontent.com:443 | ||
| storage.googleapis.com:443 | ||
| sum.golang.org:443 | ||
| uploads.github.com:443 | ||
|
|
||
| - name: Checkout | ||
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,7 +4,7 @@ on: | |
| push: | ||
| branches: | ||
| - main | ||
|
|
||
| # Prevent concurrent runs | ||
| concurrency: | ||
| group: release-cli | ||
|
|
@@ -20,10 +20,12 @@ jobs: | |
| version: ${{ steps.get-version.outputs.version }} | ||
| tag_exists: ${{ steps.check-tag.outputs.exists }} | ||
| steps: | ||
| - name: Harden the runner (Audit all outbound calls) | ||
| - name: Harden Runner | ||
| uses: step-security/harden-runner@fa2e9d605c4eeb9fcad4c99c224cee0c6c7f3594 # v2.16.0 | ||
| with: | ||
| egress-policy: audit | ||
| egress-policy: block | ||
| allowed-endpoints: > | ||
| github.com:443 | ||
|
Comment on lines
+23
to
+28
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
rg -n 'egress-policy:\s*(audit|block)' .github/workflows/release-cli.ymlRepository: maximhq/bifrost Length of output: 195 🏁 Script executed: sed -n '50,65p' .github/workflows/release-cli.ymlRepository: maximhq/bifrost Length of output: 598 🏁 Script executed: sed -n '80,95p' .github/workflows/release-cli.ymlRepository: maximhq/bifrost Length of output: 593 🏁 Script executed: sed -n '120,130p' .github/workflows/release-cli.ymlRepository: maximhq/bifrost Length of output: 448 🏁 Script executed: rg -n 'GH_TOKEN|secrets\.R2' .github/workflows/release-cli.ymlRepository: maximhq/bifrost Length of output: 435 Egress blocking only applied to the lowest-privilege job. Lines 59, 88, and 127 still run with 🤖 Prompt for AI Agents |
||
|
|
||
| - name: Checkout repository | ||
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
|
|
@@ -65,7 +67,7 @@ jobs: | |
| - name: Set up Go | ||
| uses: actions/setup-go@4b73464bb391d4059bd26b0524d20df3927bd417 # v6.3.0 | ||
| with: | ||
| go-version: "1.26.2" | ||
| go-version: "1.26.1" | ||
|
|
||
| - name: Run CLI tests | ||
| working-directory: cli | ||
|
|
@@ -95,7 +97,7 @@ jobs: | |
| - name: Set up Go | ||
| uses: actions/setup-go@4b73464bb391d4059bd26b0524d20df3927bd417 # v6.3.0 | ||
| with: | ||
| go-version: "1.26.2" | ||
| go-version: "1.26.1" | ||
|
|
||
| - name: Configure Git | ||
| run: | | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: maximhq/bifrost
Length of output: 2436
🌐 Web query:
GitHub REST API Dependabot alerts endpoint permission requirements security-events💡 Result:
The GitHub REST API endpoints for Dependabot alerts (under /repos/{owner}/{repo}/dependabot/alerts and related paths) require the security_events scope for OAuth apps and personal access tokens (classic). For public repositories only, the public_repo scope is sufficient instead. Users must have appropriate repository permissions, such as access to security alerts (e.g., repository owners, security managers, or those granted access via "Granting access to security alerts"). This applies consistently across list, get, update, and related operations like dismissal requests.
Citations:
Add the missing read permission for Dependabot alerts.
The
gh apicall on line 26 reads repository Dependabot alerts, but this workflow only grantsissues: write. The Dependabot alerts API requires thesecurity-eventsscope. Without it, the API call will fail with a 403 error before the issue-creation loop runs.Suggested fix
permissions: + security-events: read issues: write🤖 Prompt for AI Agents