Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (10)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis pull request updates documentation and OpenAPI schemas across multiple areas: it replaces Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
|
🧪 Test Suite AvailableThis PR can be tested by a repository admin. |
Confidence Score: 5/5Safe to merge; all findings are minor style/completeness suggestions with no impact on correctness. All four comments are P2 (style, missing newline, wording, and a missing doc entry for a schema field). None affect correctness or user-facing behavior. docs/enterprise/setting-up-okta.mdx and docs/features/litellm-compat.mdx have minor style issues. Important Files Changed
Reviews (1): Last reviewed commit: "docs updates" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
|
|
||
| #### Option B: Using Authorization Server Groups Claim | ||
|
|
||
| This approach adds the groups claim through your authorization server, providing more flexibility for complex configurations. |
There was a problem hiding this comment.
After removing Option A / Option B, the opening sentence "This approach adds the groups claim through your authorization server…" has no referent. Readers arriving at this section for the first time won't know what "this approach" means relative to any alternative.
| This approach adds the groups claim through your authorization server, providing more flexibility for complex configurations. | |
| Configure the groups claim through your authorization server, which supports flexible configurations and works across Okta plans. |
| - Ensure you have created all the [roles in Bifrost](/enterprise/rbac) that you are aiming to map to with Okta. | ||
| --- |
There was a problem hiding this comment.
The new prerequisite bullet is immediately followed by --- with no blank line. Some Markdown parsers may render --- as a heading underline (<h2>) for the preceding list item rather than a <hr>.
| - Ensure you have created all the [roles in Bifrost](/enterprise/rbac) that you are aiming to map to with Okta. | |
| --- | |
| - Ensure you have created all the [roles in Bifrost](/enterprise/rbac) that you are aiming to map to with Okta. | |
| --- |
| - [Fallbacks](/features/fallbacks) - Automatic provider failover | ||
| - [Drop-in Replacement](/features/drop-in-replacement) - Use existing SDKs with Bifrost | ||
| - [LiteLLM Integration](/integrations/litellm-sdk) - Using LiteLLM SDK with Bifrost | ||
| - [LiteLLM Integration](/integrations/litellm-sdk) - Using LiteLLM SDK with Bifrost No newline at end of file |
There was a problem hiding this comment.
The diff shows \ No newline at end of file. Most linters and editors expect a trailing newline.
| - [LiteLLM Integration](/integrations/litellm-sdk) - Using LiteLLM SDK with Bifrost | |
| - [LiteLLM Integration](/integrations/litellm-sdk) - Using LiteLLM SDK with Bifrost |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
| ```json | ||
| { | ||
| "client_config": { | ||
| "enable_litellm_fallbacks": true | ||
| "compat": { | ||
| "convert_text_to_chat": true, | ||
| "convert_chat_to_responses": true, | ||
| "should_drop_params": true | ||
| } | ||
| } | ||
| } | ||
| ``` |
There was a problem hiding this comment.
should_convert_params not documented
The OpenAPI schema (config.yaml) adds a fourth compat field — should_convert_params — but the JSON config example here and the UI step list only cover three options (convert_text_to_chat, convert_chat_to_responses, should_drop_params). Users who discover the schema field directly won't know what it does or when to enable it.
2 participants
Summary
This PR adds v1.5.0-prerelease3 release documentation and updates the LiteLLM compatibility plugin to support chat-to-responses conversion and parameter dropping functionality.
Changes
ReloadPricing→UpdateSyncConfig)Type of change
Affected areas
How to test
Validate the LiteLLM compatibility enhancements:
Test the model catalog API update:
Breaking changes
The LiteLLM compatibility configuration structure has been updated from a simple boolean to an object with granular controls, but this maintains backward compatibility.
Related issues
Part of the v1.5.0-prerelease3 release cycle with enhanced LiteLLM compatibility and pricing model improvements.
Security considerations
The Okta setup guide includes improved instructions for secure role mapping and API token creation for user provisioning.
Checklist
docs/contributing/README.mdand followed the guidelines