Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis pull request includes four heterogeneous changes: extending the Go workspace setup script to include two additional modules ( Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
|
Merge activity
|
Confidence Score: 5/5Safe to merge; only one P2 style finding in the shell script guard. All four changes are correct and well-scoped. The replicate nil-check is properly targeted to the one code path (
|
| Filename | Overview |
|---|---|
| .github/workflows/scripts/setup-go-workspace.sh | Adds ./plugins/prompts and ./cli to the Go workspace; first go.work guard uses a bare return that fails when the script is executed directly instead of sourced. |
| core/providers/replicate/replicate.go | Adds a nil guard for ReplicateKeyConfig in listDeploymentsByKey, which is called by ListModels over all keys (including those without ReplicateKeyConfig). Other methods are safe because they receive pre-validated keys. |
| framework/configstore/migrations_test.go | Updates migration table name from gomigrate to migrations to match migrator defaults; test helpers and SQL DDL are consistent with the production migration code. |
| transports/config.schema.json | Adds routing_chain_max_depth (integer, min 1, default 10) to the transport schema; calendar_aligned remains in the virtual-key section (consistent with governance.go) and appears to have been removed only from the budget-level schema. |
Comments Outside Diff (1)
-
.github/workflows/scripts/setup-go-workspace.sh, line 9 (link)Bare
returnwill fail when script is executed directlyThe first early-exit guard uses a plain
return(line 9), but the second guard (line 18) correctly usesreturn 0 2>/dev/null || exit 0. Withset -euo pipefailactive, if someone runs the script directly (bash setup-go-workspace.sh) andgo.workalready exists, the barereturnexits with code 1 and the error message is printed to stderr. The first guard is also entirely redundant — the second guard (lines 16-19) already covers the same condition more robustly. Consider removing lines 7-10 entirely.
Reviews (1): Last reviewed commit: "test fixes" | Re-trigger Greptile

Summary
This PR adds new workspace modules to the Go workspace configuration, fixes a null pointer dereference in the Replicate provider, updates migration table naming for consistency, and adjusts transport configuration schema.
Changes
./plugins/promptsand./climodules to the Go workspace setup scriptReplicateKeyConfiggomigratetomigrationsin test setup functions and comments to match migrator defaultsrouting_chain_max_depthconfiguration option to transport schema with default value of 10calendar_alignedfield from budget configuration schemaType of change
Affected areas
How to test
Validate the workspace setup and provider functionality:
Test the new routing chain configuration by setting
routing_chain_max_depthin your transport config and verifying it's respected during routing rule evaluation.Screenshots/Recordings
N/A
Breaking changes
Related issues
N/A
Security considerations
The routing chain max depth limit helps prevent potential infinite loops or excessive recursion in routing rule evaluation.
Checklist
docs/contributing/README.mdand followed the guidelines