refactor: Extracts routing utilites to a separate package

[roroghost17]

Summary

Extracted routing-related CEL (Common Expression Language) functionality into a dedicated framework package to improve code organization and reusability. This refactoring moves CEL environment creation, expression validation, and map key normalization functions from the governance plugin to a shared routing framework.

Changes

• Created new framework/routing/routing.go package with exported functions for CEL operations
• Moved createCELEnvironment, validateCELExpression, and normalizeMapKeysInCEL functions from governance plugin to routing framework
• Updated governance plugin to import and use the new routing framework functions
• Modified test files to reference the new exported functions from the routing package
• Removed duplicate regex patterns and function definitions from governance plugin

Type of change

• Refactor
• Bug fix
• Feature
• Documentation
• Chore/CI

Affected areas

• Core (Go)
• Plugins
• Transports (HTTP)
• Providers/Integrations
• UI (Next.js)
• Docs

How to test

Validate that the refactoring maintains existing functionality by running the test suite:

# Core/Transports
go version
go test ./...

# Specifically test the affected areas
go test ./framework/routing/...
go test ./plugins/governance/...

Screenshots/Recordings

N/A - This is a code refactoring with no UI changes.

Breaking changes

• Yes
• No

This is an internal refactoring that maintains the same public API and functionality.

Related issues

N/A

Security considerations

No security implications - this is a code organization refactoring that maintains the same CEL expression validation and normalization logic.

Checklist

• I read docs/contributing/README.md and followed the guidelines
• I added/updated tests where appropriate
• I updated documentation where needed
• I verified builds succeed (Go and UI)
• I verified the CI pipeline passes locally if applicable

[coderabbitai]

📝 Walkthrough

Summary by CodeRabbit

• Refactor

  • Centralized CEL expression normalization and validation moved into a shared framework layer for consistent handling across routing and governance, removing duplicated local helpers.

• Behavior

  • Normalization now canonicalizes header and parameter keys for case-insensitive matching.
  • Validation accepts empty expressions and the literals "true"/"false" and requires at least one operator/token fragment.

• Tests

  • Tests updated to use the centralized utilities.

Walkthrough

Adds package framework/routing with two exported functions: NormalizeMapKeysInCEL (lowercases quoted headers/params keys in CEL expressions) and ValidateCELExpression (lightweight operator/keyword presence check). Governance plugin helpers were removed and call sites updated to use the new routing utilities.

Changes

Cohort / File(s)	Summary
Framework Routing Module framework/routing/routing.go	New file exporting NormalizeMapKeysInCEL(expr string) string and ValidateCELExpression(expr string) error. Implements regex-driven lowercasing for quoted headers/params keys and a simple validation that checks for operator/keyword fragments or accepts empty/true/false.
Governance Plugin — Call sites plugins/governance/store.go, plugins/governance/routing_test.go	Replaced local CEL preprocessing/validation calls with routing.NormalizeMapKeysInCEL and routing.ValidateCELExpression; tests updated to import framework/routing.
Governance Plugin — Removed helpers plugins/governance/routing.go	Removed local regex variables and helper functions that previously normalized/validated CEL expressions; runtime lowercasing of extracted headers/params remains in extractRoutingVariables.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐇 I nudged the keys to lowercase, quick and bright,
Shared helpers hopped in, keeping logic light,
Expressions checked for operators, trimmed with care,
Tests followed the trail and found them waiting there,
A rabbit's little tweak — tidy, neat, and right.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main refactoring objective: extracting routing utilities to a separate package, which is clearly reflected in the code changes moving CEL functions from governance plugin to framework/routing package.
Description check	✅ Passed	The description comprehensively covers all required template sections: summary explaining the purpose, detailed changes listing what was moved, type of change (refactor) checked, affected areas marked (Core/Go and Plugins), testing instructions provided, breaking changes clearly stated as none, and security considerations documented.
Docstring Coverage	✅ Passed	Docstring coverage is 80.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch 04-07-refactor_extracts_routing_utilites_to_a_separate_package

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[roroghost17]

• docs: updates docs for prompts plugin #2763
• feat: wires prompt plugin selections into logs view #2592
• refactor: updates prompt model parameters UI #2548
• feat: updates prompts plugin flow #2545
• refactor: Extracts routing utilites to a separate package #2544 👈 (View in Graphite)
• feat: add prompt deployment view to settings panel with updated styling #2352
• refactor: deleted subpages from the prompt repo #2327
• refactor: extract CEL rule builder into reusable component and add menu portal support #2237 : 1 other dependent PR (#2234 )
• feat: add variables support to prompt sessions and versions with database migration #2154
• feat: add variables support to prompt sessions and versions with persistence #2134
• v1.5.0

This stack of pull requests is managed by Graphite. Learn more about stacking.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[greptile-apps]

Confidence Score: 5/5

Safe to merge — all extracted functions are pure string utilities, the governance plugin compiles and behaves identically to before, and the only finding is a documentation mismatch in the PR description.

All remaining findings are P2: the implementation is functionally correct, the two extracted functions are pure string utilities with no side effects, and createCELEnvironment still resides and works correctly in the governance plugin.

No files require special attention; the discrepancy is in the PR description, not the code.

Important Files Changed

Filename	Overview
framework/routing/routing.go	New package exporting NormalizeMapKeysInCEL and ValidateCELExpression; correctly avoids importing cel-go, keeping the framework dependency-light.
plugins/governance/routing.go	createCELEnvironment remains here as a private function; store.go still calls it locally. Functionally correct; the function was not extracted as the PR description states.
plugins/governance/routing_test.go	Updated to use routing.ValidateCELExpression and routing.NormalizeMapKeysInCEL; TestCreateCELEnvironment constructs an env with different variables (rate_limit/budget maps) than the actual createCELEnvironment() function uses, but this appears to be a pre-existing discrepancy.
plugins/governance/store.go	Now delegates NormalizeMapKeysInCEL and ValidateCELExpression calls to the framework/routing package; createCELEnvironment is still called locally and correctly initialises routingCELEnv at store construction time.

_{Reviews (10): Last reviewed commit: "refactor: Extracts routing utilites to a..." | Re-trigger Greptile}

[roroghost17]

@CodeRabbit-ai full review

[coderabbitai]

@roroghost17 Sure! I'll redo the full review of the changes in this PR now.

✅ Actions performed

Full review triggered.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@framework/routing/routing.go`:
- Around line 30-34: The regex replacements on expr using headerKeyPattern,
paramKeyPattern, headerInPattern and paramInPattern can mutate quoted CEL string
literals; change the normalization to be token-aware by first scanning expr and
skipping any text inside quoted string tokens (single and double quotes, with
escape handling) before applying ReplaceAllStringFunc, or alternatively parse
into CEL AST/tokens and apply the key-lowering only to identifier/map-key lookup
nodes; ensure headerKeyPattern, paramKeyPattern, headerInPattern and
paramInPattern are only applied to regions outside quoted strings so expressions
like model == "headers['X-Tier']" are left unchanged.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ff6ebcbb-8e0f-4675-9cf7-d83bb1c198a2

📥 Commits

Reviewing files that changed from the base of the PR and between 6896ceb and 4416453.

📒 Files selected for processing (4)

• framework/routing/routing.go
• plugins/governance/routing.go
• plugins/governance/routing_test.go
• plugins/governance/store.go

💤 Files with no reviewable changes (1)

• plugins/governance/routing.go

[coderabbitai]

♻️ Duplicate comments (1)

framework/routing/routing.go (1)

10-20: ⚠️ Potential issue | 🟡 Minor

Add identifier boundaries to map-name regexes.

These patterns still match headers/params as substrings of longer identifiers (e.g., xheaders["K"], "k" in headersMap), which can rewrite unrelated symbols.

Suggested patch

-var headerKeyPattern = regexp.MustCompile(`headers\[["']([^"']+)["']\]`)
+var headerKeyPattern = regexp.MustCompile(`\bheaders\[["']([^"']+)["']\]`)

-var headerInPattern = regexp.MustCompile(`["']([^"']+)["']\s+in\s+headers`)
+var headerInPattern = regexp.MustCompile(`["']([^"']+)["']\s+in\s+\bheaders\b`)

-var paramKeyPattern = regexp.MustCompile(`params\[["']([^"']+)["']\]`)
+var paramKeyPattern = regexp.MustCompile(`\bparams\[["']([^"']+)["']\]`)

-var paramInPattern = regexp.MustCompile(`["']([^"']+)["']\s+in\s+params`)
+var paramInPattern = regexp.MustCompile(`["']([^"']+)["']\s+in\s+\bparams\b`)

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@framework/routing/routing.go` around lines 10 - 20, The existing regexes
headerKeyPattern, headerInPattern, paramKeyPattern and paramInPattern
incorrectly match when "headers" or "params" appear as substrings of longer
identifiers; update each pattern to require identifier boundaries around the map
name (e.g., use word-boundary or negative lookbehind/lookahead for identifier
chars so only standalone headers or params match) while preserving the captured
key group and the rest of the pattern; apply this change to all four vars so
rewrites only target true map access/membership like headers["X"] or "X" in
params.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Duplicate comments:
In `@framework/routing/routing.go`:
- Around line 10-20: The existing regexes headerKeyPattern, headerInPattern,
paramKeyPattern and paramInPattern incorrectly match when "headers" or "params"
appear as substrings of longer identifiers; update each pattern to require
identifier boundaries around the map name (e.g., use word-boundary or negative
lookbehind/lookahead for identifier chars so only standalone headers or params
match) while preserving the captured key group and the rest of the pattern;
apply this change to all four vars so rewrites only target true map
access/membership like headers["X"] or "X" in params.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6507a8b3-3bed-49fb-945e-e6aa4001d90b

📥 Commits

Reviewing files that changed from the base of the PR and between 0fb1cb5 and 2acff08.

📒 Files selected for processing (4)

• framework/routing/routing.go
• plugins/governance/routing.go
• plugins/governance/routing_test.go
• plugins/governance/store.go

💤 Files with no reviewable changes (1)

• plugins/governance/routing.go

✅ Files skipped from review due to trivial changes (2)

• plugins/governance/routing_test.go
• plugins/governance/store.go

[coderabbitai]

♻️ Duplicate comments (1)

framework/routing/routing.go (1)

10-20: ⚠️ Potential issue | 🟡 Minor

Add identifier boundaries to headers/params regex targets.

These patterns can still match substrings inside larger identifiers and rewrite unintended text. Constrain headers and params to identifier boundaries.

Suggested patch

-var headerKeyPattern = regexp.MustCompile(`headers\[["']([^"']+)["']\]`)
+var headerKeyPattern = regexp.MustCompile(`\bheaders\[["']([^"']+)["']\]`)

-var headerInPattern = regexp.MustCompile(`["']([^"']+)["']\s+in\s+headers`)
+var headerInPattern = regexp.MustCompile(`["']([^"']+)["']\s+in\s+\bheaders\b`)

-var paramKeyPattern = regexp.MustCompile(`params\[["']([^"']+)["']\]`)
+var paramKeyPattern = regexp.MustCompile(`\bparams\[["']([^"']+)["']\]`)

-var paramInPattern = regexp.MustCompile(`["']([^"']+)["']\s+in\s+params`)
+var paramInPattern = regexp.MustCompile(`["']([^"']+)["']\s+in\s+\bparams\b`)

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@framework/routing/routing.go` around lines 10 - 20, The regexes
headerKeyPattern, headerInPattern, paramKeyPattern, and paramInPattern are
currently matching "headers" and "params" inside larger identifiers; update each
pattern to require identifier boundaries around the target words (e.g., use
word-boundaries like \b around headers and params or equivalent
negative-lookbehind/lookahead) so that matches only occur on the standalone
identifiers (for example change occurrences of `headers\[` to `\bheaders\[` and
`in\s+headers` to `\bin\s+headers\b`, and similarly for `params`) while
preserving the existing capture groups for the key names.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Duplicate comments:
In `@framework/routing/routing.go`:
- Around line 10-20: The regexes headerKeyPattern, headerInPattern,
paramKeyPattern, and paramInPattern are currently matching "headers" and
"params" inside larger identifiers; update each pattern to require identifier
boundaries around the target words (e.g., use word-boundaries like \b around
headers and params or equivalent negative-lookbehind/lookahead) so that matches
only occur on the standalone identifiers (for example change occurrences of
`headers\[` to `\bheaders\[` and `in\s+headers` to `\bin\s+headers\b`, and
similarly for `params`) while preserving the existing capture groups for the key
names.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f44bba35-6e89-4aea-bc6e-707f3b104157

📥 Commits

Reviewing files that changed from the base of the PR and between d54ccca and dc92eb1.

📒 Files selected for processing (4)

• framework/routing/routing.go
• plugins/governance/routing.go
• plugins/governance/routing_test.go
• plugins/governance/store.go

💤 Files with no reviewable changes (1)

• plugins/governance/routing.go

✅ Files skipped from review due to trivial changes (1)

• plugins/governance/store.go

🚧 Files skipped from review as they are similar to previous changes (1)

• plugins/governance/routing_test.go

[coderabbitai]

♻️ Duplicate comments (1)

plugins/governance/store.go (1)

3449-3459: ⚠️ Potential issue | 🟡 Minor

Trim before empty-defaulting to keep validation and compile paths consistent.

routing.ValidateCELExpression trims internally, but Line [3450]-Line [3452] only treats exact "" as empty. Trimming once up front keeps whitespace-only expressions aligned with the same default "true" path.

Suggested patch

-	expr := rule.CelExpression
+	expr := strings.TrimSpace(rule.CelExpression)
 	if expr == "" {
 		expr = "true"
 	}

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@plugins/governance/store.go` around lines 3449 - 3459, Trim
rule.CelExpression into expr before checking for empty and before further
normalization/validation so whitespace-only expressions get the same default
"true" path; i.e., call strings.TrimSpace (or equivalent) on expr prior to the
empty check, then pass the trimmed expr into routing.NormalizeMapKeysInCEL and
routing.ValidateCELExpression to keep compile/validation behavior consistent for
rule.CelExpression.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Duplicate comments:
In `@plugins/governance/store.go`:
- Around line 3449-3459: Trim rule.CelExpression into expr before checking for
empty and before further normalization/validation so whitespace-only expressions
get the same default "true" path; i.e., call strings.TrimSpace (or equivalent)
on expr prior to the empty check, then pass the trimmed expr into
routing.NormalizeMapKeysInCEL and routing.ValidateCELExpression to keep
compile/validation behavior consistent for rule.CelExpression.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 814b03e3-d7af-4b70-9b4a-7845b4b3c3a5

📥 Commits

Reviewing files that changed from the base of the PR and between 6328594 and a9ceab4.

📒 Files selected for processing (4)

• framework/routing/routing.go
• plugins/governance/routing.go
• plugins/governance/routing_test.go
• plugins/governance/store.go

💤 Files with no reviewable changes (1)

• plugins/governance/routing.go

🚧 Files skipped from review as they are similar to previous changes (1)

• plugins/governance/routing_test.go

[akshaydeo]

Merge activity

• Apr 16, 4:34 PM UTC: A user started a stack merge that includes this pull request via Graphite.
• Apr 16, 4:39 PM UTC: @akshaydeo merged this pull request with Graphite.

The base branch was changed.