chore: standardize model allowlist configuration with wildcard default in all tests#2453
chore: standardize model allowlist configuration with wildcard default in all tests#2453
Conversation
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (39)
📝 WalkthroughWalkthroughThis PR standardizes provider/model/key allowlisting by replacing empty-model arrays with explicit wildcards ( Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Confidence Score: 4/5Safe to merge for the Go/config/test changes; the UI refactor has a P1 regression that silently clears OpenAI provider config on every save. One confirmed P1 bug in the UI layer: ui/app/workspace/providers/views/utils.ts and both fragment files that call it (openaiConfigFormFragment.tsx, betaHeadersFormFragment.tsx). Important Files Changed
|
205c4cb to
fb544d3
Compare
fb544d3 to
e6edc7b
Compare
e6edc7b to
cc3293a
Compare
Merge activity
|

Summary
This PR standardizes model access control by replacing empty model arrays with explicit wildcard notation (
["*"]) throughout the codebase. This change improves clarity and consistency in how "allow all models" is represented across configuration files, tests, and code.Changes
"models": ["*"]instead of empty arrays or missing model specificationsschemas.WhiteList{"*"}for unrestricted model accessallowed_modelsandkey_idsfields with["*"]values to provider configurations in governance testsbuildProviderUpdatePayloadutility functionType of change
Affected areas
How to test
Validate that existing functionality remains unchanged while using the new wildcard notation:
Verify that configurations with
["*"]model specifications work identically to previous empty array behavior.Screenshots/Recordings
N/A - This is a refactoring change with no visible UI modifications.
Breaking changes
This change maintains backward compatibility while establishing a clearer convention for model access control.
Related issues
N/A
Security considerations
This change improves security clarity by making model access permissions explicit rather than implicit through empty arrays.
Checklist
docs/contributing/README.mdand followed the guidelines