Skip to content

refactor: replace lazy query with polling query and fix overflow in log details sheet #2381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akshaydeo merged 1 commit into from
Mar 30, 2026
Merged

refactor: replace lazy query with polling query and fix overflow in log details sheet #2381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 15 additions & 13 deletions ui/app/workspace/logs/sheets/logDetailsSheet.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
"use client";

import { useEffect } from "react";
import { useEffect, useState } from "react";
import { useHotkeys } from "react-hotkeys-hook";
import { useLazyGetLogByIdQuery } from "@/lib/store/apis/logsApi";
import { useGetLogByIdQuery } from "@/lib/store/apis/logsApi";
import {
AlertDialog,
AlertDialogAction,
Expand Down Expand Up @@ -85,22 +85,24 @@ const isContainerOperation = (object: string) => {
export function LogDetailSheet({ log, open, onOpenChange, handleDelete, onNavigate, hasPrev = false, hasNext = false }: LogDetailSheetProps) {
const { copy: copyRequestId } = useCopyToClipboard({ successMessage: "Request ID copied" });
const { copy: copyBody } = useCopyToClipboard({ successMessage: "Request body copied to clipboard", errorMessage: "Failed to copy request body" });
const [fetchLog, { data: fullLog, isFetching }] = useLazyGetLogByIdQuery();

const [pollingInterval, setPollingInterval] = useState(0);
const { data: fullLog, isLoading, isError } = useGetLogByIdQuery(log?.id ?? "", {
skip: !open || !log?.id,
pollingInterval,
});
const shouldPoll = isError || fullLog?.status === "processing";
useEffect(() => {
if (open && log?.id) {
fetchLog(log.id);
}
}, [open, log?.id, fetchLog]);
setPollingInterval(shouldPoll ? 2000 : 0);
}, [shouldPoll]);

// Keyboard navigation: arrow up/down to navigate between logs
useHotkeys("up", () => onNavigate?.("prev"), { enabled: open && hasPrev, preventDefault: true });
useHotkeys("down", () => onNavigate?.("next"), { enabled: open && hasNext, preventDefault: true });

if (!log) return null;

// Show a loader until the full log data is fetched from the dedicated single-log endpoint.
const isFullDataReady = fullLog?.id === log.id && !isFetching;
// Show a loader only on the initial fetch, not during background polling refetches.
const isFullDataReady = fullLog?.id === log.id && !isLoading;
const displayLog = isFullDataReady ? fullLog : log;

const isContainer = isContainerOperation(displayLog.object);
Expand Down Expand Up @@ -142,9 +144,9 @@ export function LogDetailSheet({ log, open, onOpenChange, handleDelete, onNaviga
</div>
) : (
<>
<SheetHeader className="flex flex-row items-center px-0">
<div className="flex w-full items-center justify-between">
<SheetTitle className="flex w-fit items-center gap-2 font-medium">
<SheetHeader className="flex flex-row items-center px-0 overflow-x-hidden">
<div className="flex w-full items-center justify-between overflow-x-hidden">
<SheetTitle className="flex w-fit items-center gap-2 font-medium overflow-x-hidden">
{displayLog.id && (
<p className="text-md max-w-full truncate">
Request ID:{" "}
Expand Down
1 change: 1 addition & 0 deletions ui/lib/store/apis/logsApi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,4 +394,5 @@ export const {
useDeleteLogsMutation,
useRecalculateLogCostsMutation,
useLazyGetLogByIdQuery,
useGetLogByIdQuery,
} = logsApi;
Loading