Skip to content

codex websocket responses support#2259

Merged
akshaydeo merged 1 commit intomainfrom
03-24-codex_websocket_responses_support
Mar 24, 2026
Merged

codex websocket responses support#2259
akshaydeo merged 1 commit intomainfrom
03-24-codex_websocket_responses_support

Conversation

@akshaydeo
Copy link
Copy Markdown
Contributor

@akshaydeo akshaydeo commented Mar 24, 2026

Summary

Updates AWS SDK for Go v2 dependencies to their latest versions and fixes virtual key handling in WebSocket responses by removing incorrect prefix trimming.

Changes

  • Updated AWS SDK for Go v2 from v1.41.0 to v1.41.3 and related services
  • Updated smithy-go from v1.24.0 to v1.24.2
  • Updated maxim-go dependency from v0.1.16 to v0.2.0
  • Fixed virtual key handling in WebSocket responses by preserving the full "sk-bf-" prefixed token instead of incorrectly trimming it
  • Minor formatting fix (spacing alignment)

Type of change

  • Bug fix
  • Feature
  • Refactor
  • Documentation
  • Chore/CI

Affected areas

  • Core (Go)
  • Transports (HTTP)
  • Providers/Integrations
  • Plugins
  • UI (Next.js)
  • Docs

How to test

Validate the dependency updates and virtual key handling:

# Core/Transports
go version
go test ./...

# Test WebSocket virtual key handling
# Ensure tokens with "sk-bf-" prefix are properly handled without trimming

The virtual key fix ensures that Bearer tokens starting with "sk-bf-" are stored with their full value rather than having the prefix incorrectly removed.

Screenshots/Recordings

N/A - Dependency updates and backend logic fix

Breaking changes

  • Yes
  • No

Related issues

N/A

Security considerations

The virtual key handling fix ensures proper token validation and storage, maintaining security boundaries for API key authentication.

Checklist

  • I read docs/contributing/README.md and followed the guidelines
  • I added/updated tests where appropriate
  • I updated documentation where needed
  • I verified builds succeed (Go and UI)
  • I verified the CI pipeline passes locally if applicable

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Copy Markdown
Contributor

🧪 Test Suite Available

This PR can be tested by a repository admin.

Run tests for PR #2259

@akshaydeo akshaydeo marked this pull request as ready for review March 24, 2026 11:43
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 24, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 628b31dd-4388-4865-b15d-c98040c303f3

📥 Commits

Reviewing files that changed from the base of the PR and between f9b42cf and 7e85445.

⛔ Files ignored due to path filters (11)
  • core/go.sum is excluded by !**/*.sum
  • framework/go.sum is excluded by !**/*.sum
  • plugins/governance/go.sum is excluded by !**/*.sum
  • plugins/jsonparser/go.sum is excluded by !**/*.sum
  • plugins/litellmcompat/go.sum is excluded by !**/*.sum
  • plugins/logging/go.sum is excluded by !**/*.sum
  • plugins/mocker/go.sum is excluded by !**/*.sum
  • plugins/otel/go.sum is excluded by !**/*.sum
  • plugins/semanticcache/go.sum is excluded by !**/*.sum
  • plugins/telemetry/go.sum is excluded by !**/*.sum
  • transports/go.sum is excluded by !**/*.sum
📒 Files selected for processing (12)
  • core/go.mod
  • framework/go.mod
  • plugins/governance/go.mod
  • plugins/jsonparser/go.mod
  • plugins/litellmcompat/go.mod
  • plugins/logging/go.mod
  • plugins/mocker/go.mod
  • plugins/otel/go.mod
  • plugins/semanticcache/go.mod
  • plugins/telemetry/go.mod
  • transports/bifrost-http/handlers/wsresponses.go
  • transports/go.mod

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Updated virtual key handling for Bearer token authentication to preserve the complete token value instead of removing the prefix.

Walkthrough

This PR updates AWS SDK v2 and related dependency versions across all module files to the latest patch releases, and modifies virtual key storage in bifrost HTTP handlers to preserve complete Bearer token values instead of stripping the sk-bf- prefix.

Changes

Cohort / File(s) Summary
AWS SDK v2 Dependency Updates
core/go.mod, framework/go.mod, plugins/governance/go.mod, plugins/jsonparser/go.mod, plugins/litellmcompat/go.mod, plugins/logging/go.mod, plugins/mocker/go.mod, plugins/otel/go.mod, plugins/semanticcache/go.mod, plugins/telemetry/go.mod, transports/go.mod
Bumped github.com/aws/aws-sdk-go-v2 from v1.41.0 to v1.41.3, github.com/aws/smithy-go from v1.24.0 to v1.24.2, and updated all associated AWS SDK submodules (aws/protocol/eventstream, config, credentials, feature/ec2/imds, internal/*, service/*) to corresponding patch versions.
Virtual Key Handling
transports/bifrost-http/handlers/wsresponses.go
Changed virtual key storage for Bearer tokens starting with sk-bf- from trimming the prefix to storing the complete token value in the bifrost context.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested reviewers

  • danpiths

Poem

🐰 Dependencies dance, like carrots in spring,
AWS SDK hops to v1.41.3's sing,
Tokens now whole, no prefixes to trim,
The bifrost bears witness with joy to the rim! 🌟

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 03-24-codex_websocket_responses_support

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor Author

akshaydeo commented Mar 24, 2026

Merge activity

  • Mar 24, 11:43 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Mar 24, 11:44 AM UTC: @akshaydeo merged this pull request with Graphite.

@coderabbitai coderabbitai Bot requested a review from danpiths March 24, 2026 11:44
@akshaydeo akshaydeo merged commit 7289704 into main Mar 24, 2026
8 of 10 checks passed
@akshaydeo akshaydeo deleted the 03-24-codex_websocket_responses_support branch March 24, 2026 11:44
@akshaydeo akshaydeo restored the 03-24-codex_websocket_responses_support branch March 24, 2026 13:09
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@akshaydeo akshaydeo deleted the 03-24-codex_websocket_responses_support branch March 24, 2026 13:33
@coderabbitai coderabbitai Bot mentioned this pull request Apr 9, 2026
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants