Skip to content

refactor: consolidated all provider request schemas #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Pratham-Mishra04 wants to merge 3 commits into from
Closed

refactor: consolidated all provider request schemas #198

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0332637
consolidated all provider interfaces logic
TejasGhatte Jul 29, 2025
3d30ca5
updated types and comments. removed unused function
TejasGhatte Jul 30, 2025
1ca82c1
fix: made ToolChoiceFunction and used sonic for unmarshallinh
TejasGhatte Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions core/mcp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -899,9 +899,9 @@ func (m *MCPManager) addMCPToolsToBifrostRequest(ctx context.Context, req *schem
req.Params = &schemas.ModelParameters{}
}
if req.Params.Tools == nil {
req.Params.Tools = &[]schemas.Tool{}
req.Params.Tools = []schemas.Tool{}
}
tools := *req.Params.Tools
tools := req.Params.Tools

// Create a map of existing tool names for O(1) lookup
existingToolsMap := make(map[string]bool)
Expand All @@ -917,7 +917,7 @@ func (m *MCPManager) addMCPToolsToBifrostRequest(ctx context.Context, req *schem
existingToolsMap[mcpTool.Function.Name] = true
}
}
req.Params.Tools = &tools
req.Params.Tools = tools

}
return req
Expand Down
Loading