enhancement: serialisation optimisations#194
Merged
Conversation
Contributor
Summary by CodeRabbit
No changes to user-facing features or APIs. WalkthroughThe changes replace all uses of the Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant Provider (OpenAI/Vertex)
participant Sonic (JSON)
participant Schemas
Client->>Provider (OpenAI/Vertex): Send request
Provider (OpenAI/Vertex)->>Sonic (JSON): Marshal/Unmarshal request/response
Sonic (JSON)-->>Provider (OpenAI/Vertex): Serialized/Deserialized data
Provider (OpenAI/Vertex)->>Schemas: Use BifrostResponse/BifrostError
Schemas-->>Provider (OpenAI/Vertex): Structured data
Provider (OpenAI/Vertex)-->>Client: Return response or error
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Pratham-Mishra04
force-pushed
the
07-29-enhancement_serialisation_optimisations
branch
from
7ef1f01 to
51d3bd0
Compare
Pratham-Mishra04
force-pushed
the
07-29-enhancement_serialisation_optimisations
branch
from
51d3bd0 to
16f5db0
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🔭 Outside diff range comments (1)
core/providers/utils.go (1)
311-349: Simplify concurrent unmarshaling logicThe current implementation has unnecessary complexity with commented-out code and unused variables. The concurrent goroutine pattern is no longer needed since raw response unmarshaling has been removed.
Apply this diff to simplify the function:
func handleProviderResponse[T any](responseBody []byte, response *T) (interface{}, *schemas.BifrostError) { - // var rawResponse interface{} - - var wg sync.WaitGroup - var structuredErr, rawErr error - - wg.Add(2) - go func() { - defer wg.Done() - structuredErr = sonic.Unmarshal(responseBody, response) - }() - go func() { - defer wg.Done() - // rawErr = sonic.Unmarshal(responseBody, &rawResponse) - }() - wg.Wait() - - if structuredErr != nil { + if err := sonic.Unmarshal(responseBody, response); err != nil { return nil, &schemas.BifrostError{ IsBifrostError: true, Error: schemas.ErrorField{ Message: schemas.ErrProviderDecodeStructured, - Error: structuredErr, + Error: err, }, } } - if rawErr != nil { - return nil, &schemas.BifrostError{ - IsBifrostError: true, - Error: schemas.ErrorField{ - Message: schemas.ErrProviderDecodeRaw, - Error: rawErr, - }, - } - } - return nil, nil }
akshaydeo
approved these changes
Jul 29, 2025
Contributor
Merge activity
|
akshaydeo
pushed a commit
that referenced
this pull request
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.