feat: error handling added in integrations with their test cases

core/bifrost.go

@@ -192,6 +192,7 @@ func Init(config schemas.BifrostConfig) (*Bifrost, error) {
 // If the primary provider fails, it will try each fallback provider in order until one succeeds.
 func (bifrost *Bifrost) TextCompletionRequest(ctx context.Context, req *schemas.BifrostRequest) (*schemas.BifrostResponse, *schemas.BifrostError) {
 	if err := validateRequest(req); err != nil {
+		err.Provider = req.Provider
 		return nil, err
 	}
 
@@ -202,12 +203,14 @@ func (bifrost *Bifrost) TextCompletionRequest(ctx context.Context, req *schemas.
 	}
 
 	if primaryErr.Error.Type != nil && *primaryErr.Error.Type == schemas.RequestCancelled {
+		primaryErr.Provider = req.Provider
 		return nil, primaryErr
 	}
 
 	// Check if this is a short-circuit error that doesn't allow fallbacks
 	// Note: AllowFallbacks = nil is treated as true (allow fallbacks by default)
 	if primaryErr.AllowFallbacks != nil && !*primaryErr.AllowFallbacks {
+		primaryErr.Provider = req.Provider
 		return nil, primaryErr
 	}
 
@@ -234,13 +237,16 @@ func (bifrost *Bifrost) TextCompletionRequest(ctx context.Context, req *schemas.
 				return result, nil
 			}
 			if fallbackErr.Error.Type != nil && *fallbackErr.Error.Type == schemas.RequestCancelled {
+				fallbackErr.Provider = fallback.Provider
 				return nil, fallbackErr
 			}
 
 			bifrost.logger.Warn(fmt.Sprintf("Fallback provider %s failed: %s", fallback.Provider, fallbackErr.Error.Message))
 		}
 	}
 
+	primaryErr.Provider = req.Provider
+
 	// All providers failed, return the original error
 	return nil, primaryErr
 }
@@ -250,6 +256,7 @@ func (bifrost *Bifrost) TextCompletionRequest(ctx context.Context, req *schemas.
 // If the primary provider fails, it will try each fallback provider in order until one succeeds.
 func (bifrost *Bifrost) ChatCompletionRequest(ctx context.Context, req *schemas.BifrostRequest) (*schemas.BifrostResponse, *schemas.BifrostError) {
 	if err := validateRequest(req); err != nil {
+		err.Provider = req.Provider
 		return nil, err
 	}
 
@@ -259,9 +266,15 @@ func (bifrost *Bifrost) ChatCompletionRequest(ctx context.Context, req *schemas.
 		return primaryResult, nil
 	}
 
+	if primaryErr.Error.Type != nil && *primaryErr.Error.Type == schemas.RequestCancelled {
+		primaryErr.Provider = req.Provider
+		return nil, primaryErr
+	}
+
 	// Check if this is a short-circuit error that doesn't allow fallbacks
 	// Note: AllowFallbacks = nil is treated as true (allow fallbacks by default)
 	if primaryErr.AllowFallbacks != nil && !*primaryErr.AllowFallbacks {
+		primaryErr.Provider = req.Provider
 		return nil, primaryErr
 	}
 
@@ -288,13 +301,16 @@ func (bifrost *Bifrost) ChatCompletionRequest(ctx context.Context, req *schemas.
 				return result, nil
 			}
 			if fallbackErr.Error.Type != nil && *fallbackErr.Error.Type == schemas.RequestCancelled {
+				fallbackErr.Provider = fallback.Provider
 				return nil, fallbackErr
 			}
 
 			bifrost.logger.Warn(fmt.Sprintf("Fallback provider %s failed: %s", fallback.Provider, fallbackErr.Error.Message))
 		}
 	}
 
+	primaryErr.Provider = req.Provider
+
 	// All providers failed, return the original error
 	return nil, primaryErr
 }
@@ -304,6 +320,7 @@ func (bifrost *Bifrost) ChatCompletionRequest(ctx context.Context, req *schemas.
 // If the primary provider fails, it will try each fallback provider in order until one succeeds.
 func (bifrost *Bifrost) EmbeddingRequest(ctx context.Context, req *schemas.BifrostRequest) (*schemas.BifrostResponse, *schemas.BifrostError) {
 	if err := validateRequest(req); err != nil {
+		err.Provider = req.Provider
 		return nil, err
 	}
 
@@ -317,9 +334,15 @@ func (bifrost *Bifrost) EmbeddingRequest(ctx context.Context, req *schemas.Bifro
 		return primaryResult, nil
 	}
 
+	if primaryErr.Error.Type != nil && *primaryErr.Error.Type == schemas.RequestCancelled {
+		primaryErr.Provider = req.Provider
+		return nil, primaryErr
+	}
+
 	// Check if this is a short-circuit error that doesn't allow fallbacks
 	// Note: AllowFallbacks = nil is treated as true (allow fallbacks by default)
 	if primaryErr.AllowFallbacks != nil && !*primaryErr.AllowFallbacks {
+		primaryErr.Provider = req.Provider
 		return nil, primaryErr
 	}
 
@@ -345,13 +368,16 @@ func (bifrost *Bifrost) EmbeddingRequest(ctx context.Context, req *schemas.Bifro
 				return result, nil
 			}
 			if fallbackErr.Error.Type != nil && *fallbackErr.Error.Type == schemas.RequestCancelled {
+				fallbackErr.Provider = fallback.Provider
 				return nil, fallbackErr
 			}
 
 			bifrost.logger.Warn(fmt.Sprintf("Fallback provider %s failed: %s", fallback.Provider, fallbackErr.Error.Message))
 		}
 	}
 
+	primaryErr.Provider = req.Provider
+
 	// All providers failed, return the original error
 	return nil, primaryErr
 }

core/schemas/bifrost.go

@@ -431,12 +431,13 @@ const (
 // - AllowFallbacks = &false: Bifrost will return this error immediately, no fallbacks
 // - AllowFallbacks = nil: Treated as true by default (fallbacks allowed for resilience)
 type BifrostError struct {
-	EventID        *string    `json:"event_id,omitempty"`
-	Type           *string    `json:"type,omitempty"`
-	IsBifrostError bool       `json:"is_bifrost_error"`
-	StatusCode     *int       `json:"status_code,omitempty"`
-	Error          ErrorField `json:"error"`
-	AllowFallbacks *bool      `json:"-"` // Optional: Controls fallback behavior (nil = true by default)
+	Provider       ModelProvider `json:"-"`
+	EventID        *string       `json:"event_id,omitempty"`
+	Type           *string       `json:"type,omitempty"`
+	IsBifrostError bool          `json:"is_bifrost_error"`
+	StatusCode     *int          `json:"status_code,omitempty"`
+	Error          ErrorField    `json:"error"`
+	AllowFallbacks *bool         `json:"-"` // Optional: Controls fallback behavior (nil = true by default)
 }
 
 // ErrorField represents detailed error information.

tests/transports-integrations/README.md

@@ -34,7 +34,7 @@ The Bifrost integration tests use a centralized configuration system that routes
 
 ## 📋 Test Categories
 
-Our test suite covers 11 comprehensive scenarios for each integration:
+Our test suite covers 12 comprehensive scenarios for each integration:
 
 1. **Simple Chat** - Basic single-message conversations
 2. **Multi-turn Conversation** - Conversation history and context retention
@@ -47,6 +47,7 @@ Our test suite covers 11 comprehensive scenarios for each integration:
 9. **Multiple Images** - Multi-image analysis and comparison
 10. **Complex End-to-End** - Comprehensive multimodal workflows
 11. **Integration-Specific Features** - Integration-unique capabilities
+12. **Error Handling** - Invalid request error processing and propagation
 
 ## 📁 Directory Structure
 
@@ -179,6 +180,10 @@ python run_integration_tests.py litellm
 
 # Option 3: Using pytest directly
 pytest tests/integrations/test_openai.py -v
+
+# Run specific test categories
+pytest tests/integrations/ -k "error_handling" -v  # Run only error handling tests
+pytest tests/integrations/ -k "test_12" -v         # Run all 12th test cases (error handling)
 ```
 
 #### Makefile Commands

tests/transports-integrations/tests/integrations/test_anthropic.py

@@ -35,12 +35,16 @@
     MULTIPLE_TOOL_CALL_MESSAGES,
     IMAGE_URL,
     BASE64_IMAGE,
+    INVALID_ROLE_MESSAGES,
     WEATHER_TOOL,
     CALCULATOR_TOOL,
+    ALL_TOOLS,
     mock_tool_response,
     assert_valid_chat_response,
     assert_has_tool_calls,
     assert_valid_image_response,
+    assert_valid_error_response,
+    assert_error_propagation,
     extract_tool_calls,
     get_api_key,
     skip_if_no_api_key,
@@ -544,6 +548,21 @@ def test_11_integration_specific_features(self, anthropic_client, test_config):
         # Should prefer calculator for math question
         assert tool_calls[0]["name"] == "calculate"
 
+    @skip_if_no_api_key("anthropic")
+    def test_12_error_handling_invalid_roles(self, anthropic_client, test_config):
+        """Test Case 12: Error handling for invalid roles"""
+        with pytest.raises(Exception) as exc_info:
+            anthropic_client.messages.create(
+                model=get_model("anthropic", "chat"),
+                messages=INVALID_ROLE_MESSAGES,
+                max_tokens=100,
+            )
+
+        # Verify the error is properly caught and contains role-related information
+        error = exc_info.value
+        assert_valid_error_response(error, "tester")
+        assert_error_propagation(error, "anthropic")
+
 
 # Additional helper functions specific to Anthropic
 def extract_anthropic_tool_calls(response: Any) -> List[Dict[str, Any]]:

tests/transports-integrations/tests/integrations/test_google.py

@@ -31,15 +31,19 @@
     MULTIPLE_TOOL_CALL_MESSAGES,
     IMAGE_URL,
     BASE64_IMAGE,
+    INVALID_ROLE_MESSAGES,
     WEATHER_TOOL,
     CALCULATOR_TOOL,
     assert_valid_chat_response,
     assert_valid_image_response,
+    assert_valid_error_response,
+    assert_error_propagation,
     get_api_key,
     skip_if_no_api_key,
     COMPARISON_KEYWORDS,
     WEATHER_KEYWORDS,
     LOCATION_KEYWORDS,
+    GENAI_INVALID_ROLE_CONTENT,
 )
 from ..utils.config_loader import get_model
 
@@ -422,6 +426,19 @@ def test_11_integration_specific_features(self, google_client, test_config):
 
         assert_valid_chat_response(response3)
 
+    @skip_if_no_api_key("google")
+    def test_12_error_handling_invalid_roles(self, google_client, test_config):
+        """Test Case 12: Error handling for invalid roles"""
+        with pytest.raises(Exception) as exc_info:
+            google_client.models.generate_content(
+                model=get_model("google", "chat"), contents=GENAI_INVALID_ROLE_CONTENT
+            )
+
+        # Verify the error is properly caught and contains role-related information
+        error = exc_info.value
+        assert_valid_error_response(error, "tester")
+        assert_error_propagation(error, "google")
+
 
 # Additional helper functions specific to Google GenAI
 def extract_google_function_calls(response: Any) -> List[Dict[str, Any]]:

tests/transports-integrations/tests/integrations/test_litellm.py

@@ -36,13 +36,18 @@
     IMAGE_BASE64_MESSAGES,
     MULTIPLE_IMAGES_MESSAGES,
     COMPLEX_E2E_MESSAGES,
+    INVALID_ROLE_MESSAGES,
     WEATHER_TOOL,
     CALCULATOR_TOOL,
     mock_tool_response,
     assert_valid_chat_response,
     assert_has_tool_calls,
     assert_valid_image_response,
+    assert_valid_error_response,
+    assert_error_propagation,
     extract_tool_calls,
+    get_api_key,
+    skip_if_no_api_key,
     COMPARISON_KEYWORDS,
     WEATHER_KEYWORDS,
     LOCATION_KEYWORDS,
@@ -339,6 +344,20 @@ def test_11_integration_specific_features(self, test_config):
 
         assert_valid_chat_response(response3)
 
+    def test_12_error_handling_invalid_roles(self, test_config):
+        """Test Case 12: Error handling for invalid roles"""
+        with pytest.raises(Exception) as exc_info:
+            litellm.completion(
+                model=get_model("litellm", "chat"),
+                messages=INVALID_ROLE_MESSAGES,
+                max_tokens=100,
+            )
+
+        # Verify the error is properly caught and contains role-related information
+        error = exc_info.value
+        assert_valid_error_response(error, "tester")
+        assert_error_propagation(error, "litellm")
+
 
 # Additional helper functions specific to LiteLLM
 def extract_litellm_tool_calls(response: Any) -> List[Dict[str, Any]]:

tests/transports-integrations/tests/integrations/test_openai.py

@@ -36,12 +36,15 @@
     IMAGE_BASE64_MESSAGES,
     MULTIPLE_IMAGES_MESSAGES,
     COMPLEX_E2E_MESSAGES,
+    INVALID_ROLE_MESSAGES,
     WEATHER_TOOL,
     CALCULATOR_TOOL,
     mock_tool_response,
     assert_valid_chat_response,
     assert_has_tool_calls,
     assert_valid_image_response,
+    assert_valid_error_response,
+    assert_error_propagation,
     extract_tool_calls,
     get_api_key,
     skip_if_no_api_key,
@@ -389,3 +392,18 @@ def test_11_integration_specific_features(self, openai_client, test_config):
         )
 
         assert_valid_chat_response(response3)
+
+    @skip_if_no_api_key("openai")
+    def test_12_error_handling_invalid_roles(self, openai_client, test_config):
+        """Test Case 12: Error handling for invalid roles"""
+        with pytest.raises(Exception) as exc_info:
+            openai_client.chat.completions.create(
+                model=get_model("openai", "chat"),
+                messages=INVALID_ROLE_MESSAGES,
+                max_tokens=100,
+            )
+
+        # Verify the error is properly caught and contains role-related information
+        error = exc_info.value
+        assert_valid_error_response(error, "tester")
+        assert_error_propagation(error, "openai")