feat: add governance plugin E2E tests and doc updates

.github/workflows/release-pipeline.yml

@@ -225,6 +225,11 @@ jobs:
         with:
           go-version: "1.25.5"
 
+      - name: Set up Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: "20"
+
       - name: Configure Git
         run: |
           git config user.name "GitHub Actions Bot"

.github/workflows/scripts/release-single-plugin.sh

@@ -76,9 +76,39 @@ if [ -f "go.mod" ]; then
 
   # Run tests with coverage if any exist
   if go list ./... | grep -q .; then
-    # Skip tests for governance plugin (no tests yet)
+    # Run E2E tests for governance plugin
     if [ "$PLUGIN_NAME" = "governance" ]; then
-      echo "ℹ️ Skipping tests for governance plugin"
+      echo "🧪 Running governance plugin unit tests with coverage..."
+      go test -coverprofile=coverage.txt -coverpkg=./... ./...
+
+      # Upload unit test coverage to Codecov
+      if [ -n "${CODECOV_TOKEN:-}" ]; then
+        echo "📊 Uploading unit test coverage to Codecov..."
+        curl -Os https://uploader.codecov.io/latest/linux/codecov
+        chmod +x codecov
+        ./codecov -t "$CODECOV_TOKEN" -f coverage.txt -F "plugin-${PLUGIN_NAME}"
+        rm -f codecov coverage.txt
+      else
+        echo "ℹ️ CODECOV_TOKEN not set, skipping coverage upload"
+        rm -f coverage.txt
+      fi
+
+      # Run E2E tests for governance plugin
+      echo ""
+      echo "🛡️ Running governance E2E tests..."
+      cd ../..
+      E2E_SCRIPT=".github/workflows/scripts/run-governance-e2e-tests.sh"
+      if [ ! -f "$E2E_SCRIPT" ]; then
+        echo "❌ Governance E2E test script not found: $E2E_SCRIPT"
+        exit 1
+      fi
+      chmod +x "$E2E_SCRIPT" || true
+      if ! bash "$E2E_SCRIPT"; then
+        echo "❌ Governance E2E tests failed"
+        exit 1
+      fi
+      echo "✅ Governance E2E tests passed"
+      cd "$PLUGIN_DIR"
     else
       echo "🧪 Running plugin tests with coverage..."
       go test -coverprofile=coverage.txt -coverpkg=./... ./...

.github/workflows/scripts/run-governance-e2e-tests.sh

@@ -0,0 +1,192 @@
+#!/usr/bin/env bash
+set -euo pipefail
+
+# Run Governance E2E Tests
+# This script builds Bifrost, starts it with the governance test config,
+# runs the governance tests, and cleans up.
+#
+# Usage: ./run-governance-e2e-tests.sh
+
+echo "🛡️ Starting Governance E2E Tests..."
+
+# Get the root directory of the repo
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+REPO_ROOT="$(cd "$SCRIPT_DIR/../../.." && pwd)"
+cd "$REPO_ROOT"
+
+# Colors for output
+RED='\033[0;31m'
+GREEN='\033[0;32m'
+YELLOW='\033[1;33m'
+CYAN='\033[0;36m'
+NC='\033[0m' # No Color
+
+# Configuration
+BIFROST_PORT=8080
+BIFROST_HOST="localhost"
+BIFROST_URL="http://${BIFROST_HOST}:${BIFROST_PORT}"
+CONFIG_PATH="tests/governance/config.json"
+BIFROST_BINARY="tmp/bifrost-http"
+BIFROST_PID_FILE="/tmp/bifrost-governance-test.pid"
+BIFROST_LOG_FILE="/tmp/bifrost-governance-test.log"
+MAX_STARTUP_WAIT=30 # seconds
+
+# Cleanup function to ensure Bifrost is stopped
+cleanup() {
+  local exit_code=$?
+  echo ""
+  echo -e "${YELLOW}🧹 Cleaning up...${NC}"
+
+  # Stop Bifrost if running
+  if [ -f "$BIFROST_PID_FILE" ]; then
+    BIFROST_PID=$(cat "$BIFROST_PID_FILE")
+    if ps -p "$BIFROST_PID" > /dev/null 2>&1; then
+      echo -e "${CYAN}Stopping Bifrost (PID: $BIFROST_PID)...${NC}"
+      kill "$BIFROST_PID" 2>/dev/null || true
+      sleep 2
+      # Force kill if still running
+      if ps -p "$BIFROST_PID" > /dev/null 2>&1; then
+        echo -e "${YELLOW}Force killing Bifrost...${NC}"
+        kill -9 "$BIFROST_PID" 2>/dev/null || true
+      fi
+    fi
+    rm -f "$BIFROST_PID_FILE"
+  fi
+
+  # Clean up log file
+  if [ -f "$BIFROST_LOG_FILE" ]; then
+    echo -e "${CYAN}Bifrost logs saved to: $BIFROST_LOG_FILE${NC}"
+  fi
+
+  # Clean up test database
+  if [ -f "data/governance-test.db" ]; then
+    echo -e "${CYAN}Cleaning up test database...${NC}"
+    rm -f "data/governance-test.db"
+  fi
+
+  if [ $exit_code -eq 0 ]; then
+    echo -e "${GREEN}✅ Cleanup complete${NC}"
+  else
+    echo -e "${RED}❌ Cleanup complete (tests failed)${NC}"
+  fi
+
+  exit $exit_code
+}
+
+# Set up trap to cleanup on exit
+trap cleanup EXIT INT TERM
+
+# Step 1: Validate prerequisites
+echo -e "${CYAN}📋 Step 1: Validating prerequisites...${NC}"
+
+if [ ! -f "$CONFIG_PATH" ]; then
+  echo -e "${RED}❌ Config file not found: $CONFIG_PATH${NC}"
+  exit 1
+fi
+
+# Check required environment variables
+if [ -z "${OPENAI_API_KEY:-}" ]; then
+  echo -e "${RED}❌ OPENAI_API_KEY environment variable is required${NC}"
+  echo -e "${YELLOW}Set it with: export OPENAI_API_KEY='sk-...'${NC}"
+  exit 1
+fi
+
+echo -e "${GREEN}✅ Prerequisites validated${NC}"
+
+# Step 2: Build Bifrost
+echo ""
+echo -e "${CYAN}📦 Step 2: Building Bifrost...${NC}"
+
+# Use make to build with LOCAL=1 to use the workspace (go.work)
+# This ensures we test the local governance plugin code, not the published version
+if ! LOCAL=1 make build; then
+  echo -e "${RED}❌ Failed to build Bifrost${NC}"
+  exit 1
+fi
+
+if [ ! -f "$BIFROST_BINARY" ]; then
+  echo -e "${RED}❌ Bifrost binary not found at: $BIFROST_BINARY${NC}"
+  exit 1
+fi
+
+echo -e "${GREEN}✅ Bifrost built successfully${NC}"
+
+# Step 3: Start Bifrost in background
+echo ""
+echo -e "${CYAN}🚀 Step 3: Starting Bifrost server...${NC}"
+
+# Ensure data directory exists for SQLite database
+mkdir -p data
+
+# Start Bifrost in background
+echo -e "${YELLOW}Starting Bifrost on ${BIFROST_URL}...${NC}"
+"$BIFROST_BINARY" --config "$CONFIG_PATH" > "$BIFROST_LOG_FILE" 2>&1 &
+BIFROST_PID=$!
+echo "$BIFROST_PID" > "$BIFROST_PID_FILE"
+
+echo -e "${CYAN}Bifrost started with PID: $BIFROST_PID${NC}"
+
+# Step 4: Wait for Bifrost to be ready
+echo ""
+echo -e "${CYAN}⏳ Step 4: Waiting for Bifrost to be ready...${NC}"
+
+WAIT_COUNT=0
+until curl -sf "${BIFROST_URL}/health" > /dev/null 2>&1; do
+  if [ $WAIT_COUNT -ge $MAX_STARTUP_WAIT ]; then
+    echo -e "${RED}❌ Bifrost failed to start within ${MAX_STARTUP_WAIT} seconds${NC}"
+    echo -e "${YELLOW}Last 50 lines of Bifrost logs:${NC}"
+    tail -n 50 "$BIFROST_LOG_FILE" || true
+    exit 1
+  fi
+
+  # Check if process is still running
+  if ! ps -p "$BIFROST_PID" > /dev/null 2>&1; then
+    echo -e "${RED}❌ Bifrost process died${NC}"
+    echo -e "${YELLOW}Bifrost logs:${NC}"
+    cat "$BIFROST_LOG_FILE" || true
+    exit 1
+  fi
+
+  WAIT_COUNT=$((WAIT_COUNT + 1))
+  echo -e "${YELLOW}Waiting for Bifrost... ($WAIT_COUNT/${MAX_STARTUP_WAIT})${NC}"
+  sleep 1
+done
+
+echo -e "${GREEN}✅ Bifrost is ready and responding${NC}"
+
+# Step 5: Run governance tests
+echo ""
+echo -e "${CYAN}🧪 Step 5: Running governance tests...${NC}"
+
+cd tests/governance
+
+# Run tests with go test (disable workspace to avoid module conflicts)
+echo -e "${YELLOW}Running go test in tests/governance...${NC}"
+
+# Run tests with verbose output and timeout
+# Use GOWORK=off to disable the workspace file and test the module independently
+TEST_EXIT_CODE=0
+if ! GOWORK=off go test -v -timeout 10m ./...; then
+  TEST_EXIT_CODE=$?
+  echo -e "${RED}❌ Governance tests failed (exit code: $TEST_EXIT_CODE)${NC}"
+else
+  echo -e "${GREEN}✅ All governance tests passed${NC}"
+fi
+
+cd "$REPO_ROOT"
+
+# Step 6: Report results
+echo ""
+if [ $TEST_EXIT_CODE -eq 0 ]; then
+  echo -e "${GREEN}═══════════════════════════════════════════════════════${NC}"
+  echo -e "${GREEN}✅ Governance E2E Tests PASSED${NC}"
+  echo -e "${GREEN}═══════════════════════════════════════════════════════${NC}"
+else
+  echo -e "${RED}═══════════════════════════════════════════════════════${NC}"
+  echo -e "${RED}❌ Governance E2E Tests FAILED${NC}"
+  echo -e "${RED}═══════════════════════════════════════════════════════${NC}"
+  echo ""
+  echo -e "${YELLOW}Check logs at: $BIFROST_LOG_FILE${NC}"
+fi
+
+exit $TEST_EXIT_CODE