Skip to content

ci: ensure Docker build runs even when core dep update is skipped#117

Merged
akshaydeo merged 1 commit intomainfrom
06-24-chore_minor_docker_workflow_fix
Jun 24, 2025
Merged

ci: ensure Docker build runs even when core dep update is skipped#117
akshaydeo merged 1 commit intomainfrom
06-24-chore_minor_docker_workflow_fix

Conversation

@Pratham-Mishra04
Copy link
Copy Markdown
Collaborator

@Pratham-Mishra04 Pratham-Mishra04 commented Jun 24, 2025

Fixed conditional logic for Docker build job to ensure it runs when the dependency update job is skipped but a valid tag exists. The updated condition checks for either a successful dependency update OR a combination of a skipped update with a valid transport version tag.

Copy link
Copy Markdown
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Pratham-Mishra04 Pratham-Mishra04 marked this pull request as ready for review June 24, 2025 06:27
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 24, 2025

Summary by CodeRabbit

  • Chores
    • Updated workflow conditions to ensure the build-and-push process only runs when previous dependency updates have not failed.

Summary by CodeRabbit

  • Chores
    • Updated workflow to ensure the Docker build and push job is always triggered during workflow runs, while still checking for specific conditions before proceeding.

Walkthrough

The conditional logic for triggering the build-and-push-docker job in the .github/workflows/transport-ci.yml workflow was updated. The job is now always evaluated on every workflow run, but only executes if the tag prefix matches or the update-transport-dependency job succeeded or was skipped under certain conditions, preserving the original intent with added flexibility.

Changes

File(s) Change Summary
.github/workflows/transport-ci.yml Modified the conditional expression for the build-and-push-docker job to run if the dependency job succeeded or was skipped with a matching tag.

Possibly related PRs

Suggested reviewers

  • akshaydeo
  • danpiths

Poem

In the warren of workflows, a hop and a skip,
Now Docker builds wait with a conditional grip.
Always evaluated, but only sometimes run,
Like a rabbit who checks if the rain or the sun.
🐇✨
So here's to the logic, both clever and neat—
May your CI hops never miss a beat!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7498a6b and d3f4953.

📒 Files selected for processing (1)
  • .github/workflows/transport-ci.yml (1 hunks)
🔇 Additional comments (2)
.github/workflows/transport-ci.yml (2)

125-126: Condition now correctly breaks the implicit gating – well done.

Introducing always() at the very front lets this job evaluate its own guard even when the upstream job is skipped, so the Docker image can still be built after manual version bumps.
Nothing else in the workflow is negatively impacted. 👍


125-126: ```shell
#!/bin/bash
sed -n '1,200p' .github/workflows/transport-ci.yml


</details>

</blockquote></details>

</details>
<!-- internal state start -->


<!-- DwQgtGAEAqAWCWBnSTIEMB26CuAXA9mAOYCmGJATmriQCaQDG+Ats2bgFyQAOFk+AIwBWJBrngA3EsgEBPRvlqU0AgfFwA6NPEgQAfACgjoCEYDEZyAAUASpETZWaCrKNwSPbABsvkCiQBHbGlcSHFcLzpIACIGeC4yB39IABF8BgBrSkgBbHgvegpsDGQSKSwAd1gyBWSlbkhsblpqD1REDPhubjpoyAq0ZAcBZnUaejlGxGyrKlxYNGYwAFkkWCoABgAWdGRbSAxHAWyARhOAdhQseY9mNAAPeGZYAIB6NQAzCnxEUP9uH7qfAuDQwaqMBYYUiQD7we7SMLgpgYWjqeD4DBoXxefBEeAMGHAxEeNKZbK5fL0ISCK7EyAAYQAkjwuiQvPByKCAMo9OKwhhYryyAA0KFCiWw/mQ82odNJWT4FIKkGpAj8xVK5RQHzp9TISgwDHkTRaNBVNPanW6dFFvHwEngSnoaEgEixjrCVBKAIooSkFEQ6OuaCIkBIj1+iFB7kazVa9GRqPEGIhogyyA+RJI6mqfBdDgYDGkiA+3kgepRZCNsdNHiJLqYzDUmOTWHwOvzVp69BNrX6OfQrvd9FwXsQPr9lEDKdwIejCGQaFoQmwvzYGFCRGwzkwNARMtCN1S6QVKDu0KVzpRnkQsB43yLiGQFXyvnDojwbSwiCLmIo6OfXMPCPCsDWrXszVVFAhi7KJclCF03XZEcQ2g+9pHYUUCzvQZ+mqLA7kOLFXSnIMckcbhkHSBhJXLYIwnwHJ/DQTooRrVpkA5OkmDqEgekrQ1ZA0cxLHpFh11wIZHDuFw3CRcT2Co64F08Hw/ECYJfiuBgvGwJRBwEf8SB1cMGEhaFeCeZx8nkY5cAqEgaiPNA8FgYFRVmagFiWVZb02LZRUwK98BuPhkVHeB4Pc9B0wWWQlHwecPBc+YiQ5NFBXkW9nCiBsFI3dSPkoKsOVDI99kOJtsiC7TdKdSB2QwdMGNdeASAqOl9i4gBxKhuAQGhAoY/BfEzPhCJDUrVN8fwghCexZ0yKMwVQRsJPQLxEEYjAQqiA9OrsX40EyNCJtICZ5F6tB+vUZLrztB16sa5qCAakhnAI4FkoEfA8DpI7Mimu1H2WoxPJlHy1n84ksClAFKxHRiXTm34yK+FgYuy+KSEY/wiGcVE2KPH8yGsxijwgqJEzRFNUA5GgEZagVuFwSUSCSnBUr4cNuC8bRyBHBZD3klEaawJdaClaZkAFaW8OKulYQDUIoIAClAqtjTjGgAEoYW0Ta6OApGmPe1jQ0p2kjx4jwNcE21vmYFmppdQjt18S9+B1I9R0wcdgQQ69Xcwd3yKdr2xWQf1pwwedUB5vmWzInTrNhfdwTmIMsQ8Y4EGva2MSTLPsVxfEIUwUhhIMABBWgi4xTKPLmbyVihtBtkgO59JdQy2p1Nb2CuVEBXENiQ38Eh1v2gvRdbfpgWa+CDl2wXZXKuwBmQHbQlkEhQjYChzqS5IHOSHaYUlUKwlEWAMHxYjUR/VcY8QUV/AddrX/4PgiroARjoyDCR2/Ar7hX/FFAMooOQ6T0lNCm0wwqKGUKodQ2hQQAHl/SClFAXVg7BnDyFQOyUY4wmZ83/B8WQcDwTcElACaYEdrbmTuoUYyxVDRwPwCNKaL5Up/XDAzQMUh1Ifw6kSBg/5xBzSrvoYw4AoD6gjilQgpByBzCpvlTg95+DCFEOIKQMh5BMCUFQFBmhtC6DAIYEwUA4B00XOLPAKiyDKFIQPDcXAqAdQcE4FwOQjFINMWocxOhZFyNMAYDQeJ5jYAEK8CoC8Pg4gqIgV4vtvQBzAHEDQshmBeA4AYaIRSDAWEgNXRkxAXHqPoD4mS8h2zlyhNIOSHhqatmIjzKWycMSjhGo1Mq4J3w0Tng0o8AADS8YAgpgFobeMAtATyUDGeaNUm9O6KHgGnWgoJZhlHRKuIUODwRQS9NqOk3V1AAAlYmFXYUWBazhSG8LvGM/wHxUmziIB8scE5UkSGWWlb24IxmUzAOk/2vp5l8X1JrZZUECxFjoHQUE1cPg0D4EwiuJAjkeBORqRohpC5i0ypAVWYysQDFkIgVWOsxl6yXhiIUZzxmgvBROKF/EwKyDhTSVE9Bt763yKS150hvChBAAAXkgAAcg+AbNm0q6XoGvNmK+R4Lm4GuWqN5dyPBHV9M+AcIr3lpJDN8v2vzXj/O/nSEF2sSBgp+Zku2RoeVqgRY5J0ccZbMMKhydOrSiWtmlIxXgZRB5HigujZg6oMB3zYps3U0KBLgXtSswVkRaCiiqPkZKPh8AvgTYeXGxRmXghdVrWs6a1kdC6N2G1HqkVZuVYLYCqE2lkVQGwTQIkyleHRdQIMIak0p0zhiKiJl7gTiiESWhAh2QEnYGiZpBgAByGJ2aFOKQYMJNiwzXgacoypaj4wKDwR4vwaBvHSQIf4hQJiVDBK0KEqxBg91rXUAAfUdIgT9782oOVoJ+/VoRd3yMgAAZgAExQYAGxbGOh8bYJwACcEG0AnFEB8AAHLBlQaAPj/wENhjYpGYMCBOLBmDtBLiyL3ecLYKHsNoFgwIWDDAzhQZwwKKDDBzjnCgwx7DJAACs2GPgodEBhrYtAPhQYgxBkTljrHgdoBBj4jGRPqZg3KtTEGNjMbQ8RjYhYLg4eExsETtBLMQZQyhk4ynwlQA/bgb9tBf3/vanQT9ij9BAA -->

<!-- internal state end -->
<!-- finishing_touch_checkbox_start -->

<details open="true">
<summary>✨ Finishing Touches</summary>

<details open="true">
<summary>🧪 Generate Unit Tests</summary>

- [ ] <!-- {"checkboxId": "f47ac10b-58cc-4372-a567-0e02b2c3d479", "radioGroupId": "utg-output-choice-group-unknown_comment_id"} -->   Create PR with Unit Tests
- [ ] <!-- {"checkboxId": "07f1e7d6-8a8e-4e23-9900-8731c2c87f58", "radioGroupId": "utg-output-choice-group-unknown_comment_id"} -->   Post Copyable Unit Tests in Comment
- [ ] <!-- {"checkboxId": "6ba7b810-9dad-11d1-80b4-00c04fd430c8", "radioGroupId": "utg-output-choice-group-unknown_comment_id"} -->   Commit Unit Tests in branch `06-24-chore_minor_docker_workflow_fix`

</details>

</details>

<!-- finishing_touch_checkbox_end -->
<!-- tips_start -->

---



<details>
<summary>🪧 Tips</summary>

### Chat

There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=maximhq/bifrost&utm_content=117):

- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  - `I pushed a fix in commit <commit_id>, please review it.`
  - `Explain this complex logic.`
  - `Open a follow-up GitHub issue for this discussion.`
- Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples:
  - `@coderabbitai explain this code block.`
  -	`@coderabbitai modularize this function.`
- PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.`
  - `@coderabbitai read src/utils.ts and explain its main purpose.`
  - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.`
  - `@coderabbitai help me debug CodeRabbit configuration file.`

### Support

Need help? Create a ticket on our [support page](https://www.coderabbit.ai/contact-us/support) for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

### CodeRabbit Commands (Invoked using PR comments)

- `@coderabbitai pause` to pause the reviews on a PR.
- `@coderabbitai resume` to resume the paused reviews.
- `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
- `@coderabbitai full review` to do a full review from scratch and review all the files again.
- `@coderabbitai summary` to regenerate the summary of the PR.
- `@coderabbitai generate docstrings` to [generate docstrings](https://docs.coderabbit.ai/finishing-touches/docstrings) for this PR.
- `@coderabbitai generate sequence diagram` to generate a sequence diagram of the changes in this PR.
- `@coderabbitai auto-generate unit tests` to generate unit tests for this PR.
- `@coderabbitai resolve` resolve all the CodeRabbit review comments.
- `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository.
- `@coderabbitai help` to get help.

### Other keywords and placeholders

- Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed.
- Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description.
- Add `@coderabbitai` anywhere in the PR title to generate the title automatically.

### CodeRabbit Configuration File (`.coderabbit.yaml`)

- You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository.
- Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json`

### Documentation and Community

- Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit.
- Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback.
- Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

</details>

<!-- tips_end -->

Copy link
Copy Markdown
Contributor

@akshaydeo akshaydeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no no. this we cant merge

Copy link
Copy Markdown
Collaborator Author

yes yes, not merging

@Pratham-Mishra04 Pratham-Mishra04 force-pushed the 06-24-chore_minor_docker_workflow_fix branch from 32264ac to 7498a6b Compare June 24, 2025 06:31
Copy link
Copy Markdown
Collaborator Author

@akshaydeo ig this condition works

Copy link
Copy Markdown
Contributor

whats the scenario we are capturing here?

Copy link
Copy Markdown
Collaborator Author

when job 1 fails cause of some breaking update in /core, so we manually build the transport and bump its version

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 32264ac and 7498a6b.

📒 Files selected for processing (1)
  • .github/workflows/transport-ci.yml (1 hunks)

Comment thread .github/workflows/transport-ci.yml
@Pratham-Mishra04 Pratham-Mishra04 force-pushed the 06-24-chore_minor_docker_workflow_fix branch from 7498a6b to d3f4953 Compare June 24, 2025 06:38
Copy link
Copy Markdown
Collaborator Author

@akshaydeo ig we can go ahead with this

Copy link
Copy Markdown
Contributor

when job 1 fails cause of some breaking update in /core, so we manually build the transport and bump its version
this should not happen right. if core fails we should not bump up transport and reelase

@akshaydeo akshaydeo merged commit 1622933 into main Jun 24, 2025
2 checks passed
@akshaydeo akshaydeo deleted the 06-24-chore_minor_docker_workflow_fix branch August 31, 2025 17:30
akshaydeo added a commit that referenced this pull request Nov 17, 2025
Fixed conditional logic for Docker build job to ensure it runs when the dependency update job is skipped but a valid tag exists. The updated condition checks for either a successful dependency update OR a combination of a skipped update with a valid transport version tag.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants