Skip to content

fixes github actions trigger#109

Merged
akshaydeo merged 1 commit intomainfrom
06-21-fixes_github_actions_trigger
Jun 21, 2025
Merged

fixes github actions trigger#109
akshaydeo merged 1 commit intomainfrom
06-21-fixes_github_actions_trigger

Conversation

@akshaydeo
Copy link
Copy Markdown
Contributor

@akshaydeo akshaydeo commented Jun 21, 2025

TL;DR

Updated GitHub Actions workflow to trigger on tag pushes instead of branch pushes.

What changed?

Modified the transport-ci.yml workflow to:

  • Remove the branch trigger for test/gh-actions
  • Uncomment and enable tag-based triggers for core/v* and transports/v*

How to test?

  1. Push a tag with the format core/v* to verify dependency update is triggered
  2. Push a tag with the format transports/v* to verify docker build is triggered

Why make this change?

This change moves the workflow from a testing phase to production usage, ensuring that the CI pipeline only runs when specific version tags are pushed rather than on branch commits. This provides better control over when dependency updates and Docker builds are triggered.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 21, 2025

Warning

Rate limit exceeded

@akshaydeo has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 5 minutes and 34 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between e100c6a and c4ed89f.

📒 Files selected for processing (1)
  • .github/workflows/transport-ci.yml (1 hunks)
✨ Finishing Touches
🧪 Generate Unit Tests
  • Create PR with Unit Tests
  • Post Copyable Unit Tests in Comment
  • Commit Unit Tests in branch 06-21-fixes_github_actions_trigger

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai auto-generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@akshaydeo akshaydeo marked this pull request as ready for review June 21, 2025 11:13
@akshaydeo akshaydeo merged commit 571dc89 into main Jun 21, 2025
1 of 2 checks passed
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Double Triggered Builds Waste CI Resources

The transport-ci.yml workflow triggers on both core/v* and transports/v* tags. When a core/v* tag is pushed, the workflow executes, updates dependencies, and generates a new transports/v* tag. This new tag then re-triggers the workflow, causing the Docker build to run twice. The first build, triggered by the core/v* tag, uses outdated transport code and may produce an incorrect Docker image. The second build, triggered by the auto-generated transports/v* tag, uses the correct code. This results in redundant builds and wasted CI resources.

.github/workflows/transport-ci.yml#L4-L7

push:
tags:
- "core/v*" # Triggers dependency update
- "transports/v*" # Triggers docker build (for manual tags)

Fix in Cursor


BugBot free trial expires on July 22, 2025
You have used $0.00 of your $50.00 spend limit so far. Manage your spend limit in the Cursor dashboard.

Was this report helpful? Give feedback by reacting with 👍 or 👎

@akshaydeo akshaydeo deleted the 06-21-fixes_github_actions_trigger branch August 31, 2025 17:28
akshaydeo added a commit that referenced this pull request Nov 17, 2025
### TL;DR

Updated GitHub Actions workflow to trigger on tag pushes instead of branch pushes.

### What changed?

Modified the `transport-ci.yml` workflow to:
- Remove the branch trigger for `test/gh-actions`
- Uncomment and enable tag-based triggers for `core/v*` and `transports/v*`

### How to test?

1. Push a tag with the format `core/v*` to verify dependency update is triggered
2. Push a tag with the format `transports/v*` to verify docker build is triggered

### Why make this change?

This change moves the workflow from a testing phase to production usage, ensuring that the CI pipeline only runs when specific version tags are pushed rather than on branch commits. This provides better control over when dependency updates and Docker builds are triggered.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant