Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Vulkan related issue with image allocation #82

Merged
merged 4 commits into from
Jul 28, 2023

Conversation

ar7eniyan
Copy link
Contributor

Changes the image memory allocation process to work at specific hardware/drivers (RX 6600). Details in #81.
Closes #81.

@cyrinux
Copy link
Contributor

cyrinux commented Jul 28, 2023

This still works well for me on non AMD GPU

Copy link
Owner

@maximbaz maximbaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Truly impressive work, I cannot thank you enough! I just have a small nitpick on the code, and otherwise it's ready for merge.

src/frame/vulkan.rs Outdated Show resolved Hide resolved
@maximbaz maximbaz merged commit 515066a into maximbaz:main Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Crash on PC with AMD GPU (capturer = wlroots)
3 participants