Added option to disable creating the log group #75
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
What is the current behavior? (You can also link to an open issue here)
The handler checks for existence of the given log group, if it doesn't exist, it created the log group
What is the new behavior (if this is a feature change)?
By enabling the option, the handler doesn't check for the group's existence and goes on with initializing the stream.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No, existing behavior remains unchanged.
User has to explicitly trigger the option
Other information:
This change was made in an effort to reduce the security boundaries of the application (I create the log group beforehand and don't need the app to have logs:DescribeLogGroups and logs:CreateLogGroup permissions. Also, not checking if the group exists improves the performance by removing the HTTP call.
Please let me know what you think about it.
Alternatively, I propose to make the initialize and refreshSequenceToken methods protected, because currently there's no way to achieve my change by extending the class, so copy-pasting the whole class is the only solution.