Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delay type checks #264

Merged
merged 6 commits into from
Mar 24, 2024
Merged

Delay type checks #264

merged 6 commits into from
Mar 24, 2024

Conversation

maxatome
Copy link
Owner

@maxatome maxatome commented Mar 19, 2024 •
edited
Loading

@coveralls
Copy link

coveralls commented Mar 19, 2024 •
edited
Loading

Coverage Status

coverage: 99.866%. remained the same
when pulling cca6d04 on delay-type-checks
into 8f37392 on master.

@maxatome
Copy link
Owner Author

maxatome commented Mar 19, 2024 •
edited
Loading

coverage: 99.847% (-0.02%) from 99.866%

normal since code was removed...

@maxatome
feat(Array,Slice,SuperSliceOf): delay check of expected entries type
cdd7252 
until Match call, as a smuggle hook can change the type of entry being
checked during the comparison.

Signed-off-by: Maxime Soulé <[email protected]>
@maxatome
feat(Map,SubMapOf,SuperMapOf): delay check of expected entries type
d63d55a 
until Match call, as a smuggle hook can change the type of entry being
checked during the comparison.

Signed-off-by: Maxime Soulé <[email protected]>
@maxatome
feat(Struct,SStruct): delay check of expected entries type
402e0bd 
until Match call, as a smuggle hook can change the type of field being
checked during the comparison.

Signed-off-by: Maxime Soulé <[email protected]>
@maxatome
chore: remove unused util.TernStr function
e36e6c3 
Signed-off-by: Maxime Soulé <[email protected]>
@maxatome
fix: util.ToString dump of reflect.ValueOf(reflect.Value{})
974fb94 
avoiding double dereference

Signed-off-by: Maxime Soulé <[email protected]>
@maxatome
fix: as smuggle hook can return nil, check for nil just after
cca6d04 
Signed-off-by: Maxime Soulé <[email protected]>
@maxatome maxatome merged commit c874f10 into master Mar 24, 2024
10 checks passed
@maxatome maxatome deleted the delay-type-checks branch March 24, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxatome @coveralls