Repository navigation
fix(shell): stop Nushell 0.116 warning that the wt completer's spans input is deprecated - #4297
Merged
Merged
Conversation
…ted spans Nushell 0.116 binds completer inputs by parameter name and warns that a parameter named spans is deprecated each time the integration is sourced. Taking place and reading its command field keeps completions identical on 0.116 while earlier versions still pass the spans list positionally.
max-sixty
pushed a commit
that referenced
this pull request
Sep 27, 2026
Weekly CI pin bump: Nushell `0.115.1` → `0.116.0`, the latest [`nushell/nushell` release](https://github.com/nushell/nushell/releases/tag/0.116.0) (published 2026-09-26). Seven sites move together: - the five `hustcer/setup-nu` inputs: `coverage.yaml`, `benchmarks.yaml`, `nightly.yaml`, and `.github/actions/{test,tend}-setup/action.yaml` - `NU_VERSION` in `.codex/cloud.sh`, which the weekly checklist keeps level with `test-setup` - `NU_VERSION` in `Taskfile.yaml`'s `setup-web` The `nu-0.116.0-x86_64-unknown-linux-gnu.tar.gz` asset that `cloud.sh` and `setup-web` download is published on the release. This is in its own PR because Nushell's version moves PTY snapshots under `--all-features`, and this PR's CI is the only place the bump is tested on macOS and Windows. The release's one breaking change that touches this repo is the unified completer input ([nushell/nushell#18791](nushell/nushell#18791)). `templates/nushell.nu` already handles it: #4297 moved the completer to the new `place` input, so 0.116 no longer warns when the integration is sourced. Locally, with 0.116.0 on `PATH`, the `shell` integration-test subset gives the same results as with 0.115.1: 193 passed, and the same 16 failures, which are sandbox-environment snapshot failures present on main. Co-authored-by: worktrunk-bot <254187624+worktrunk-bot@users.noreply.github.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nushell 0.116.0 (released 2026-09-26) binds custom completer inputs by parameter name (nushell/nushell#18791). Our completer's parameter is still named
spans, the old name, so sourcing thewtintegration on 0.116 prints a multi-linenu::shell::deprecatedwarning ("Positional completer input deprecated") at every shell startup. Completions still work, but only through a compatibility bridge that Nushell says will be removed in a future release. After that, the completer would receivenothingandwttab completion would stop working.This PR renames the parameter to
place, the name Nushell's migration table suggests. On 0.116,placeis a record whosecommandfield holds the same token listspansused to. On older versions the argument is still the plain spans list, because they pass it positionally regardless of the parameter's name. The completer checks which of the two it received, so a single template works on both.Tested by generating the integration (
wt config shell init nu) from this branch and runningcommandline completeagainst it on Nushell 0.115.1 and 0.116.0:wt(subcommands),wt switch(branches), andwt config sh(→shell,show). These match what thespansversion returns today.nu/completion/git_error_displayunder--features shell-integration-testsgive the same results on both versions. The only two failures are fishconfig showsnapshots, which fail identically on unmodified main in this sandbox.The
init_nusnapshot changes to match the template. The CI Nushell pin bump to 0.116.0 is in a separate PR and doesn't depend on this one.