Skip to content

refactor(config): migrate template variables through MiniJinja's own parser #4141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
max-sixty merged 4 commits into from
Sep 16, 2026
Merged

refactor(config): migrate template variables through MiniJinja's own parser #4141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b2954bb
refactor(config): migrate template variables through MiniJinja's own …
worktrunk-bot Sep 16, 2026
374359c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 16, 2026
a5f81f6
test(config): pin a read in every expression shape the walk descends
worktrunk-bot Sep 16, 2026
deef2f2
test(config): cover the chained-comparison and else arms of the walk
worktrunk-bot Sep 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,8 +195,16 @@ tracing-log = { version = "0.2.0", optional = true }
# `EnvFilter::builder().with_default_directive(...).from_env_lossy()` (used in
# `src/logging.rs`) stabilized on top of the per-layer filtering rework.
tracing-subscriber = { version = "0.3.17", default-features = false, features = ["ansi", "env-filter", "fmt", "registry"], optional = true }
# Only enable needed features - saves ~200KB by excluding debug, macros, multi_template
minijinja = { version = "2.20", default-features = false, features = ["builtins", "serde", "std_collections"] }
# Only enable needed features - saves ~200KB by excluding debug, macros, multi_template.
# `unstable_machinery` exposes the parser `src/config/deprecation.rs` migrates retired
# template variables through, rather than re-deriving MiniJinja's grammar by hand; it
# pulls in `internal_debug`, which costs ~116KB of that saving back (~67KB stripped).
minijinja = { version = "2.20", default-features = false, features = [
"builtins",
"serde",
"std_collections",
"unstable_machinery",
] }
rayon = "1.12"
serde = { version = "1.0.228", features = ["derive"] }
serde_json = "1.0.150"
Expand Down
Loading
Loading