Tidy shell-integration output: prompt spacing, restart hint, one install hint

[max-sixty]

Five things the shell-config surface got wrong, all found by running wt config shell install and wt config show on a machine with five shells configured.

The prompt opened with a blank line. prompt_yes_no_preview printed one before every prompt, but most prompts are the first thing their command prints — wt config shell install, wt config plugins claude install, the commit-generation offer at the top of wt merge — so the blank was the leading blank /writing-user-outputs forbids. Two PTY snapshots covering the install prompt had a trim_start_matches('\n') compensating for it, now removed. The separator belongs to the narration it separates from, so the four callers that print first emit it themselves.

wt config shell install told an already-wrapped shell to restart. The hint says integration needs activating, and reinstalling from inside a wrapped shell is exactly when it doesn't: a version bump, or the fish conf.d to functions relocation, which writes a new file for a wrapper the running shell already has. Gated on is_shell_integration_active().

wt config show printed one remediation command per problem. An outdated wrapper, fish integration at the deprecated conf.d path, and a missing fish completions file each carried their own wt config shell install <shell>, so three problems printed three commands where the bare wt config shell install fixes all of them. Each row now counts toward the section's single trailing hint, and the fish deprecated-location row names its destination inline the way the install output's cleanup line does. To verify wrapper loaded: type wt stays separate, since installing doesn't fix it.

A deprecated fish wrapper wasn't a config location. Consolidating onto the bare command assumed it covers every state the section reports, and it didn't: with a wrapper at ~/.config/fish/conf.d/wt.fish and no ~/.config/fish/functions directory, fish has no config location, so the scan skipped it and only wt config shell install fish — which sets allow_create through its shell filter — migrated the wrapper. A worktrunk wrapper at the deprecated path now counts as fish being configured, just at the old path. That collapses should_configure into allow_create || has_config_location, makes config show's skipped-shell branch for legacy fish unreachable, and gets the wrapper into the report for a user who doesn't have fish on PATH — where the skipped list, gated on is_installed, showed nothing for fish at all.

The zsh compinit snippet rendered plain. It went through format_with_gutter where the same snippet in the install output goes through format_bash_with_gutter, so one was dim and highlighted and the other wasn't.

This was written by Claude Code on behalf of max-sixty

[worktrunk-bot]

Two things worth deciding before this merges, plus one finding inline on the hint consolidation.

codecov/patch is red. 19/23 patch lines, all four misses in src/commands/config/show.rs. Three aren't real: 1171 and 1292 are the closing )?; of writeln! calls that config_show_fish_without_completions and config_show_fish_outdated_wrapper do exercise — they only became patch lines because the reformatting from writeln!(out, "{warning}\n{hint}") split them onto their own line, and the identical unchanged )?; at 1123, 1142 and 1162 are misses on the base commit too. 1151 is the completion_path()-fails arm, which no test can trigger. The fourth, 1465, is a real gap, and it's where the inline finding lives. Per CLAUDE.md → Coverage that leaves the merge decision with you; the arithmetic is above.

Data-safety surface. src/commands/configure_shell.rs carries the fs::remove_file calls behind uninstall and the legacy-wrapper cleanups, and this diff moves the blank line out of prompt_yes_no() — the confirmation that gates them. I traced it: prompt_yes_no has one caller, prompt_for_uninstall_confirmation re-emits the blank ahead of it, and the inline snapshot in test_uninstall_preserves_rc_replaced_after_preview shows preview and consent unchanged. Noting it because the repo's review guidance holds this surface for a human regardless of how the change reads.

[worktrunk-bot]

The last review's two findings are addressed: scan_shell_configs now treats the deprecated wrapper as a config location, and test_configure_shell_no_restart_hint_when_integration_active pins the restart-hint suppression. The patch line that review called a real coverage gap — the skipped-shell legacy branch in render_shell_status — is deleted here.

Withholding approval on the data-loss hold rather than on a defect. This commit widens what a bare wt config shell install deletes: cleanup_legacy_fish_conf_d previously ran only when fish was already part of the install, and pulling fish into configured on the existence of ~/.config/fish/conf.d/wt.fish means that file is now removed on any bare install — including for a user with no ~/.config/fish/functions who never named fish. Consent is intact on the interactive path, where legacy_preview names the removal before the prompt; --yes removes it unpreviewed, as it does for the other cleanups. Existence rather than content reads as the right predicate — it is the ownership-by-path rule cleanup_legacy_fish_conf_d's own docstring settles, and a content check would leave the original bug standing for a wrapper the detector doesn't recognize. So this is .claude/skills/running-tend/references/review-pr.md → "Data-Loss Surface: Hold for Human Review" putting the merge call on you, not a change request.