Repository navigation
chore: bump the docs-site group in /docs with 5 updates - #4031
Conversation
Bumps the docs-site group in /docs with 5 updates: | Package | From | To | | --- | --- | --- | | [@astrojs/markdown-remark](https://github.com/withastro/astro/tree/HEAD/packages/markdown/remark) | `7.2.4` | `7.3.0` | | [@astrojs/sitemap](https://github.com/withastro/astro/tree/HEAD/packages/integrations/sitemap) | `3.7.3` | `3.7.4` | | [@astrojs/starlight](https://github.com/withastro/starlight/tree/HEAD/packages/starlight) | `0.41.9` | `0.42.0` | | [@expressive-code/core](https://github.com/expressive-code/expressive-code/tree/HEAD/packages/@expressive-code/core) | `0.44.1` | `0.44.2` | | [astro](https://github.com/withastro/astro/tree/HEAD/packages/astro) | `7.2.9` | `7.3.1` | Updates `@astrojs/markdown-remark` from 7.2.4 to 7.3.0 - [Release notes](https://github.com/withastro/astro/releases) - [Changelog](https://github.com/withastro/astro/blob/main/packages/markdown/remark/CHANGELOG.md) - [Commits](https://github.com/withastro/astro/commits/@astrojs/markdown-remark@7.3.0/packages/markdown/remark) Updates `@astrojs/sitemap` from 3.7.3 to 3.7.4 - [Release notes](https://github.com/withastro/astro/releases) - [Changelog](https://github.com/withastro/astro/blob/main/packages/integrations/sitemap/CHANGELOG.md) - [Commits](https://github.com/withastro/astro/commits/@astrojs/sitemap@3.7.4/packages/integrations/sitemap) Updates `@astrojs/starlight` from 0.41.9 to 0.42.0 - [Release notes](https://github.com/withastro/starlight/releases) - [Changelog](https://github.com/withastro/starlight/blob/main/packages/starlight/CHANGELOG.md) - [Commits](https://github.com/withastro/starlight/commits/@astrojs/starlight@0.42.0/packages/starlight) Updates `@expressive-code/core` from 0.44.1 to 0.44.2 - [Release notes](https://github.com/expressive-code/expressive-code/releases) - [Changelog](https://github.com/expressive-code/expressive-code/blob/main/packages/@expressive-code/core/CHANGELOG.md) - [Commits](https://github.com/expressive-code/expressive-code/commits/@expressive-code/core@0.44.2/packages/@expressive-code/core) Updates `astro` from 7.2.9 to 7.3.1 - [Release notes](https://github.com/withastro/astro/releases) - [Changelog](https://github.com/withastro/astro/blob/main/packages/astro/CHANGELOG.md) - [Commits](https://github.com/withastro/astro/commits/astro@7.3.1/packages/astro) --- updated-dependencies: - dependency-name: "@astrojs/markdown-remark" dependency-version: 7.3.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: docs-site - dependency-name: "@astrojs/sitemap" dependency-version: 3.7.4 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: docs-site - dependency-name: "@astrojs/starlight" dependency-version: 0.42.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: docs-site - dependency-name: "@expressive-code/core" dependency-version: 0.44.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: docs-site - dependency-name: astro dependency-version: 7.3.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: docs-site ... Signed-off-by: dependabot[bot] <support@github.com>
worktrunk-bot
left a comment
There was a problem hiding this comment.
The lockfile bump itself is clean, but @astrojs/starlight 0.41.9 → 0.42.0 lands two breaking changes this repo is exposed to, and check-docs will go red on both. I reproduced all three failures locally against this PR's lockfile, and I'm pushing the fix to this branch so the PR can go green.
1. npm run check fails — Starlight now ships .d.ts instead of TS sources. docs/ has no tsconfig.json, so astro check resolves under the TypeScript default (node10) and can't see dist/**/*.d.astro.ts. Five ts(2307) errors: Head.astro, PageTitle.astro (×2), 404.astro, index.astro. Fix is a docs/tsconfig.json extending astro/tsconfigs/base, which is what the error message's "consider updating to bundler" asks for. (astro/tsconfigs/strict also passes with 0 errors today if you'd rather opt into strictness — I stayed with base to keep the change scoped to the bump.)
2. npm run test:site fails — the mobile menu toggle lost its custom element. The button is no longer wrapped in <starlight-menu-button> and no longer carries aria-expanded/aria-controls; it's now a popover invoker. Two tests in docs/tests/built-site.test.mjs assert the old markup and fail: build preserves the public route contract and mobile menu control is hidden until its script is available.
3. Dead code in Head.astro. Both of this repo's mobile-menu workarounds target markup 0.42.0 no longer emits — the starlight-menu-button:not(:defined) pre-hydration style, and the MutationObserver that mirrored aria-expanded from the host onto the inner button. Upstream's #4121 removed the reason for both: the menu is now driven by the popover API and works with JavaScript disabled, so nothing hydrates and the invoker gets its expanded state from the popover mapping rather than a hand-copied attribute. I'm deleting them rather than porting them to .sl-menu-button.
One thing I could not check: docs/tests/browser-site.test.mjs (WebKit mobile layout). Playwright's webkit needs host packages this sandbox can't install, so check-docs is the first place it runs against the new fixed-position menu button.
Verification and details
Ran against this PR's docs/package-lock.json (npm ci, assets fetched the way .github/actions/docs-build does):
- Before the fix:
npm run check→ 5 errors;node --test tests/built-site.test.mjs→ 14 tests, 2 fail. - After:
npm run check→ 0 errors / 22 files;npm test→ 15 pass;node --test tests/built-site.test.mjs→ 14 pass;npm run build→ clean.
Old markup vs. 0.42.0, from a local build of this branch:
- <div id="starlight__sidebar" class="sidebar-pane">
- <button aria-expanded="false" aria-label="Menu" aria-controls="starlight__sidebar"> (inside <starlight-menu-button>)
+ <sl-sidebar-pane popover id="starlight__sidebar" class="sidebar-pane …">
+ <button popovertarget="starlight__sidebar" class="sl-menu-button …"><svg…/><svg…/><span class="sr-only">Menu</span></button>
The updated assertions follow that shape, and the repurposed test keeps a assert.doesNotMatch(faqPage, /starlight-menu-button/) guard so the deleted Head.astro workarounds can't quietly come back.
Things I checked that are not affected:
docs/src/styles/custom.css—.sidebar-panestill matches (the class survives thediv→sl-sidebar-paneswap), and nothing there keys onaria-expandedor the new--sl-menu-button-size. The new button rules read--sl-color-white/--sl-color-black, which this repo deliberately inverts for the warm palette; contrast still resolves correctly in both themes.hero.taglineindocs/src/pages/404.astro— 0.42.0 removed the top-leveltaglineconfig option, not the hero schema field.sitemapCompatibility()— unrelated to the@astrojs/sitemap3.7.4 homepage fix, which only applies undertrailingSlash: "never"orbuild.format: "file"; this site uses the defaults.- The lockfile's removed
@bruits/satteri-*entries are hoisting, not dropped platform binaries. @astrojs/markdown-remark7.3.0's new MDX dependencies don't change theunified()processor path — build and all 15 plugin tests pass.
Also worth knowing: 0.42.0 drops official support for Chromium < 116, Safari < 17.0, and Firefox < 125.
Starlight 0.42.0 replaces the <starlight-menu-button> custom element with a popover-invoker button, and ships JavaScript plus .d.ts files instead of TypeScript sources. Three things in docs/ break on the bump: - astro check cannot resolve the new declaration files without a moduleResolution of bundler/node16/nodenext, so add a tsconfig.json extending astro/tsconfigs/base. - Head.astro's pre-hydration hiding style and the MutationObserver that mirrored aria-expanded onto the inner button both target markup that no longer exists. Upstream's popover rewrite makes the menu work with JavaScript disabled, so delete them rather than port them. - built-site.test.mjs asserted the old markup in two tests; point them at the popover button and sidebar pane, and keep a guard against the deleted Head.astro workarounds reappearing. Verified with npm run check, npm test, npm run build, and node --test tests/built-site.test.mjs against this branch's lockfile.
|
fix the issues, @worktrunk-bot |
…rn/docs/docs-site-697e14a87b
|
Green at The Starlight 0.42 adaptation was already on the branch from my earlier review, so the outstanding problem was staleness: the branch was 49 commits behind Worth noting because I flagged it as unverified last time: One thing to decide before merging: because the branch carries a non-Dependabot commit, Dependabot has stopped maintaining it ("Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself"), so it is pinned to the versions in its description while the group has moved on — |
Bumps the docs-site group in /docs with 5 updates:
7.2.47.3.03.7.33.7.40.41.90.42.00.44.10.44.27.2.97.3.1Updates
@astrojs/markdown-remarkfrom 7.2.4 to 7.3.0Release notes
Sourced from @astrojs/markdown-remark's releases.
Changelog
Sourced from @astrojs/markdown-remark's changelog.
Commits
2fdf731[ci] release (#17849)f8e9458feat: move MDX into the processors themselves (#17262)Updates
@astrojs/sitemapfrom 3.7.3 to 3.7.4Release notes
Sourced from @astrojs/sitemap's releases.
Changelog
Sourced from @astrojs/sitemap's changelog.
Commits
2fdf731[ci] release (#17849)52d3f56fix(@astrojs/sitemap): preserve root path/in sitemap URLs when trailingSl...2bfb179chore: simpler package.json types (#17229)Updates
@astrojs/starlightfrom 0.41.9 to 0.42.0Release notes
Sourced from @astrojs/starlight's releases.
... (truncated)
Changelog
Sourced from @astrojs/starlight's changelog.
... (truncated)
Commits
88ad3c2[ci] release (#4172)74cb3f1Update dependencies (#4173)6135f01Use Sätteri 0.10 APIs (#4134)2623ae6Refactor mobile menu to use Popover API (#4121)09af1c6chore(deps): updatemagic-stringto v1 (#4082)292fb17[i18nIgnore] Transpile Starlight packages (#3572)0138f22[ci] release (#4169)32a5e29Fix hidden heading anchor links (#4167)cdfafd8perf: optimize route and sidebar lookups (#4148)dd7fb97chore: add benchmarks (#4157)Updates
@expressive-code/corefrom 0.44.1 to 0.44.2Release notes
Sourced from @expressive-code/core's releases.
Changelog
Sourced from @expressive-code/core's changelog.
Commits
5c5b452[CI] Release (#469)Updates
astrofrom 7.2.9 to 7.3.1Release notes
Sourced from astro's releases.
... (truncated)
Changelog
Sourced from astro's changelog.
... (truncated)
Commits
92f23cc[ci] release (#17900)0389640fix: dont use internal paths (#17899)f800de1[ci] release (#17881)1e0b7e6[ci] format4671a5cchore(deps): update react to v19 in0-cssfixture (#17888)31b886bUpdate bundled Zod to 4.5 (#17862)e747cbaSkip unsupported Vary responses in the memory cache (#17886)fb5b0d0[ci] formatce7c91fAdd--ignore-lockflag support toastro preview(#17767)c0b6581feat: use logger instead of console where possible (#17818)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions