feat(release): sign Windows binaries via SignPath - #3553
Merged
Conversation
Adds a SignPath signing step to the Windows release build, gated behind the SIGNPATH_API_TOKEN secret. Non-blocking (continue-on-error) while the project is on SignPath's self-signed test certificate, so a signing hiccup can't take down crates.io/homebrew/winget/AUR publishing. Checksums are recomputed after signing since the signed zip's bytes differ from the unsigned one. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The earlier commit used a self-serve free-trial org created by an Okta signup quirk, not the "Worktrunk [OSS]" org SignPath's team actually reviewed and approved for the Foundation program. Repoint at the real org/project/policy slugs, which already had a dedicated low-privilege "CI builds" submitter provisioned for this exact use. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
worktrunk-bot
approved these changes
Jul 23, 2026
3 tasks
max-sixty
added a commit
that referenced
this pull request
Jul 23, 2026
…rmat (#3556) ## Summary - The SignPath action's `skip-decompress` defaults to `false`, so it would have extracted the returned zip's contents as loose files into `target/distrib/` instead of saving back a signed `worktrunk-x86_64-pc-windows-msvc.zip`. The checksum step would have silently hashed the still-unsigned zip, and the release would have shipped unsigned Windows binaries with no CI failure to flag it. - `sha256sum` without `-b` omits the `*` binary-mode marker; cargo-dist's own checksums use `<hash> *<filename>` (confirmed against a real release asset). Added `-b` to match. Confirmed via `gh run view` on #3553's own CI run that `build-local-artifacts` is skipped on PRs in this repo, so this code path has never actually executed — this is the first real fix before it runs for real on a tagged release. ## Test plan - [x] `actionlint .github/workflows/release.yaml` — no new warnings (same pre-existing shellcheck style notes as before) - [x] Verified `skip-decompress` behavior against the action's own `action.yml` input spec - [x] Verified checksum format against a real downloaded release asset (`v0.68.0`) > _This was written by Claude Code on behalf of Max_
Merged
max-sixty
added a commit
that referenced
this pull request
Jul 24, 2026
Highlights: clickable CI and dev-server-URL statusline segments in Claude Code (#3550), `wt merge --no-rebase` accepting merge-shaped fast-forward histories (#3509), a faster and lower-CPU `wt switch` picker (#3544, #3534), and SignPath code signing for the Windows release binary (#3553). Full details in CHANGELOG.md. > _This was written by Claude Code on behalf of max_
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wt.exe+git-wt.exe) via SignPath's free OSS code-signing program, using thetest-signingpolicy (self-signed test certificate) while the project's Foundation-program application is under review.continue-on-error) so a signing hiccup can't take down crates.io/homebrew/winget/AUR publishing..sha256checksum after signing, since the signed zip's bytes differ from the unsigned one.CI buildsSignPath identity (submitter-only), not an admin account.Test plan
actionlintclean (only pre-existing shellcheck style warnings elsewhere in the file)wt.exe+git-wt.exe) validated against SignPath's own XML parser and against the real file layout inside a downloadedv0.68.0Windows release zip