feat(config): wt config update adopts json-schema = 2 instead of pinning 1 - #3436
Merged
Conversation
…ing 1 The update command is the migration path forward: on an unset key it now writes the upcoming default ([list] json-schema = 2) rather than pinning the current one. The wt list JSON nag flips accordingly: staying on schema 1 is the manual edit, adopting is the offered command. This removes the pinned-to-1 cohort the future default flip would otherwise leave behind. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
worktrunk-bot
approved these changes
Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flips the direction of the
[list] json-schemapending-default handling that #3411 introduced:wt config updatenow writesjson-schema = 2(adopting the upcoming default) instead of pinning= 1(preserving the current one). Running update is the migration; staying on schema 1 is the deliberate manual edit.The
wt list --format=jsonnag flips to match, keeping the adopt action last for easy copying:Why: with pin-to-1, every
wt config updaterun during the deprecation window entrenched users on the schema being retired, leaving a pinned cohort the default flip could never migrate. With adopt-2, update moves users forward as a reviewed config edit, and after the flip= 2is just a redundant default a future rule can strip. The trade:wt config update --yesin a script switches JSON output as a side effect of unrelated migrations (the interactive path shows the diff first).The system-config gate is unchanged — when the system layer defines the key, update leaves the user file alone; the test now covers the sharper direction (system
= 1must not be overridden by a user-file= 2). All detection/warning invariants carry over; the diff is ~6 semantic lines plus pin→adopt wording and 65 one-line snapshot flips.🤖 Generated with Claude Code