Reformat two asserts in the conversation render tests so ruff format passes - #94
Conversation
`ruff format` 0.16.1 puts an assert's message inside parentheses after the condition rather than wrapping the condition itself. Two asserts added with the cancelled-panel-gesture test carry the older shape, so the `ruff format` hook rewrites the file and `pre-commit` fails the `lint` job on main.
|
Same failure again on main, one commit later: run 33163787168 on 4b02f53 ("Extract conversation reaction surfaces"). The hook diff in that run is byte-identical to this PR's — the same two asserts in The fix still applies unchanged at main's current head, fdb8b0a: both asserts are still in their pre-format shape there, and Not opening a second PR for the new run. |
|
One correction to the note above, in this PR's favour: Python has landed since this branch's base now, so that check needs redoing at main's current head — and it still comes back clean. The occurrence that sent me here, run 33164610688 on ce5e352, is an older commit than the one already recorded above, so it adds nothing beyond the count. Not opening a second PR. |
|
Still the same failure, now on run 33166597109 (9ae8f83, "Extract source history validation") — byte-identical hook diff, same two asserts. Re-verified at main's current head d6d377a (five commits past the head of the last check above): |
lintis red on main:ruff formatrewritestests/test_render_conversations.py, sopre-commitreports "files were modified by this hook" and the job fails. The two asserts dbfaeaa ("End cancelled panel gestures") added carry ruff's older assert shape — condition wrapped in parentheses, message trailing — where 0.16.1 puts the message in parentheses after a bare condition. This commit appliesruff@0.16.1 format, which is the hook's own output; there is no other change.Verified on the branch (rebased onto
ea2f4e7, main's current head):ruff@0.16.1 format --check .→123 files already formatted, andruff@0.16.1 check --no-fix .→All checks passed!. Thetestjob was already green on the failing run, and this diff is whitespace and parentheses only, so behaviour is unchanged; the touched test collects (its local run stops atBrowserType.launch— no Playwright browser in the tend sandbox).The hook's diff, from the failed run
The second hunk is the same rewrite on the
COVERED_TOPassert at line 2344.Third `ruff` failure on main today
linthas gone red on four of the last twelveciruns on main, each on a differentrufffinding in the commit that had just landed: 56891785 and ac8fe9e (both since fixed by later commits, closing #89 and #90), and now this one. Nothing in the repo can catch these earlier —wt merge'spre-commiton the maintainer's machine is the only gate ahead of CI, and each of these reached main with the hook's own output unapplied. That is a local-flow observation, not something this PR changes.Automated fix for failed run