Skip to content

Realign five nightly tests to the toggling panel addresses - #548

Merged
max-sixty merged 1 commit into
mainfrom
fix/ci-34468213858
Sep 10, 2026
Merged

Realign five nightly tests to the toggling panel addresses#548
max-sixty merged 1 commit into
mainfrom
fix/ci-34468213858

Conversation

@leaf-agent

Copy link
Copy Markdown
Collaborator

What this fixes

The scheduled ci run 34468213858 came back 22 failed, 2378 passed, 6 skipped. Eighteen of those still fail on main at 08b4de95; the other four were repaired by #536, which merged an hour after the nightly commit. This branch takes the five that belong to one cause and leaves the rest to #547, because each of them turns on a decision this branch should not make for the maintainer.

The named panel addresses toggle, and five nightly cases still chord into a standing panel. #530 made g T, g A and g L close the pane they name, "matching each pane's visible toggle", and #536 built its covering-workspace modality on that contract and updated the one nightly case it ran. The five here open the panel some other way first — a click on the Threads toggle, or a arriving on an ask — and then press g T to put the keyboard on the list. Under the toggle contract that completion closes the panel, so .lf-threads never takes focus and the assertion times out on inactive. Nothing about these tests' subjects — a forced-colors region reading, a walk down the list, the room a stuck run heading takes, panel-versus-page scroll keys, the ask a thread question keeps making — depends on which press opened the panel; they only need the keyboard standing on the list rather than in a box. Each now completes the address twice, closing the standing panel and arriving on the second, which is the route the toggle contract actually offers and what the added comments say.

The everyday gate that lands a pull request does not run test_render_*, so #530 landed green with these five unread. They have not been run since; yesterday's nightly was the last one before it.

Testing

The five cases pass together on this head under the default -n 2 and individually under -n0. pre-commit is clean on the changed files. The change is confined to nightly test arrangement, so no product path moves.

What this leaves

Thirteen failures remain on main, tracked in #547. They fall into three groups: the response bar's Floating UI placement in #537 (seven cases, including margin actions the bar now covers and a composer that no longer scrolls with its passage), the third keydown listener #542 added outside the key register (one case, whose repair needs the register to reach a hoisted margin proxy), and five with no cause established here.

@max-sixty
max-sixty merged commit 2a67f0d into main Sep 10, 2026
4 checks passed
@max-sixty
max-sixty deleted the fix/ci-34468213858 branch September 10, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants