Realign five nightly tests to the toggling panel addresses - #548
Merged
Conversation
This was referenced Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
The scheduled
cirun 34468213858 came back 22 failed, 2378 passed, 6 skipped. Eighteen of those still fail onmainat08b4de95; the other four were repaired by #536, which merged an hour after the nightly commit. This branch takes the five that belong to one cause and leaves the rest to #547, because each of them turns on a decision this branch should not make for the maintainer.The named panel addresses toggle, and five nightly cases still chord into a standing panel. #530 made
g T,g Aandg Lclose the pane they name, "matching each pane's visible toggle", and #536 built its covering-workspace modality on that contract and updated the one nightly case it ran. The five here open the panel some other way first — a click on the Threads toggle, oraarriving on an ask — and then pressg Tto put the keyboard on the list. Under the toggle contract that completion closes the panel, so.lf-threadsnever takes focus and the assertion times out oninactive. Nothing about these tests' subjects — a forced-colors region reading, a walk down the list, the room a stuck run heading takes, panel-versus-page scroll keys, the ask a thread question keeps making — depends on which press opened the panel; they only need the keyboard standing on the list rather than in a box. Each now completes the address twice, closing the standing panel and arriving on the second, which is the route the toggle contract actually offers and what the added comments say.The everyday gate that lands a pull request does not run
test_render_*, so #530 landed green with these five unread. They have not been run since; yesterday's nightly was the last one before it.Testing
The five cases pass together on this head under the default
-n 2and individually under-n0.pre-commitis clean on the changed files. The change is confined to nightly test arrangement, so no product path moves.What this leaves
Thirteen failures remain on
main, tracked in #547. They fall into three groups: the response bar's Floating UI placement in #537 (seven cases, including margin actions the bar now covers and a composer that no longer scrolls with its passage), the thirdkeydownlistener #542 added outside the key register (one case, whose repair needs the register to reach a hoisted margin proxy), and five with no cause established here.