Skip to content

Replace a 250ms sleep in the work-line test with a real control #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
max-sixty merged 4 commits into from
Aug 26, 2026
Merged

Replace a 250ms sleep in the work-line test with a real control #44

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5a5f8e4
Give the work-line absence a control rather than a 250ms budget
leaf-agent Aug 26, 2026
06f3b50
Read the whole action channel where the test names one verb
leaf-agent Aug 26, 2026
bd3a614
Merge main and keep the controlled work-line assertion
max-sixty Aug 26, 2026
67d77e9
Merge remote-tracking branch 'origin/main' into fix/work-line-absence…
max-sixty Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions tests/test_render_options.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2434,11 +2434,20 @@ def test_local_work_chrome_does_not_take_its_holder_gesture(browser, serve, tmp_
work_line = page.locator("#job-mounts > .lf-work-line")
expect(work_line).to_be_visible()
work_line.click()
page.wait_for_timeout(250)

assert not any(
e["kind"] == "action" for e in events_model.read_events(serve.page_dir)
)
# A press that does nothing states no fact to wait on, so the control is the same
# gesture where it is supposed to work: pick the neighbouring option and let its
# send settle. One outbox in gesture order means a pick the work line had taken
# would already stand ahead of this one, so the whole log can be read once.
page.locator("#job-heater").click()
round_trip(page)

picks = [
(e["widget"], e["detail"])
for e in sent_events(serve.page_dir)
if e["kind"] == "action"
]
assert picks == [("jobs", {"options": ["job-heater"]})], picks
expect(page.locator("#job-mounts")).not_to_have_attribute("chosen", "")
assert errors == []
page.close()
Expand Down
Loading