-
Notifications
You must be signed in to change notification settings - Fork 1
Launch the browser LEAF_BROWSER_EXECUTABLE names, else the Chrome channel #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| """The browser the user-path gates launch. | ||
|
|
||
| `version check --render` and `version export` both draw the page in a real | ||
| browser, and both should reach whichever one the host has. Playwright's | ||
| `channel="chrome"` finds a Google Chrome release-channel install at a fixed OS | ||
| path and nothing else, so a Chrome for Testing, a distro or Homebrew Chromium, | ||
| or a self-hosted build is invisible to it — even though every render invariant | ||
| passes on one, which is why the suite's own fixture drives the headless shell. | ||
| With no outbound network Playwright's usual answer of fetching its own browser | ||
| is gone too, and leaf does not download one. | ||
|
|
||
| So the host names its browser, in the namespace `host.py` already uses for | ||
| LEAF_AGENT and LEAF_SESSION_ID. The variable carries a path and nothing else: | ||
| the launch takes no other argument from the host, and the default is unchanged | ||
| where it names none. | ||
| """ | ||
|
|
||
| import os | ||
|
|
||
| VARIABLE = "LEAF_BROWSER_EXECUTABLE" | ||
|
|
||
|
|
||
| def named_executable() -> str | None: | ||
| """The browser this host named, or None where it named none. Empty is none, | ||
| so a caller handing a child its own environment can unname one.""" | ||
| return os.environ.get(VARIABLE) or None | ||
|
|
||
|
|
||
| def launch_browser(p): | ||
| """The host's browser: whichever executable LEAF_BROWSER_EXECUTABLE names, | ||
| else the installed Chrome release channel. Raises PlaywrightError, which | ||
| each gate reports in its own words.""" | ||
| if executable := named_executable(): | ||
| return p.chromium.launch(executable_path=executable) | ||
| return p.chromium.launch(channel="chrome") | ||
|
|
||
|
|
||
| def browser_hint() -> str: | ||
| """The line each gate appends when the launch failed.""" | ||
| if executable := named_executable(): | ||
| return f"{VARIABLE} named {executable}." | ||
| return f"{VARIABLE} names one if this host has no installed Chrome." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Counting two levels up finds the registry root only on Linux. On macOS the executable is
chromium-<build>/chrome-mac/Chromium.app/Contents/MacOS/Chromium, soparents[1].nameisContentsand thersplitraisesIndexError— the fixture dies before it can raise its ownAssertionError, and every test that asks for it errors. Naming thechromium-<build>directory rather than its depth holds on both.