Skip to content

Read the search match's box in the frame that drew it #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
leaf-agent wants to merge 1 commit into from
Closed

Read the search match's box in the frame that drew it #111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions tests/test_render_semantic_selection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,9 +416,20 @@ def test_selection_search_scrolls_to_the_match_inside_a_tall_text_block(browser,

expect(page.locator(".lf-target-search-status")).to_have_text("1 of 1")
expect(page.locator(".lf-target-match")).not_to_have_count(0)
mark = page.locator(".lf-target-match").first.bounding_box()
keyline_top = page.locator(".lf-keyline").bounding_box()["y"]
assert mark["y"] > 42 and mark["y"] + mark["height"] < keyline_top
# Both boxes off one frame. The layer redraws every match as one span it replaces
# whole (paintHere's replaceChildren), and the instant scroll this search just made
# delivers its own scroll event a frame later — so a handle taken out here is
# measured after the node it named has been swapped for an identical one, and reads
# as an element with no box rather than as the mark standing exactly where it was.
placed = page.evaluate(
"""() => {
const mark = document.querySelector('.lf-target-match')
.getBoundingClientRect();
const line = document.querySelector('.lf-keyline').getBoundingClientRect();
return {top: mark.top, bottom: mark.bottom, keyline: line.top};
}"""
)
assert placed["top"] > 42 and placed["bottom"] < placed["keyline"]

page.keyboard.press("Enter")
assert page.evaluate("() => getSelection().toString()") == "copper needle"
Expand Down
Loading