Skip to content

Make the comment-button clearance test able to fail again #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
max-sixty merged 3 commits into from
Aug 29, 2026
Merged

Make the comment-button clearance test able to fail again #103

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c0e4a6b
State the arrangement the comment-button clearance test rests on
leaf-agent Aug 29, 2026
2cad1d2
Narrow the clearance test to where the row is genuinely in the way
leaf-agent Aug 29, 2026
501235c
Read the clearance test's controls at their corners, not only their c…
leaf-agent Aug 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion tests/test_render_anchors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,15 @@ def test_the_comment_button_stands_on_no_control(browser, serve):

Asserted through the hit test rather than the rectangles, since what matters is which
element the press would reach — and then by making the press, which is the whole
claim."""
claim.

Both readings ask where the row's own centre is, so both go quiet together the moment
the bar stops reaching it, and neither says so. That is not hypothetical: the bar
carrying six reaction pills reached 219px past the row, and the bar carrying 💬 and one
ellipsis misses it by 2.9px, so between those two shapes this test passed on a page
where nothing was ever in the way. The walk stepping is the arrangement, so state it —
the sibling test below already does, and it is the assertion that caught the same
staleness rather than sleeping through it."""
page, errors = open_page(browser, serve(SUGGESTION_PAGE))
box = page.locator("#replace").bounding_box()
Comment thread
leaf-agent marked this conversation as resolved.
select(
Expand All @@ -493,6 +501,11 @@ def test_the_comment_button_stands_on_no_control(browser, serve):
steps=16,
)
expect(page.locator(".lf-fab")).to_be_visible()
assert page.locator(".lf-fab-bar").evaluate(
"el => el.getBoundingClientRect().top"
) > page.locator("[data-lf-for='sug-refill']").evaluate(
"el => el.getBoundingClientRect().bottom"
), "the bar never stepped past the row, so standing on no control proves nothing"

under = page.evaluate("""() => [...document.querySelectorAll("[data-lf-offer]")]
.filter(c => !c.closest(".lf-chrome"))
Expand Down
Loading